The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.
Signed-off-by: Lidza Louina
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
/lustre/lnet: changes value to
correct type for assignment
On Jun 23, 2016, at 3:27 PM, Lidza Louina wrote:
>
> - Original Message -
> From: oleg.dro...@intel.com
> To: lidza.lou...@oracle.com
> Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
> de...@dr
-devel] [PATCH v2] staging/lustre/lnet: changes value to
correct type for assignment
On Jun 23, 2016, at 2:56 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch makes the code use the correct type of int to
> suppress a smatc
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch makes the code use the correct type of int to
suppress a smatch warning.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
-devel] [PATCH] staging/lustre/lnet: correctly casts value
for arithmetic
On Jun 23, 2016, at 2:07 PM, Lidza Louina wrote:
> The smatch warning was "drivers/staging/lustre/lnet/lnet/api-ni.c:516
> lnet_res_lh_initialize() warn: should '1 << ibits' be a 64 bit type?"
-devel] [PATCH] staging/lustre/lnet: correctly casts value
for arithmetic
NAK.
On Jun 23, 2016, at 1:24 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch casts the unsigned regular int to suppress
> smatch warnings.
>
>
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch casts the unsigned regular int to suppress
smatch warnings.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On 05/27/2016 02:07 PM, Joe Perches wrote:
On Fri, 2016-05-27 at 13:51 -0400, Lidza Louina wrote:
The wl pointer was initialized as a pointer to a struct wilc and
assigned to a piece of memory the size of the pointer. It should be the
size of struct wilc.
This isn't necessary.
The co
The wl pointer was initialized as a pointer to a struct wilc and
assigned to a piece of memory the size of the pointer. It should be the
size of struct wilc.
Signed-off-by: Lidza Louina
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 05/17/2016 02:53 AM, Dan Carpenter wrote:
When I read the code, I just assumed desc was a pointer and it should
have been:
if (!desc)
return NULL;
For me, "if (rc) " is way more readable than "if (rc != 0) ". So
readability could go either way depending on what you
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 3 +++
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 8 ++-
_udesc)" block instead of at the top of the function,
since it isn't used anywhere else.
Cheers, Andreas
Definitely, will do.
I'll change desc to rc and update the if statement and send another
patch now.
Lidza
- Patrick
On 05/16/2016 09:17 AM, Lidza Louina wrote:
The lustre_m
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 9 +++-
On 05/13/2016 12:43 PM, Drokin, Oleg wrote:
On May 12, 2016, at 6:33 PM, Lidza Louina wrote:
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Thank you for the patch, it looks good code-wise, but
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c
b/drivers/staging/lustre/lustre/ptlrpc/sec.c
index 187fd1d..e6fe
I'll try this patchset again after Masanari Iida's patches are accepted after
the merge window.
Lidza
On Fri, Jan 17, 2014 at 11:01 AM, Lidza Louina wrote:
> This patch removes the KERNEL_VERSION conditionals.
> The driver is built for this kernel version, so the
> conditio
Acked-by: Lidza Louina
On Tue, Jan 14, 2014 at 10:40 AM, Masanari Iida wrote:
> This patch fixed trailing whitespace error found by
> checkpatch.pl in dgap/digi.h
>
> Signed-off-by: Masanari Iida
> ---
> drivers/staging/dgap/digi.h | 24
>
Originally, this driver created it's own allocating
function. This patch removes that function and calls
kzalloc directly.
This patch affects:
- driver.c
- driver.h
- fep5.c
- tty.c
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_driver.c | 18 ++
dr
The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(*brd), GFP_KERNEL);
Signed-off-by: Lidza Louina
---
drivers/staging
On Thu, Oct 3, 2013 at 1:23 AM, Greg KH wrote:
> On Tue, Oct 01, 2013 at 12:54:20PM -0400, Lidza Louina wrote:
>> + return 0;
>> +
>> +err_unregister_serial:
>> +tty_unregister_driver(brd->SerialDriver);
>> +err_free_print_ttys:
>
On Tue, Oct 1, 2013 at 1:59 PM, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 12:32:06PM -0400, Lidza Louina wrote:
>> On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter
>> wrote:
>> > On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> >> @@ -30
On Mon, Sep 30, 2013 at 9:46 PM, Greg KH wrote:
> On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
>> On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat
>> wrote:
>> > This check is not required.
>> >
>> > Signed-off-by: Sachin Kamat
>
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
dri
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Sign
On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
>>
>> DPR_INIT(("DGAP REGISTER TTY: MAJORS: %d %d\n",
>> brd->S
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
dri
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Sign
On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat wrote:
> This check is not required.
>
> Signed-off-by: Sachin Kamat
> Cc: Lidza Louina
> ---
> drivers/staging/dgnc/dgnc_kcompat.h |5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/
On Thu, Sep 26, 2013 at 6:22 AM, Dan Carpenter wrote:
> On Wed, Sep 25, 2013 at 07:08:54PM -0400, Lidza Louina wrote:
>> This patch removes this smatch warning:
>> unsigned '--un->un_open_count' is never less than zero
>>
>> The code decremented the un_ope
On Thu, Sep 26, 2013 at 6:19 AM, Dan Carpenter wrote:
> This one is not right.
>
> On Wed, Sep 25, 2013 at 07:08:53PM -0400, Lidza Louina wrote:
>> This patch changes error handling to the
>> tty_driver allocations in dgap_tty_register.
>>
>> Before, it di
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Sign
fore freeing. This check isn't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/staging/dgap/dgap_tty.c
index 0b3c039..59fda2e 100644
--- a/dri
On Wed, Sep 25, 2013 at 7:08 PM, Greg KH wrote:
> On Mon, Sep 09, 2013 at 03:01:27PM -0400, Lidza Louina wrote:
>> The arguments that were passed into sizeof were
>> generic. This patch changes this by putting
>> the actual item that we need a size of instead.
>>
>
d-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/staging/dgap/dgap_tty.c
index 2b26152..0b3c039 100644
--- a/drivers/staging/dgap/dgap_tty.c
+++ b/drivers/staging/dgap/dgap_
e brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation will fail. It now calls put_tty_driver on
that driver after it fails and returns -ENOMEM.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 26 ++
1 file changed, 18 insertions(+), 8 deletio
This patch removes these smatch warnings from dgap_driver.c:
redundant null check on dgap_config_buf calling kfree()
redundant null check on brd->flipbuf calling kfree()
redundant null check on brd->flipflagbuf calling kfree()
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_dr
On Wed, Sep 25, 2013 at 6:29 PM, Dan Carpenter wrote:
> On Wed, Sep 25, 2013 at 06:13:47PM -0400, Lidza Louina wrote:
>> On Wed, Sep 25, 2013 at 2:34 PM, Dan Carpenter
>> wrote:
>> > On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
>> >>
>>
On Wed, Sep 25, 2013 at 2:34 PM, Dan Carpenter wrote:
> On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
>>
>> I looked at other uses of the function alloc_tty_driver() in
>> the kernel and none of them seem to follow up with a
>> call to kfree().
>
>
On Tue, Sep 24, 2013 at 3:20 PM, Dan Carpenter wrote:
> On Tue, Sep 24, 2013 at 02:40:10PM -0400, Lidza Louina wrote:
>> Instead of writing:
>> brd->SerialDriver = alloc_tty_driver(MAXPORTS);
>> if (!brd->SerialDriver){
>> goto free
On Mon, Sep 23, 2013 at 8:27 PM, Dan Carpenter wrote:
> On Mon, Sep 23, 2013 at 06:47:16PM -0400, Lidza Louina wrote:
>> This patch removes these warnings:
>> potential null dereference 'brd->SerialDriver'. (alloc_tty_driver returns
>> null)
>> pote
On Mon, Sep 23, 2013 at 8:10 PM, Dan Carpenter wrote:
> On Tue, Sep 24, 2013 at 03:06:06AM +0300, Dan Carpenter wrote:
>> On Mon, Sep 23, 2013 at 06:47:13PM -0400, Lidza Louina wrote:
>> > This patch removes this smatch warning:
>> > warn: missing break? reassignin
On Mon, Sep 23, 2013 at 8:00 PM, Dan Carpenter wrote:
> On Mon, Sep 23, 2013 at 06:47:17PM -0400, Lidza Louina wrote:
>> This patch removes this smatch warning:
>> unsigned '--un->un_open_count' is never less than zero
>>
>> The code decremented the un_ope
On Mon, Sep 23, 2013 at 6:16 PM, Dan Carpenter wrote:
> On Mon, Sep 23, 2013 at 04:22:10PM -0400, Lidza Louina wrote:
>> Awesome, thanks.
>>
>> Btw, are will still in the merge window? Do you need me to send out
>> fixes for warnings (sparse or smatch) or can I send thi
e serial and print drivers were
allocated and not null before being initialized. This
patch adds that check.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 103 +---
1 file changed, 54 insertions(+), 49 deletions(-)
diff --git a/drivers/st
d-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/staging/dgap/dgap_tty.c
index 2b26152..7f909b8 100644
--- a/drivers/staging/dgap/dgap_tty.c
+++ b/drivers/staging/dgap/dgap_
work. This patch tests
un_open_count against 0 without decrementing it.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/staging/dgap/dgap_tty.c
index 8f0a824..f496710 100644
---
This patch removes these smatch warnings from dgap_driver.c:
redundant null check on dgap_config_buf calling kfree()
redundant null check on brd->flipbuf calling kfree()
redundant null check on brd->flipflagbuf calling kfree()
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_dr
This patch removes this smatch warning:
warn: missing break? reassigning 'ch->pscan_state'
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_fep5.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap_fep5.c b/drivers
fore freeing. This check isn't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/staging/dgap/dgap_tty.c
index 7f909b8..924e2bf 100644
--- a/dri
On Mon, Sep 23, 2013 at 4:16 PM, Greg KH wrote:
> On Mon, Sep 23, 2013 at 04:13:15PM -0400, Lidza Louina wrote:
>> This patch adds the staging/dgnc [DIGI NEO AND CLASSIC
>> PCI PRODUCTS] and staging/dgap [DIGI EPCA PCI PRODUCTS]
>> drivers to the MAINTAINERS file. I am listed
This patch adds the staging/dgnc [DIGI NEO AND CLASSIC
PCI PRODUCTS] and staging/dgap [DIGI EPCA PCI PRODUCTS]
drivers to the MAINTAINERS file. I am listed as the
maintainer and the driverdev-devel list is the mailing
list for these drivers.
Signed-off-by: Lidza Louina
---
MAINTAINERS | 12
On Thu, Sep 12, 2013 at 6:00 PM, Greg KH wrote:
> On Mon, Sep 09, 2013 at 03:01:24PM -0400, Lidza Louina wrote:
>> This patch removes casting around kzalloc calls.
>> The casts aren't needed because kzalloc returns
>> a void pointer.
>>
>> Signed-off-by: Li
On Tue, Sep 10, 2013 at 6:05 PM, Dan Carpenter wrote:
> This one is not right.
>
> On Mon, Sep 09, 2013 at 03:01:28PM -0400, Lidza Louina wrote:
>> This patch replaces kzalloc with kcalloc when using
>> arrays. kcalloc is better suited for arrays because
>>
On Tue, Sep 10, 2013 at 6:12 PM, Dan Carpenter wrote:
> On Mon, Sep 09, 2013 at 03:01:22PM -0400, Lidza Louina wrote:
>> This patch renames the struct board_t to dgnc_board. board_t
>> wasn't a good name for it since the _t suffix is for typedefs.
>>
>> Signed-off-
This patch removes parentheses around return
statements. They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 8 +-
drivers/staging/dgnc/dgnc_driver.c | 106 +--
drivers/staging/dgnc/dgnc_mgmt.c | 22 ++--
drivers/staging/dgnc/dgnc_
This patch removes the error messages associated
with errors in kzalloc. The driver doesn't need to
add the error message because kzalloc already prints
a more useful message.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_tty.c
This patch removes the conditionals that make sure
the driver supports various versions of the kernel.
They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 12
drivers/staging/dgnc/dgnc_kcompat.h | 24 ---
drivers/staging/dgnc/dgnc_
This patch removes casting around kzalloc calls.
The casts aren't needed because kzalloc returns
a void pointer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver
The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(*brd), GFP_KERNEL);
Signed-off-by: Lidza Louina
---
drivers/staging
This patch renames the struct board_t to dgnc_board. board_t
wasn't a good name for it since the _t suffix is for typedefs.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 14 +--
drivers/staging/dgnc/dgnc_driver.c | 20 +++
drivers/staging
This patch replaces kzalloc with kcalloc when using
arrays. kcalloc is better suited for arrays because
it has overflow protection.
Reported-by: Dan Carpenter
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
On Fri, Sep 6, 2013 at 5:50 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 04:48:30PM -0400, Lidza Louina wrote:
>> This patch removes the error messages associated
>> with errors in kzalloc. The driver doesn't need to
>> add the error message because kzalloc alrea
On Fri, Sep 6, 2013 at 5:45 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 04:48:32PM -0400, Lidza Louina wrote:
>> The arguments that are passed into sizeof were
>> generic. This patch changes this by putting
>> the actual item that we need a size of inste
This patch removes the conditionals that make sure
the driver supports various versions of the kernel.
They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 12
drivers/staging/dgnc/dgnc_kcompat.h | 24 ---
drivers/staging/dgnc/dgnc_
This patch removes parentheses around return
statements. They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 8 +-
drivers/staging/dgnc/dgnc_driver.c | 106 +--
drivers/staging/dgnc/dgnc_mgmt.c | 22 ++--
drivers/staging/dgnc/dgnc_
This patch removes casting around kzalloc calls.
The casts aren't needed because kzalloc returns
a void pointer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver
This patch removes the error messages associated
with errors in kzalloc. The driver doesn't need to
add the error message because kzalloc already prints
a more useful message.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_tty.c
The arguments that are passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(brd), GFP_KERNEL);
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc
This patch renames the struct board_t to dgnc_board. board_t
wasn't a good name for it since the _t suffix is for typedefs.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 14 +--
drivers/staging/dgnc/dgnc_driver.c | 20 +++
drivers/staging
On Sun, Sep 1, 2013 at 7:50 PM, Dan Carpenter wrote:
> On Sat, Aug 31, 2013 at 06:19:10PM -0400, Lidza Louina wrote:
>> This patch replaces all instances of "sizeof(struct"
>> with actual instances of the struct. For example
>> "sizeof(struct tty_str
On Sun, Sep 1, 2013 at 8:14 PM, Dan Carpenter wrote:
> The point I was trying to make earlier was that I don't like knee jerk
> error messages. Some people put an error message after every line
> without thinking about it. It's a very common source of bugs is to
> have a NULL dereference like:
>
On Sun, Sep 1, 2013 at 8:07 PM, Dan Carpenter wrote:
> On Sat, Aug 31, 2013 at 06:19:11PM -0400, Lidza Louina wrote:
>> This patch adds the dgnc_board struct to driver.h.
>> This struct will replace board_t in this driver.
>>
>
> So on this one patches 3, 4 and 5 sh
This patch removes the struct board_t. This struct
was replaced with dgnc_board in a previous patch.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 85 --
1 file changed, 85 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers
This patch removes the error statements that follow
kzalloc. These are useless because kzalloc has its
own error statement and the driver's error handling
would never actually happen.
Reported-by: Dan Carpenter
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c
This patch replaces all instances of "sizeof(struct"
with actual instances of the struct. For example
"sizeof(struct tty_struct" is replaced with
"sizeof(brd->SerialDriver.ttys".
This patch affects driver.c, mgmt.c and tty.c.
Signed-off-by: Lidza Louina
---
d
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_mgmt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgnc
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.c | 116 +++---
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a/drivers
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 200
1 file changed, 100 insertions(+), 100 deletions(-)
diff --git a/drivers
This patch replaces struct board_t with dgnc_board.
It contains the exact same information as board_t.
This change was made because board_t isn't descriptive
and the _t denotes a typedef, which it is not.
Reported-by: Dan Carpenter
Signed-off-by: Lidza Louina
---
drivers/staging
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 102 ++---
1 file changed, 51 insertions(+), 51 deletions(-)
diff --git a/drivers
This patch adds the dgnc_board struct to driver.h.
This struct will replace board_t in this driver.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 85 ++
1 file changed, 85 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
This patch removes this checkpatch warning:
ERROR: return is not a function, parentheses are not
required.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers
This patch removes casting that is used when kzalloc
is called. Casting isn't needed because kzalloc
returns a void pointer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
On Fri, Aug 30, 2013 at 2:28 PM, Greg KH wrote:
> On Thu, Aug 29, 2013 at 07:00:37PM -0400, Lidza Louina wrote:
>> This patchs adds a TODO for the driver.
>>
>> Signed-off-by: Lidza Louina
>> ---
>> drivers/staging/dgnc/TODO | 17 +
>> 1 fi
This patchs adds a TODO for the driver.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/TODO | 17 +
1 file changed, 17 insertions(+)
create mode 100644 drivers/staging/dgnc/TODO
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
new file mode 100644
index
On Wed, Aug 28, 2013 at 4:30 AM, Dan Carpenter wrote:
> On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote:
>> @@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>>
>> /* get the board structure and prep it */
>> brd
On Wed, Aug 28, 2013 at 4:30 AM, Dan Carpenter wrote:
> On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote:
>> @@ -501,7 +501,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>>
>> /* get the board structure and prep it */
>> brd
On Wed, Aug 28, 2013 at 12:54 AM, Greg KH wrote:
> I'll take this for now, but all of these casts of the kzalloc() call
> need to go away, as they are pointless (kzalloc() returns a void *,
> which automatically can be assigned to any pointer type, no need to be
> explicit about it.)
>
> So that m
On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina wrote:
> On Wed, Aug 28, 2013 at 12:57 AM, Greg KH wrote:
>> On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
>>> This patch removes the dgnc_driver_kzmalloc function from
>>> driver.c and driver.h. A
On Wed, Aug 28, 2013 at 12:57 AM, Greg KH wrote:
> On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_driver_kzmalloc function from
>> driver.c and driver.h. A previous patch replaced all
>> dgnc_driver_kzmalloc function calls with
)
expected struct neo_uart_struct [noderef] *ch_neo_uart
got struct neo_uart_struct *
warning: incorrect type in assignment (different address spaces)
expected struct cls_uart_struct [noderef] *ch_cls_uart
got struct cls_uart_struct *
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc
This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with kzalloc.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 15 ---
drivers/staging/dgnc/dgnc_driver.h | 1 -
2
This patch replaces dgnc_driver_kzmalloc with kzalloc.
A patch that follows removes the dgnc_driver_kzmalloc
function.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
drivers/staging/dgnc/dgnc_tty.c| 20 ++--
2 files changed, 13 insertions
On Tue, Aug 27, 2013 at 7:48 PM, Greg KH wrote:
> On Tue, Aug 27, 2013 at 06:19:43PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_driver_kzmalloc function from
>> driver.c. The patch that follows replaces all
>> dgnc_driver_kzmalloc functions calls with kzall
On Tue, Aug 27, 2013 at 7:29 PM, Dan Carpenter wrote:
> On Tue, Aug 27, 2013 at 06:19:43PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_driver_kzmalloc function from
>> driver.c. The patch that follows replaces all
>> dgnc_driver_kzmalloc functions calls wit
This patch removes the dgnc_driver_kzmalloc function from
driver.c. The patch that follows replaces all
dgnc_driver_kzmalloc functions calls with kzalloc.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a
This patch replaces dgnc_driver_kzmalloc with kzalloc. A
previous patch removed that function from the code.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
drivers/staging/dgnc/dgnc_tty.c| 20 ++--
2 files changed, 13 insertions(+), 13
On Tue, Aug 27, 2013 at 2:46 PM, Dan Carpenter wrote:
> On Tue, Aug 27, 2013 at 11:20:06AM -0400, Lidza Louina wrote:
>> This patch changes the dgnc_driver_kzmalloc declaration.
>> The kernel's kmalloc function previously took an int
>> priority. That's been repla
)
expected struct neo_uart_struct [noderef] *ch_neo_uart
got struct neo_uart_struct *
warning: incorrect type in assignment (different address spaces)
expected struct cls_uart_struct [noderef] *ch_cls_uart
got struct cls_uart_struct *
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc
1 - 100 of 201 matches
Mail list logo
