Google
> Google LLC, 1600 Amphitheatre Parkway, Mountain View, CA 94043, USAlogo
> You have received this message because someone sent you an email via
> Gmail confidential mode.
>
--
Regards,
Laurent Pinchart
_
bridge/analogix/anx7625.c | 245 --
> drivers/gpu/drm/bridge/analogix/anx7625.h | 18 +-
> 2 files changed, 203 insertions(+), 60 deletions(-)
[snip]
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxd
t? I'll use Connector's ".atomic_check()"
> interface to detect Content Protection property change.
> (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2674580)
Please note that upstream review happens on mailing lists, not in
gerrit.
s.h
>
> Signed-off-by: Nikolay Kyx
Reviewed-by: Laurent Pinchart
> ---
>
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
>
> drivers/staging/media/omap4iss/iss_regs.h | 16
> 1 file changed, 8 insertions(+), 8
parentheses in a
subsequent patch if desired.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
(0x88 + (0x20 *
> (i)))
>
> -#define CSI2_CTX_CTRL3(i)(0x8c + (0x20 * i))
> +#define CSI2_CTX_CTRL3(i)(0x8c + (0x20 * (i)))
> #define CSI2_CTX_CTRL3_ALPHA_SHIFT 5
> #define CSI2_CTX_CTRL3_ALPHA_MAS
de 100644 drivers/staging/media/zoran/TODO
> > create mode 100644 drivers/staging/media/zoran/videocodec.c
> > create mode 100644 drivers/staging/media/zoran/videocodec.h
> > create mode 100644 drivers/staging/media/zoran/zoran.h
> > create mode 100644 drivers/staging/media/zoran/zoran_card.c
> > create mode 100644 drivers/staging/media/zoran/zoran_card.h
> > create mode 100644 drivers/staging/media/zoran/zoran_device.c
> > create mode 100644 drivers/staging/media/zoran/zoran_device.h
> > create mode 100644 drivers/staging/media/zoran/zoran_driver.c
> > create mode 100644 drivers/staging/media/zoran/zr36016.c
> > create mode 100644 drivers/staging/media/zoran/zr36016.h
> > create mode 100644 drivers/staging/media/zoran/zr36050.c
> > create mode 100644 drivers/staging/media/zoran/zr36050.h
> > create mode 100644 drivers/staging/media/zoran/zr36057.h
> > create mode 100644 drivers/staging/media/zoran/zr36060.c
> > create mode 100644 drivers/staging/media/zoran/zr36060.h
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Mauro,
On Tue, Aug 25, 2020 at 01:30:25PM +0200, Mauro Carvalho Chehab wrote:
> Em Tue, 25 Aug 2020 05:29:29 +1000
> Dave Airlie escreveu:
>
> > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
> > wrote:
> > >
> > > Hi Mauro,
> > >
>
Hi Mauro,
On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote:
> > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
>
644 drivers/staging/hikey9xx/gpu/Makefile
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_defs.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_defs.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dpe.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c
> > create mode 100644
> > drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_dsi_reg.h
> > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
MIPI CSI2) is the
video mux that selects between the MIPI CSI2 receiver and the parallel
sensor input. On i.MX7D, this models the "CSI Input MUX Control" bit in
register IOMUXC_GPR_GPR5. On i.MX8M, there seems to be no such mux, as
there seems to be no parallel sensor input. It should thus be safe to
drop the check, but other adjustements to the routing and pipeline
configuration logic in the driver will likely be needed.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Laurent Pinchart
I expect Sakari to take this patch in his tree when he will be back from
vacation at the end of the month.
> ---
> Conti
ompiler will tell you why.
Regardless, drivers/staging/media/soc_camera/soc_camera.c is in staging
because it will be removed from the kernel, cleanups for this file won't
be accepted.
> static int soc_camera_try_fmt(struct soc_camera_device *icd,
> st
Hello Xin,
Thank you for the patch.
On Thu, Jun 04, 2020 at 03:58:05PM +0800, Xin Ji wrote:
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/anal
dummy snd_seq snd_seq_device
> veth bridge stp llc tun nf_nat_tftp nf_conntrack_tftp nf_nat_ftp
> nf_conntrack_ftp esp6 ah6 ip6t_REJECT ip6t_ipv6header cmac rfcomm uinput
> ipu3_imgu(C) ipu3_cio2 iova videobuf2_v4l2 videobuf2_common
> videobuf2_dma_sg videobuf2_memops ov13858 ov567
>
>
> so we can allow compile-testing as well.
>
> Fixes: d65dd85281fb ("media: staging: rkisp1: add Rockchip ISP1 base driver")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Laurent Pinchart
> ---
> drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +-
> driver
Hi Greg,
On Tue, Mar 31, 2020 at 02:47:56PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Mar 31, 2020 at 03:39:14PM +0300, Laurent Pinchart wrote:
> > On Tue, Mar 31, 2020 at 02:22:09PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laur
Hi Greg,
On Tue, Mar 31, 2020 at 02:22:09PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laurent Pinchart wrote:
> > On Tue, Mar 31, 2020 at 01:11:53PM +0200, Mauro Carvalho Chehab wrote:
> > > Most of media Kconfig/Makefile files already has SPD
ile
> @@ -1,3 +1,5 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> obj-$(CONFIG_VIDEO_HANTRO) += hantro-vpu.o
>
> hantro-vpu-y += \
> diff --git a/drivers/staging/media/rkisp1/Makefile
> b/drivers/staging/media/rkisp1/Makefile
&g
Hi Mauro,
On Thu, Mar 26, 2020 at 09:28:32AM +0100, Mauro Carvalho Chehab wrote:
> Em Thu, 26 Mar 2020 00:13:43 +0200 Laurent Pinchart escreveu:
> > On Wed, Mar 25, 2020 at 10:38:20PM +0100, Mauro Carvalho Chehab wrote:
> > > Em Wed, 25 Mar 2020 16:36:31 -0300 Helen Koike escrev
*only* real piece of evidence we have, let's not assume we
know better.
> > and selecting those doesn't do anything, and people can even think
> > that, if they want to enable an USB device, just enabling the USB option
> > there is enough (which is not), since no
Hi Alex,
On Fri, Mar 20, 2020 at 10:03:39AM +0100, Alex Riesen wrote:
> Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
> > wrote:
> > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> > > > On T
x_update_bits(s, ADV748X_PAGE_IO, r, m,
> v)
> +#define io_update(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_IO, r, m,
> v)
Those two are identical. Do we need both ? I would standardize on either
*_update or *_clrset for all the functions here. Apart from that,
Reviewed-by: Laur
Hi Alex,
Thank you for the patch.
On Thu, Mar 19, 2020 at 06:41:43PM +0100, Alex Riesen wrote:
> Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 24
> drivers/media/i2c/adv748x/adv748x
I2C bus. The main address is mandatory, others are
> optional and remain at default values if not specified.
>
> + - #clock-cells: must be <0> if the I2S port is used
Wouldn't it be simpler to set it to 0 unconditionally ?
Reviewed-by: Laurent Pinchart
> +
> Opt
48x/adv748x.h
> b/drivers/media/i2c/adv748x/adv748x.h
> index fccb388ce179..09aab4138c3f 100644
> --- a/drivers/media/i2c/adv748x/adv748x.h
> +++ b/drivers/media/i2c/adv748x/adv748x.h
> @@ -19,6 +19,8 @@
> */
>
> #include
> +#include
> +#include
>
> #ifndef _ADV748X_H_
> #define _ADV748X_H_
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
re -> ec50.sound:DAI1 Capture
> ...
> [ 128.961389] rsnd_write: rcar_sound ec50.sound: w ssi[4] - SSICR ( 124)
> : 9ceb0100
>
> Decoding this last line (9ceb0100) gives SSICR.TRMD (bit1) =0, SSICR.SCKD
> (bit15) =0, SSICR.SWSD (bit14) =0. The combination is documented as "sla
Hi Alex,
(CC'ing Morimoto-san)
On Fri, Mar 06, 2020 at 02:41:54PM +0100, Alex Riesen wrote:
> Laurent Pinchart, Fri, Mar 06, 2020 14:16:32 +0100:
> > On Thu, Mar 05, 2020 at 03:36:28PM +0100, Alex Riesen wrote:
> >> Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100:
&g
r plain default setting?
>
> As the ADV748x devices seem to provide also the clocks for video outputs, will
> it make any sense to place the clock definition into the port node?
> Or should all provided clocks be indexed in the main device node?
Those clocks are part of the CSI-2 protocol and also don't need to be
explicitly controlled. As far as I can tell from a quick check of the
ADV7482 documentation, only the I2S MCLK is a general-purpose clock that
needs to be exposed.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_RX);
> if (ret) {
> dev_err_ratelimited(module->dev,
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
const struct v4l2_mbus_framefmt *mbus,
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c
> b/drivers/staging/media/imx/imx7-media-csi.c
> index a708a0340eb1..6e2f4c3eb24f 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
>
(iss->dev, mem);
> + iss->regs[res] = devm_platform_ioremap_resource(pdev, res);
>
> return PTR_ERR_OR_ZERO(iss->regs[res]);
> }
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
elam
The change looks good to me.
Reviewed-by: Laurent Pinchart
and applied to my tree for v5.5.
> ---
> drivers/staging/media/omap4iss/iss.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/s
Hi Xin Ji,
On Mon, Oct 14, 2019 at 03:02:48AM +, Xin Ji wrote:
> On Fri, Oct 11, 2019 at 03:54:18PM +0300, Laurent Pinchart wrote:
> > On Fri, Oct 11, 2019 at 01:21:43PM +0200, Andrzej Hajda wrote:
> >> On 11.10.2019 04:21, Xin Ji wrote:
> >>> The ANX7625 is a
nd example with USB-C port.
That would help with the discussion, yes.
> [1]:
> https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf
>
> [2]: Documentation/devicetree/bindings/connector/usb-connector.txt
>
> > +
> > +required:
> > + - "#address-cells"
on that luck.
Rob, how does yaml schema handle this ?
> +required:
> + - compatible
> + - reg
> + - port@0 | port@1
> +
> +example:
> + - |
> +anx_bridge: anx7625@58 {
The node name should describe the device's function. How about
encoder@58 ?
> +compatible
om the connect output port.
> +
> +required:
> + - compatible
> + - reg
> + - dsi-channel-id
> + - dsi-lanes-num
> + - port@0
> +
> +example:
> + - |
> +anx_bridge: anx7625@58 {
> +compatible = "analogix,anx7625&quo
-#define ISPCCDC_LSC_AFTER_REFORMATTER_MASK (1<<6)
> +#define ISPCCDC_LSC_AFTER_REFORMATTER_MASK BIT(6)
>
> #define ISPCCDC_LSC_INITIAL_X_MASK 0x3F
> #define ISPCCDC_LSC_INITIAL_X_SHIFT 0
[snip]
With this small issue addressed,
For omap3isp, vsp1, xilinx, wl128x and ipu3,
Reviewed-by: Laurent Pinchart
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Mauro,
Thank you for the patch.
On Thu, Aug 22, 2019 at 04:39:32PM -0300, Mauro Carvalho Chehab wrote:
> As warned by cppcheck:
>
> [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed
> 32-bit value by 31 bits is undefined behaviour
> [drivers/media/pci/bt8xx/btt
Hello Xin Ji,
Thank you for the patch.
On Fri, Jun 28, 2019 at 03:00:05AM +, Xin Ji wrote:
> Move analogix chip ANX78XX bridge driver into "analogix" directory.
>
> Signed-off-by: Xin Ji
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/bridge/Kconfig
+= synopsys/
> +obj-y += analogix/
Could you place that line just above the synopsys/ directory, to have
them alphabetically sorted (this could also be done while applying) ?
Apart from that the patch looks good to me, so
Reviewed-by: Laurent Pinchart
> diff --git a/drivers/gpu/drm/bridg
est. If time permits, after getting capture working, I'll see if I can
start cleaning it up.
> Reported-by: Laurent Pinchart
> Signed-off-by: Rui Miguel Silva
> ---
> drivers/staging/media/imx/imx-ic-prpencvf.c | 2 +-
> drivers/staging/media/imx/imx-media-capture.c
Hi Rui,
On Tue, Mar 12, 2019 at 02:07:02PM +, Rui Miguel Silva wrote:
> On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote:
> > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote:
> >> On Fri 18 May 2018 at 06:58, Sakari Ailus wrote:
> >>> On T
Hi Rui,
On Tue, Mar 12, 2019 at 02:05:24PM +, Rui Miguel Silva wrote:
> On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote:
> > Hi Rui,
> >
> > Thank you for the patch.
>
> Where have you been for the latest 14 versions? :)
Elsewhere I suppose :-)
> This is
; + interrupts = ;
> + clocks = <&clks IMX7D_IPG_ROOT_CLK>,
> + <&clks IMX7D_MIPI_CSI_ROOT_CLK>,
> + <&clks IMX7D_MIPI_DPHY_ROOT_CLK>;
> + clock-names = "pclk", "wrap", "phy";
> + power-domains = <&pgc_mipi_phy>;
> + phy-supply = <®_1p0d>;
> + resets = <&src IMX7_RESET_MIPI_PHY_MRST>;
> + reset-names = "mrst";
> + status = "disabled";
How about already declaring port@0 here too (but obviously without any
endoint) ?
> + };
> };
>
> aips3: aips-bus@3080 {
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>> +
> >> +- reg : (required) can take the values 0 or 1,
> >> where 0 is the
> >> + related sink port and port 1 should be
> >> the source one;
> >> +
> >> +endpoint node
> >> +-
>
7;m aware that that
identifier has been deprecated by the FSF in favour of the GPL-2.0-or-later
identifier, but until Documentation/process/license-rules.rst gets updated,
please use GPL-2.0+.
> /*
> * TI OMAP4 ISS V4L2 Driver
> *
Could you please remove the boilerplate license
Hi Geert,
On Saturday, 21 April 2018 11:07:11 EEST Laurent Pinchart wrote:
> On Friday, 20 April 2018 16:28:29 EEST Geert Uytterhoeven wrote:
> > The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs
> > only. Since commit 9b5ba0df4ea4f940 ("ARM:
a more appropriate platform dependency
> than the legacy ARCH_SHMOBILE, hence use the former.
>
> This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near
> future.
>
> Signed-off-by: Geert Uytterhoeven
Acked-by: Laurent Pinchart
How would you like to get this merg
Hi Mauro,
Thank you for the patch.
On Thursday, 5 April 2018 23:29:44 EEST Mauro Carvalho Chehab wrote:
> This driver compile as-is with COMPILE_TEST.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
I don't have patches pending for the omap4iss driver, c
xtraneous space.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Laurent Pinchart
> ---
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
&g
here's a lot of api and overview stuff already around, would be great to
> make this more accessible.
>
> But I wouldn't put this as a de-staging blocker, just an idea.
>
> On the series: Acked-by: Daniel Vetter
>
> No full review since a bunch of stuff I'm
a_unmap_kernel(struct ion_heap *heap,
> - struct ion_buffer *buffer)
> -{
> + sg_free_table(buffer->sg_table);
> + kfree(buffer->sg_table);
> }
>
> static struct ion_heap_ops ion_cma_ops = {
> .allocate = ion_cma_alloca
Hi Arushi,
Thank you for the patch.
On Friday 24 Mar 2017 21:31:45 Arushi Singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
>
> Signed-off-by: Arushi
end-users of these complex devices don't really care
> about a plugin: they want full control and won't typically use generic
> applications. If they would need support for that, we'd have seen much more
> interest. The main re
d" data suitable for display, then
> it wants to use "ISP Resizer output". Once application knows what
> output it wants, there's just one path through the system. So being
> able to tell the ENT_T_DEVNODEs apart does not seem to be critical.
>
> OTOH, for useful camera application, different paths are needed at
> different phases.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Daniel,
On Monday 06 Mar 2017 11:38:20 Daniel Vetter wrote:
> On Fri, Mar 03, 2017 at 06:45:40PM +0200, Laurent Pinchart wrote:
> > - I haven't seen any proposal how a heap-based solution could be used in a
> > generic distribution. This needs to be figured out before commi
Hi Daniel,
On Monday 06 Mar 2017 11:32:04 Daniel Vetter wrote:
> On Fri, Mar 03, 2017 at 10:50:20AM -0800, Laura Abbott wrote:
> > On 03/03/2017 08:41 AM, Laurent Pinchart wrote:
> >> On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote:
> >>> When CMA was first intro
ed, 312 insertions(+), 958 deletions(-)
> > delete mode 100644 drivers/staging/android/ion/hisilicon/Kconfig
> > delete mode 100644 drivers/staging/android/ion/hisilicon/Makefile
> > delete mode 100644 drivers/staging/android/ion/hisilicon/hi6220_ion.c
> > delete mode 100644 drivers/staging/android/ion/ion_dummy_driver.c
> > create mode 100644 drivers/staging/android/ion/ion_enumerate.c
> > delete mode 100644 drivers/staging/android/ion/ion_of.c
> > delete mode 100644 drivers/staging/android/ion/ion_of.h
> > delete mode 100644 drivers/staging/android/ion/tegra/Makefile
> > delete mode 100644 drivers/staging/android/ion/tegra/tegra_ion.c
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ion_cma_allocate,
> .free = ion_cma_free,
> - .map_user = ion_cma_mmap,
> - .map_kernel = ion_cma_map_kernel,
> - .unmap_kernel = ion_cma_unmap_kernel,
> + .map_user = ion_heap_map_user,
> + .map_kernel = ion_heap_map_kernel,
> + .unmap_kernel = ion_heap_unmap_kernel,
> };
>
> struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *data)
> @@ -147,7 +102,7 @@ struct ion_heap *ion_cma_heap_create(struct
> ion_platform_heap *data) * get device from private heaps data, later it
> will be
>* used to make the link with reserved CMA memory
>*/
> - cma_heap->dev = data->priv;
> + cma_heap->cma = data->priv;
> cma_heap->heap.type = ION_HEAP_TYPE_DMA;
> return &cma_heap->heap;
> }
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
rs/staging/android/ion/ion_page_pool.c
> > @@ -30,9 +30,6 @@ static void *ion_page_pool_alloc_pages(struct
> > ion_page_pool *pool)>
> > if (!page)
> >
> > return NULL;
> >
> > - if (!pool->cached)
> > - ion_pages_sync_for_device(NULL, page, PAGE_SIZE << pool-
>order,
> > - DMA_BIDIRECTIONAL);
> >
> > return page;
> >
> > }
> >
> > diff --git a/drivers/staging/android/ion/ion_system_heap.c
> > b/drivers/staging/android/ion/ion_system_heap.c index 6cb2fe7..a1b
> > 100644
> > --- a/drivers/staging/android/ion/ion_system_heap.c
> > +++ b/drivers/staging/android/ion/ion_system_heap.c
> > @@ -75,9 +75,6 @@ static struct page *alloc_buffer_page(struct
> > ion_system_heap *heap,>
> > page = ion_page_pool_alloc(pool);
> >
> > - if (cached)
> > - ion_pages_sync_for_device(NULL, page, PAGE_SIZE << order,
> > - DMA_BIDIRECTIONAL);
> >
> > return page;
> >
> > }
> >
> > @@ -401,8 +398,6 @@ static int ion_system_contig_heap_allocate(struct
> > ion_heap *heap,>
> > buffer->sg_table = table;
> >
> > - ion_pages_sync_for_device(NULL, page, len, DMA_BIDIRECTIONAL);
> > -
> >
> > return 0;
> >
> > free_table:
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
end_cpu_access(struct dma_buf *dmabuf,
> @@ -1031,9 +1024,15 @@ static int ion_dma_buf_end_cpu_access(struct dma_buf
> *dmabuf, {
> struct ion_buffer *buffer = dmabuf->priv;
>
> - mutex_lock(&buffer->lock);
> - ion_buffer_kmap_put(buffer);
> - mutex_unlock(&buffer->lock);
> + if (buffer->heap->ops->map_kernel) {
> + mutex_lock(&buffer->lock);
> + ion_buffer_kmap_put(buffer);
> + mutex_unlock(&buffer->lock);
> + }
> +
> + dma_unmap_sg(buffer->dev->dev.this_device, buffer->sg_table->sgl,
> + buffer->sg_table->nents,
> + DMA_BIDIRECTIONAL);
>
> return 0;
> }
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ndroid/ion/hisilicon/Kconfig
> delete mode 100644 drivers/staging/android/ion/hisilicon/Makefile
> delete mode 100644 drivers/staging/android/ion/hisilicon/hi6220_ion.c
> delete mode 100644 drivers/staging/android/ion/ion_dummy_driver.c
> create mode 100644 drivers/s
Hi Avraham,
Thank you for the patches.
On Thursday 09 Feb 2017 18:57:55 Avraham Shukron wrote:
> Fixed multi-line comments to their preferred style (First line empty)
>
> Signed-off-by: Avraham Shukron
For both of them,
Acked-by: Laurent Pinchart
I've applied the patches
7;s some discussion here:
> >
> > http://www.spinics.net/lists/linux-media/msg109493.html>
>
> [Added Sebastian do Cc:]
>
> Yes, this is essentially the same driver, except that this driver also
> handles MMIO-bitfield controlled muxes, and that
Hi Benoit,
On Tuesday 07 Feb 2017 07:36:48 Benoit Parrot wrote:
> Laurent Pinchart wrote on Tue [2017-Feb-07 12:26:32 +0200]:
> > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> >> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> >>> On Monday 06 Feb 20
Hi Philipp,
On Tuesday 07 Feb 2017 11:41:30 Philipp Zabel wrote:
> On Tue, 2017-02-07 at 12:26 +0200, Laurent Pinchart wrote:
> > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> >> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> >>> On Monday 06 Feb 20
Hi Steve,
On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> >> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
> >>> On Tuesday 24 Jan 2017 18:07:55 Steve
Hi Hans,
(CC'ing Sakari)
On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
> > On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote:
> >> On 01/24/2017 04:02 AM, Philipp Zabel wrote:
> >>> On Fri, 2017-01-20
I would think
> > there have to be other capture IP cores that can signal aborted frames
> > or frame timeouts.
>
> Yes, agreed. A frame capture timeout, or frame interval error, are
> both generic concepts. At some point it would be great to make the
> Frame Interval Mon
channel 0,
> otherwise no data is received from the MIPI CSI-2 sensor, regardless
> of the virtual channel the sensor is transmitting over.
>
> So it seems the info on the 8-bit mct_di buses generated by the CSI2IPU
> gasket are ignored by the CSI's, at least the virtual channel
_BASE +
0x5001)
> +#define MEDIA_ENT_F_VID_IF_BRIDGE(MEDIA_ENT_F_BASE + 0x5002)
> +
> +/*
> * Connectors
> */
> /* It is a responsibility of the entity drivers to add connectors and links
> */
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
property is
> valid for serial busses only (e.g. MIPI CSI-2). Note that for the MIPI
> CSI-2 bus this array contains only one entry.
>
> So I think you need to have a good reason to make the clock lane non-zero.
The purpose of the data-lanes
e ov5640 and ov5642 drivers should
retrieve the clock rate and compute register values accordingly (PLL
configuration parameters for instance, but most probably other values as
well). Unfortunately, as usual with Omnivision, the lack of public and even
non-public information results in drivers hardcoding large lists of
register/value pairs that have been computed for a specific clock frequency.
The drivers will thus not operate correctly if the clock is running at a
different rate. Until that can be fixed, the best option is probably to assign
the rate in the device tree as Philipp proposed, and to use clk_get_rate() in
the driver to reject any rate other than 22MHz.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nse and
> makes it easier on the user.
To be precise, userspace is responsible for propagating formats *between*
subdevs (source to sink, over a link) and drivers for propagating formats *in*
subdevs (sink to source, inside the subdev).
> >>> v4l2-ctl
Hi Steve,
Thank you for the patch. Many of the comments below apply to the ov5642 driver
too, please take them into account when reworking patch 23/24.
On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote:
> This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta
> branch, m
v4l2_fh_exit(&handle->vfh);
> kfree(handle);
> }
>
> @@ -1162,6 +1163,7 @@ static int iss_video_release(struct file *file)
> vb2_queue_release(&handle->queue);
>
> v4l2_fh_del(vfh);
> + v4l2_fh_e
ry here you will get a crash pretty soon afterwards.
> return -ENODEV;
> }
> /* Increment device users counter */
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Leo,
Thank you for the patch, and sorry for the late reply.
On Sunday 23 Oct 2016 14:02:23 Leo Sperling wrote:
> This is a patch to the vpfe_video.c file that fixes an indentation
> warning reported by checkpatch.pl
>
> Signed-off-by: Leo Sperling
Acked-by: Laurent Pinchart
static const" is interpreted the same as "const static",
> and VPFE_RSZ_INTP_CUBIC is defined as zero, so the initializations
> are not really needed.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Laurent Pinchart
and applied to my tree. I will send a pull request for v4.11
Hi Manuel,
Thank you for the patch and sorry for the late reply.
On Tuesday 08 Mar 2016 01:16:06 Manuel Rodriguez wrote:
> Fix spelling error on a comment, change 'wether' to 'whether'
>
> Signed-off-by: Manuel Rodriguez
Acked-by: Laurent Pinchart
and applied t
zer_b.output = RESIZER_OUPUT_MEMORY;
> + resizer->resizer_b.output = RESIZER_OUTPUT_MEMORY;
> break;
>
> default:
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.h
> b/drivers/staging/media/davinci_vpfe/dm365_re
-Alex
>
> PS I have addressed this message to a set of interested people
> whose e-mail addresses I knew; the set is definitely incomplete.
> This will form the initial membership of the mailing list. If
> you do not want to be on tha
the driver.
> +
How does adding a blank line here fix a coding style issue ?
> sdsel.pad = pad;
> ret = v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel);
> if (!ret)
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tion operation first and
> > +* fallback to get format if not implemented.
> >
> > */
>
> This comment style is discouraged so this is at lease not perfect.
> Doesn't checkpatch complain with this change? If it doesn't
ISS_CTRL_INPUT_SEL_CSI2BBIT(2)
>
> Yet, not sure if I would like such patch, as this kind of change
> could easily break the driver if you make any typo at the GENMASK
> parameters.
It would be best to automate such a change with a script than performing it
manually.
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
IPIPE_SRC_COL_OO_GR BIT(6)
> #define IPIPE_SRC_COL_OO_B (3 << 6)
> #define IPIPE_SRC_COL_OO_GB (2 << 6)
> #define IPIPE_SRC_COL_OE_R (0 << 4)
> -#define IPIPE_SRC_COL_OE_GR (1 << 4)
> +#define IPIPE_SRC_COL_OE_GR BIT(4)
> #define IPIPE_SRC_COL_OE_B (3 << 4)
> #define IPIPE_SRC_COL_OE_GB (2 << 4)
> #define IPIPE_SRC_COL_EO_R (0 << 2)
> -#define IPIPE_SRC_COL_EO_GR (1 << 2)
> +#define IPIPE_SRC_COL_EO_GR BIT(2)
> #define IPIPE_SRC_COL_EO_B (3 << 2)
> #define IPIPE_SRC_COL_EO_GB (2 << 2)
> #define IPIPE_SRC_COL_EE_R (0 << 0)
> -#define IPIPE_SRC_COL_EE_GR (1 << 0)
> +#define IPIPE_SRC_COL_EE_GR BIT(0)
> #define IPIPE_SRC_COL_EE_B (3 << 0)
> #define IPIPE_SRC_COL_EE_GB (2 << 0)
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
* implemented.
> + /* Try the get selection operation first and
> + * fallback to get format if not implemented.
Lines can be up to 80 characters long, there's no need to wrap them after 52
characters only.
>*/
> sdsel.pad = pad;
>
ct, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie
Acked-by: Laurent Pinchart
> ---
> drivers/staging/media/
_ops once s_stream is
> moved.
>
> Suggested-by: Laurent Pinchart
> Signed-off-by: Niklas Söderlund
> ---
> drivers/media/platform/vsp1/vsp1_rpf.c | 12 +-
> drivers/media/platform/vsp1/vsp1_rwpf.c | 40 +++--
> drivers/med
ch will remove the .id field from
> struct media_entity .
>
> So, get rid of it, otherwise the omap4iss driver will fail to build.
>
> Signed-off-by: Javier Martinez Canillas
> Acked-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
With the typo fixed,
Acked-by
076ddd412201
> 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -1272,6 +1272,68 @@ done:
> return ret;
> }
>
> +/*
> + * iss_create_pads_links() - Pads links creation for the subdevices
Could you please s/pads_link
A_ENT_T_V4L2_SUBDEV) {
> + if (is_media_entity_v4l2_subdev(pad->entity)) {
> struct v4l2_subdev *sd =
> media_entity_to_v4l2_subdev(pad->entity);
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/st
,7 @@ static int ipipeif_link_setup(struct media_entity
> *entity,
>
> break;
>
> - case IPIPEIF_PAD_SOURCE_ISIF_SF | MEDIA_ENT_T_DEVNODE:
> + case IPIPEIF_PAD_SOURCE_ISIF_SF:
> /* Write to memory */
> if (flags & MEDIA
== NULL ||
> - pad->entity->type != MEDIA_ENT_T_V4L2_SUBDEV)
> + if (!pad || !is_media_entity_v4l2_subdev(pad->entity))
> break;
>
> subdev = media_entity_to_v4l2_subdev(pad->entity);
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; - case IPIPE_PAD_SOURCE_VP | MEDIA_ENT_T_V4L2_SUBDEV:
> + case IPIPE_PAD_SOURCE_VP:
> /* Send to RESIZER */
> if (flags & MEDIA_LNK_FL_ENABLED) {
> if (ipipe->output & ~IPIPE_OUTPUT_VP)
--
Regards,
Laurent Pinchart
_
t;
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda
Acked-by: Laurent Pinchart
and applied to my tree.
> ---
> drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
> - fmt)
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_format *fmt)
> {
> struct v4l2_mbus_framefmt *format;
--
Regards,
Laurent Pinchart
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
sizeof(struct clk *), GFP_KERNEL);
I'd use sizeof(*vpfe_dev->clks) to avoid such issues.
Apart from that,
Acked-by: Laurent Pinchart
I've applied the patch to my tree with the above change, there's no need to
resubmit if you agree with the proposal.
>
reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
> >
> > No ports needed for describing data connections?
>
> IMHO I'm not sure if this is applicable here, in this case the bridge
> is transparent so it's not required another device node. For example,
&g
1 - 100 of 162 matches
Mail list logo
