Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Compress return logic

2020-03-26 Thread Lakshmi Ramasubramanian
On 3/25/20 2:43 PM, Simran Singhal wrote: Simplify function returns by merging assignment and return into one command line. "Simplify function returns by merging assignment and return into one line". You could change the subject also to "Simplify function return logic". thanks, -lakshmi ___

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

2020-03-12 Thread Lakshmi Ramasubramanian
On 3/12/2020 3:49 AM, Julia Lawall wrote: Thanks for your input Julia and Stefano. That's my general preference as well, but I can't find any point in the "Describe your changes" section of submitting-patches.rst actually defining the order. I wouldn't imply that from the sequence the steps are

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions

2020-03-11 Thread Lakshmi Ramasubramanian
On 3/11/2020 6:58 AM, Shreeya Patel wrote: Remove unnecessary if and else conditions since both are leading to the initialization of "phtpriv->ampdu_enable" with the same value. Signed-off-by: Shreeya Patel Stating this based on the patch descriptions I have seen. Others, please advise\corre