Re: [PATCH] media: staging: davinci: remove vpfe driver

2019-07-24 Thread Lad, Prabhakar
mode 100644 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.c > delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.h > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-20 Thread Lad, Prabhakar
gt; > Acked-by: Sylwester Nawrocki > Acked-by: Benoit Parrot > Acked-by: Alexandre Belloni > Acked-by: Sakari Ailus > Acked-by: Philipp Zabel > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/am437x/am437x-vpfe.c| 6

Re: [PATCH] media: use unsigned for pad index

2016-01-05 Thread Lad, Prabhakar
f.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_isif.c| 2 +- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- For the above: Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad ___ devel mailing list de...@

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-18 Thread Lad, Prabhakar
On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote: > On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: >> This fixes a checkpatch style error in vpfe_buffer_queue_setup. >> >> Signed-off-by: Alex Dowad >> --- >> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- >> 1 file chan

Re: [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID

2015-03-09 Thread Lad, Prabhakar
On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee wrote: > check if it is already defined before defining SM750LE_REVISION_ID > again and at the same time mention correct data type. > > Signed-off-by: Sudip Mukherjee > --- > > v2: removed the redundant cast in sm750_hw.c > > drivers/staging/sm750f

Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print

2015-03-09 Thread Lad, Prabhakar
On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee wrote: > mention correct format specifier while printing. > fixes all the build warnings about incorrect argument type while > printing. > > Signed-off-by: Sudip Mukherjee > --- > > V2: Giedrius commented resource_size_t can be either u64 or u32 > d

Re: use of opaque subject lines

2015-02-05 Thread Lad, Prabhakar
On Thu, Feb 5, 2015 at 5:57 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 05, 2015 at 04:57:09PM +0000, Lad, Prabhakar wrote: >> On Thu, Feb 5, 2015 at 4:30 PM, Al Viro wrote: >> > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote: >> > >> >>

Re: use of opaque subject lines

2015-02-05 Thread Lad, Prabhakar
On Thu, Feb 5, 2015 at 4:30 PM, Al Viro wrote: > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote: > >> On a serious note: I do understand what you're getting at, I don't take >> that personally (and I will send a v2 addressing the things above), but >> honestly, this kind of answe

[PATCH] hyperv: fix sparse warnings

2015-02-05 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch fixes following sparse warnings: netvsc.c:688:5: warning: symbol 'netvsc_copy_to_send_buf' was not declared. Should it be static? rndis_filter.c:627:5: warning: symbol 'rndis_filter_set_offload_params' was not declared. Should it

Re: [PATCH RFC] staging: media: davinci_vpfe: drop condition with no effect

2015-01-29 Thread Lad, Prabhakar
On Mon, Jan 26, 2015 at 7:27 AM, Nicholas Mc Guire wrote: > As the if and else branch body are identical the condition has no effect and > can be dropped. > > Signed-off-by: Nicholas Mc Guire Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > > As the if and t

Re: [PATCH] staging: davinci_vpfe: fix space prohibited before semicolon warning

2015-01-20 Thread Lad, Prabhakar
Hi, Thanks for the patch. On Wed, Jan 14, 2015 at 9:46 PM, Aya Mahfouz wrote: > This patch fixes the following checkpatch.pl warning: > > space prohibited before semicolon > > Signed-off-by: Aya Mahfouz Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > v1:

Re: [PATCH] staging: fix davinci_vpfe: fix space prohibted before that ','

2015-01-20 Thread Lad, Prabhakar
Hi, On Wed, Jan 21, 2015 at 4:52 AM, Ahmad Hassan wrote: > This patch fixes the following checkpatch.pl error: > fix space prohibited before that ',' at line 904 Thanks for the patch, but there already exists a patch [1] fixing this. [1] https://patchwork.linuxtv.org/patch/27912/ Thanks, --Pra

[PATCH] media: davinci_vpfe: dm365_resizer: fix sparse warning

2014-04-28 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch fixes following sparse warning, dm365_resizer.c:223:1: warning: symbol 'resizer_calculate_resize_ratios' was not declared. Should it be static? dm365_resizer.c:313:5: warning: symbol 'resizer_configure_output_win' was not declared

[PATCH] staging: media: davinci_vpfe: fix checkpatch warning

2014-03-28 Thread Lad, Prabhakar
From: "Lad, Prabhakar" This patch fixes following checkpatch warning, media/davinci_vpfe/dm365_ipipe.c:1271: WARNING: Missing a blank line after declarations media/davinci_vpfe/dm365_ipipe.c:1313: WARNING: Missing a blank line after declarations Signed-off-by: Lad, Prabhakar --

[PATCH 0/2] staging: media: davinci_vpfe: fixes and enhancement

2014-03-22 Thread Lad, Prabhakar
From: "Lad, Prabhakar" The first patch adds v4l2_fh for priority handling and the second patch makes sure that the buffers are released if start_streaming() callback fails. Lad, Prabhakar (2): staging: media: davinci: vpfe: use v4l2_fh for priority handling staging: media: dav

[PATCH 1/2] staging: media: davinci: vpfe: use v4l2_fh for priority handling

2014-03-22 Thread Lad, Prabhakar
From: "Lad, Prabhakar" Signed-off-by: Lad, Prabhakar --- .../staging/media/davinci_vpfe/vpfe_mc_capture.h |2 -- drivers/staging/media/davinci_vpfe/vpfe_video.c|8 +++- drivers/staging/media/davinci_vpfe/vpfe_video.h|2 -- 3 files changed, 3 insertions(+), 9

[PATCH 2/2] staging: media: davinci: vpfe: release buffers in case start_streaming call back fails

2014-03-22 Thread Lad, Prabhakar
From: "Lad, Prabhakar" this patch releases the buffer bu calling vb2_buffer_done(), with state marked as VB2_BUF_STATE_QUEUED if start_streaming() call back fails. Signed-off-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 10 +- 1 file changed, 9

[PATCH for v3.15] staging: media: davinci: vpfe: make sure all the buffers are released

2014-03-22 Thread Lad, Prabhakar
From: "Lad, Prabhakar" from commit-id: b3379c6201bb3555298cdbf0aa004af260f2a6a4 "vb2: only call start_streaming if sufficient buffers are queued" the vb2 framework warns on (WARN_ON()) if all the active buffers are not released when streaming is stopped, initially the vb2 s