On Fri, Aug 23, 2024 at 06:27:49PM +0100, Simon Horman wrote:
> On Fri, Aug 23, 2024 at 06:16:49PM +0100, Simon Horman wrote:
> > On Fri, Aug 23, 2024 at 08:35:15PM +0800, kernel test robot wrote:
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > > staging
On Tue, Jun 25, 2024 at 04:19:18PM +0100, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
>
> Fix for commit: 7dff0b27d9c842f88149bf611cbc0b59be1dcd3c:
> [34/59] staging: rtl89192e: Remove unnecessary pre-declaration of struct
On Tue, Jun 25, 2024 at 01:56:38PM +0100, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
>
> Signed-off-by: Teddy Engel
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202406250858.l8rjmh
On Thu, Jun 13, 2024 at 09:31:36AM +0300, Dan Carpenter wrote:
> On Thu, Jun 13, 2024 at 08:18:04AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2024 at 08:57:13AM +0300, Dan Carpenter wrote:
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/kernel
-...@intel.com/
>
> smatch warnings:
> drivers/usb/core/driver.c:80 store_id() error: uninitialized symbol
> 'usb_dynid'.
>
> vim +/usb_dynid +80 drivers/usb/core/driver.c
>
> be520b87ec28aa Greg Kroah-Hartman 2024-06-11 70 static int store_id(const
> s
aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same th
On Wed, Mar 29, 2023 at 07:27:04PM +0800, Kloudifold wrote:
> sm750 driver has sm750_hw_cursor_* functions, which are named in
> camelcase. Rename them to snake case to follow the function naming
> convention.
>
> - sm750_hw_cursor_setSize => sm750_hw_cursor_set_size
> - sm750_hw_cursor_setPos
On Mon, Mar 06, 2023 at 12:30:57AM +0530, Santosh Mahto wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Santosh Mahto
> ---
> drivers/staging/android/ashmem.c | 2 +-
What kernel did you make this against? This is not in my tree anymore.
thanks,
greg k-h
___
On Fri, Feb 10, 2023 at 11:38:45PM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-testing
> head: ecfd9f08fe2ef7616477c089dce1b0f05dcee13c
> commit: ecfd9f08fe2ef7616477c089dce1b0f05dcee13c [77/77] devtmpfs: remov
On Wed, Jan 04, 2023 at 06:35:39PM +, SeongJae Park wrote:
> Hello,
>
> On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot
> wrote:
>
> > [-- Attachment #1: Type: text/plain, Size: 7528 bytes --]
> >
> >
> > Greeting,
> >
> > FYI, we noticed kernel_BUG_at_lib/list_debug.c due to commit
On Sat, Jul 30, 2022 at 04:14:57PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: f3a76018dd55d8ddcd28cb47049f46ae5c0ce557
> commit: f3a76018dd55d8ddcd28cb47049f46ae5c0ce557 [54/54] staging: r8188eu:
> remov
n->event);
> 414985ae23c031e Tejun Heo 2013-11-28 161
> adc5e8b58f4886d Tejun Heo 2013-12-11 162 return
> of->kn->attr.ops->seq_show(sf, v);
> 414985ae23c031e Tejun Heo 2013-11-28 163 }
> 414985ae23c031e Tejun Heo 2013-11-28 164
>
> :: The code at
On Wed, Apr 06, 2022 at 10:06:33AM +0300, Kalle Valo wrote:
> Jakub Kicinski writes:
>
> > On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote:
> >> Sure, that would technically work. But I just think it's cleaner to use
> >> -rc1 (or later) as the baseline for an immutable branch. If the baselin
On Sat, Feb 26, 2022 at 12:41:41PM +0200, Kalle Valo wrote:
> + jakub
>
> Jerome Pouiller writes:
>
> > The firmware and the PDS files (= antenna configurations) are now a part of
> > the linux-firmware repository.
> >
> > All the issues have been fixed in staging tree. I think we are ready to g
On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote:
> On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote:
> > From: Riccardo Ferrazzo
> >
> > Some variants of the WF200 disallow active scan on channel 12 and 13.
> > For these parts, the channels 12 and 13 are marked IEEE80
On Thu, Feb 17, 2022 at 04:41:38PM +0100, Jérôme Pouiller wrote:
> On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote:
> > Ulf Hansson writes:
> > > On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote:
> > >> Jerome Pouiller writes:
> > >> > From: Jérôme Pouiller
> > >> >
> > >> > Until now,
On Fri, Feb 04, 2022 at 11:08:35AM -0800, Tong Zhang wrote:
> The gs_fpgaboot driver is totally broken since 2014 and no one even
> noticed the driver is not probing. Given the quality of the driver
> and its current state it makes sense to drop it.
>
> Signed-off-by: Tong Zhang
Thanks, now drop
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote:
> gs_fpgaboot is currently useless since the board specific code is
> removed in 06a3fab941da.
Nit, commits should be printed out like this:
06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100")
> Loading the driver w
;
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this
On Wed, Jan 12, 2022 at 12:43:32PM +0100, Pali Rohár wrote:
> Btw, is there any project which maintains SDIO ids, like there is
> pci-ids.ucw.cz for PCI or www.linux-usb.org/usb-ids.html for USB?
Both of those projects have nothing to do with the kernel drivers or
values at all, they are only for
On Fri, Dec 31, 2021 at 07:35:07PM +, Al Viro wrote:
> On Sat, Jan 01, 2022 at 01:08:41AM +0800, kernel test robot wrote:
> > tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> > debugfs_cleanup
> > head: a04bbe0a2c7e98669e11a47f94e53dd8228bbeba
> > commit:
From: Lee Jones
Supply additional checks in order to prevent unexpected results.
Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Suggested-by: Dan Carpenter
Signed-off-by: Lee Jones
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/android/ion/ion.c |6
From: Lee Jones
Supply additional checks in order to prevent unexpected results.
Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Suggested-by: Dan Carpenter
Signed-off-by: Lee Jones
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/android/ion/ion.c |6
On Fri, Dec 03, 2021 at 05:07:11AM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> hid_is_usb
> head: be29771805ee7d748ac02a0df3e1e10f5ead521f
> commit: be29771805ee7d748ac02a0df3e1e10f5ead521f [4/4] HID: add USB_HID
> depend
On Sat, Nov 27, 2021 at 11:24:12AM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-testing
> head: 7f67ea9c19735222f7999754f3fee922cd8f4781
> commit: 6a4e0b75cfa09e70c0aa39a03b478641cf2a7974 [5/7] test_firmware: ad
On Tue, Oct 05, 2021 at 10:17:32AM +0200, Jérôme Pouiller wrote:
> On Tuesday 5 October 2021 08:12:27 CEST Kalle Valo wrote:
> > Pali Rohár writes:
> > > On Friday 01 October 2021 17:17:52 Jérôme Pouiller wrote:
> > >> On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
> > >> > Jerome Pouill
On Tue, Oct 05, 2021 at 09:12:27AM +0300, Kalle Valo wrote:
> Pali Rohár writes:
>
> > On Friday 01 October 2021 17:17:52 Jérôme Pouiller wrote:
> >> On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
> >> > CAUTION: This email originated from outside of the organization.
> >> > Do not clic
On Tue, Aug 17, 2021 at 09:41:05PM -0700, daniel watson wrote:
> From: Daniel Watson
>
> Moved the opening curly brace to the end of the opening
> line of the phy_stat struct for style consistency.
>
> Signed-off-by: Daniel Watson
> ---
> drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 +
On Sun, Aug 15, 2021 at 03:27:04PM +1200, Barry Song wrote:
> On Sun, Aug 15, 2021 at 1:36 AM Greg Kroah-Hartman
> wrote:
> >
> > On Sat, Aug 14, 2021 at 07:03:00PM +0800, kernel test robot wrote:
> > > tree:
> > > https://git.kernel.org/pub/scm/lin
On Sat, Aug 14, 2021 at 07:03:00PM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-testing
> head: 3b35f2a6a625126c57475aa56b5357d8e80b404c
> commit: 291f93ca339f5b5e6e90ad037bb8271f0f618165 [28/31] lib: test_bitma
On Fri, Jul 23, 2021 at 04:27:50PM +0530, Benjamin Philip wrote:
> The following few patches remove some blank lines that before or after a
> brace.
>
> To test my changes, I have checked if it compiles (which it does). I also have
> checked the patch with checkpatch.pl, which does not pass any w
On Wed, Jul 21, 2021 at 04:28:09PM +0530, Benjamin Philip wrote:
> This commit fixes some checkpatch checks for blank lines before
> and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
>
> Signed-off-by: Benjamin Philip
> ---
>
> This patch fixes some checkpatch.pl CHECKs for blank lines
an
Reported-by: Konstantin Ryabitsev
Signed-off-by: Greg Kroah-Hartman
diff --git a/MAINTAINERS b/MAINTAINERS
index 72e5b9db5050..b02eec28ae2c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1181,7 +1181,7 @@ M:Joel Fernandes
M: Christian Brauner
M: Hridya Valsaraju
On Fri, Mar 12, 2021 at 09:26:05AM +0100, Marco Cesati wrote:
> This set of patches remove 153 useless typedef instructions in the
> staging/rtl8723bs source code, as identified by the checkpatch.pl
> script. Every patch is purely syntactical: it does not change the
> generated machine code. Furthe
On Tue, Mar 09, 2021 at 04:57:59PM +, Walter Harms wrote:
> why not mark it as "Deprecated" and remove it with the next version ? Maybe
> soneone will wakeup ?
We don't really have a "Deprecated" marking, we just delete them :)
thanks,
greg k-h
__
On Fri, Jan 22, 2021 at 06:01:13PM +0300, Dan Carpenter wrote:
> The "gasket_dev->num_page_tables" variable is an int but this is copying
> sizeof(u64). On 32 bit systems this would end up disclosing a kernel
> pointer to user space, but on 64 bit it copies zeroes from a struct
> hole.
>
> Fixes:
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
On Sun, Feb 21, 2021 at 09:35:44PM +0530, Shreesh Adiga wrote:
> The check for interface is duplicated in 3 places and has been refactored
> into a function.
>
> Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 18 +-
> 1 file
On Sun, Feb 21, 2021 at 08:25:05PM +0530, Shreesh Adiga wrote:
> The check for interface is duplicated in 3 places and has been refactored
> into a function. Also the if condition was wrapping the whole body in all
> three places, so it has been changed to return if the condition is false
> to redu
On Sun, Feb 21, 2021 at 07:34:57PM +0530, karthik alapati wrote:
> currently the functions defined in ibuf_ctrl_rmgr.c file are only
> used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
> so dont't compile it when not needed, also fixes some sparse warnings
>
> Signed-off-by: karthi
On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
>
> Signed-off-by: karthik alapati
> ---
> drivers/staging/wimax/i2400m/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Sun, Feb 21, 2021 at 11:12:36AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Missing a blank line after declarations
>
> in file ipu3-css-fw.h
>
> Signed-off-by: Nikolay Kyx
> ---
>
> Additionally some style warnings remain valid here and co
On Fri, Feb 19, 2021 at 07:07:54PM +0800, Du Cheng wrote:
> use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
> inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng
> ---
> drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
>
F8256_Config_ParaFile_Fail;
> }
> }
> @@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev,
> u8 powerlevel)
> }
> rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal);
> }
> - return;
>
On Sun, Feb 14, 2021 at 03:56:01PM +0530, Shreesh Adiga wrote:
> Cleanup warnings displayed by checkpatch.pl for the
> file rtl8171x_mlme.c for the below warning:
> WARNING: Avoid multiple line dereference
>
> Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
> ---
> drivers/staging/rtl8
On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote:
> convert le32 types to host byte-order types before
> comparison
That says what you did, but not _why_ you did it. Please fix up and
resend.
thanks,
greg k-h
___
devel mailing list
de..
> -static const chardriver_desc[] = DRIVER_DESC;
>
>
> /*===*/
> /* Prototype */
> --
> 2.29.2
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered thi
On Thu, Feb 18, 2021 at 05:58:41AM +0800, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> debugfs_remove_return_value
> head: 5187c2360ee1d023078e4302dad32fda1e895772
> commit: 72f2bf74b31aae983fb200aa7e84a05943bf27fc [2/8] debugfs:
On Wed, Feb 17, 2021 at 09:24:17AM -0500, Sean Behan wrote:
> When building with W=1, there is a warning that this variable is unused.
>
> It is not used so remove it to fix the warning.
>
> Thanks to nat...@kernel.org for helping me submit my first patch.
This is nice, but is it needed in the c
t; -static const chardriver_desc[] = DRIVER_DESC;
>
>
> /*===*/
> /* Prototype */
> --
> 2.29.2
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually
On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng
> ---
> changes v2:
> * relign backslashes with tabstop=8
> * im
On Tue, Feb 16, 2021 at 05:40:12PM +0800, Du Cheng wrote:
> align * in block comments on each line
That says _what_ you did, not _why_ you did it.
And "each line"? You only did this once.
> This series of patches is for Task 10 of the Eudyptula Challenge
This isn't a "series" of patches, it is
On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote:
> align * in block comments on each line
>
> changes v3:
> - add SUBSYSTEM in subject line
> - add explanation to past version of this patch
>
> changes v2:
> - move closing of comment to the same line
>
> changes v1:
> - align * in block
E_54M ((u8)(540 / 5))
>
> static inline bool is_11b_rate(u8 rate)
> {
> --
> 2.30.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to
On Sat, Feb 13, 2021 at 11:31:36PM -0300, Thais Camacho wrote:
> Warning found by checkpatch.pl script
>
> Signed-off-by: Thais Camacho
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers
_is_locked(&wdev->hif_cmd.lock) &&
> + wdev->hif_cmd.buf_send &&
> + wdev->hif_cmd.buf_send->id == hif_id) {
> hif_generic_confirm(wdev, hif, hif->body);
> goto free;
> }
> --
> 2.30.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman.
On Thu, Feb 11, 2021 at 12:40:15AM +0530, karthik alapati wrote:
> fix checkpatch.pl warning for "block comments should align the
> * on each line" and make function comments follow kernel-doc
>
> Signed-off-by: karthik alapati
> ---
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
On Thu, Feb 11, 2021 at 12:48:16AM +0530, karthek wrote:
> check this out
Why ask us again when you already sent a patch? Do you see any other
developers doing that on the mailing lists?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject
On Thu, Feb 11, 2021 at 12:16:45PM +0530, Aakash Hemadri wrote:
> On 21/02/10 06:50PM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> > > Replace camel case variable names with snake case in baseband.c.
> > >
>
On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> Replace camel case variable names with snake case in baseband.c.
>
> Signed-off-by: Yujia Qiao
> ---
> drivers/staging/vt6655/baseband.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This doesn't apply cleanly to my sta
direction,
> - unsigned long flags)
> +static struct dma_async_tx_descriptor
> + *gdma_dma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr,
> + size_t buf_len, size_t period_len,
> + enum dma_transfer_direction direction,
> +
On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote:
> fix checkpatch.pl warning for "block comments should align the * on each line"
>
> Signed-off-by: karthik alapati
> ---
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +-
> 1 file changed, 102 insertions(+)
On Tue, Feb 09, 2021 at 02:39:41PM +0100, Hans Verkuil wrote:
> On 09/02/2021 14:02, Greg Kroah-Hartman wrote:
> > On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote:
> >>
> >>
> >> Am 08.02.21 um 21:46 schrieb Hans Verkuil:
> >>> On
On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote:
>
>
> Am 08.02.21 um 21:46 schrieb Hans Verkuil:
> > On 08/02/2021 18:57, Sasha Levin wrote:
> > > From: Dafna Hirschfeld
> > >
> > > [ Upstream commit 31f190e0ccac8b75d33fdc95a797c526cf9b149e ]
> > >
> > > Each entry in the arr
723B(
> struct adapter *Adapter,
> u8 eRFPath,
> @@ -369,17 +369,17 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter)
> }
>
> /**
> -* Function: phy_InitBBRFRegisterDefinition
> -*
> -* OverView: Initialize Register definition offset for Radio Path A/B/C/D
> -*
> -* Input:
> -*
> + dev_err(&pdev->dev, "failed to reset device\n");
> + return ret;
> + }
>
> dd = &dma_dev->ddev;
> dma_cap_set(DMA_MEMCPY, dd->cap_mask);
> --
> 2.1.0
>
Hi,
This is the friendly patch-bot of Greg
On Tue, Feb 02, 2021 at 11:31:17AM +0300, Dan Carpenter wrote:
> Apparently this was already merged? Never mind then. Once it's merged
> it can't be changed. No big stress...
Sorry, yes, already in my tree...
___
devel mailing list
de...@linuxdriverpr
On Fri, Jan 29, 2021 at 08:51:46PM +0100, Mauro Carvalho Chehab wrote:
> Hi Greg/Mark/Lee/Vinod,
>
> Another rebase , also the top of staging-testing.
>
> This series contain the remaining patches for USB to start working,
> except for a final DTS patch.
>
> Patches 1 and 2 convert the SPMI and
On Wed, Jan 06, 2021 at 01:08:15PM +0100, Johan Hovold wrote:
> On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote:
> > On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote:
> > > The correct user/kernel api for vibrator devices is the Input rumble
>
On Fri, Jan 29, 2021 at 04:03:36PM +0100, Mauro Carvalho Chehab wrote:
> Instead of doing its own SPMI I/O implementation, use the
> already-existing regmap one.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++
> .../staging
On Fri, Jan 29, 2021 at 12:23:08PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > On Thu, 28 Jan 2021 16:33:02 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> > >
> > > Thanks for your contribution, my comments below.
> >
On Fri, Jan 29, 2021 at 02:38:33PM +0530, Kumar Kartikeya Dwivedi wrote:
> On 0129, Greg Kroah-Hartman wrote:
> > On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote:
> > > [Forgot to reply-all]
> > >
> > > On 0129, Greg Kroah-Hartman wrote
On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote:
> [Forgot to reply-all]
>
> On 0129, Greg Kroah-Hartman wrote:
> > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> > > Fixes checkpatch warnings for usage of strlcpy.
>
On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote:
> Fixes checkpatch warnings for usage of strlcpy.
What warning would that be?
And if we could just search/replace for this, why hasn't that already
happened for the whole tree?
thanks,
greg k-h
On Wed, Jan 27, 2021 at 12:04:26PM +, Mark Brown wrote:
> On Wed, Jan 27, 2021 at 09:57:40AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 26, 2021 at 06:11:24PM +, Mark Brown wrote:
>
> > > > Do you need a tag to pull from?
>
> > > It'd be
On Sat, Jan 09, 2021 at 06:57:31PM +0530, B K Karthik wrote:
> In gbaudio_remove_controls() , replace the usage of strlcpy() with
> strscpy() because strlcpy() only limits the *destination*
> size, and the source is always read fully.
>
> https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uT
On Wed, Jan 27, 2021 at 10:08:16AM +, Lee Jones wrote:
> On Wed, 27 Jan 2021, Greg Kroah-Hartman wrote:
>
> > On Tue, Jan 26, 2021 at 06:11:24PM +, Mark Brown wrote:
> > > On Tue, Jan 26, 2021 at 07:02:39PM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue,
On Tue, Jan 26, 2021 at 06:11:24PM +, Mark Brown wrote:
> On Tue, Jan 26, 2021 at 07:02:39PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 26, 2021 at 05:57:52PM +, Mark Brown wrote:
>
> > > Is there a branch we can pull from?
>
> > Once 0-day passes
On Tue, Jan 26, 2021 at 05:57:52PM +, Mark Brown wrote:
> On Tue, Jan 26, 2021 at 06:54:57PM +0100, Greg Kroah-Hartman wrote:
>
> > I've applied the first 13 patches, except for patch 3, as that did not
> > apply, to my tree, thanks.
>
> Is there a branch we can
On Thu, Jan 21, 2021 at 08:18:02AM +0100, Mauro Carvalho Chehab wrote:
> Hi Mark/Lee,
>
> This patch series finish addressing support for Hikey 970
> SPMI controller, PMIC and regulators.
>
> This version was generated with -M, in order to make easier
> to merge upstream. Also, rebased on the to
On Tue, Jan 19, 2021 at 11:44:38AM +0100, Mauro Carvalho Chehab wrote:
> Hi Vinod/Rob,
>
> This series moves the Hikey 970 USB PHY driver out of staging.
>
> Patches 1 to 4 contain the fixes from staging. Patch 5 moves the
> driver from staging:
>
> $ git show 82ce73ac9a38 --summary
>
through my tree, I
> can take it as well.
Please feel free to take it through yours, as I don't think I'll have
any more staging patches for 5.11-final (or none have been sent to me
yet), so this might be the fastest way in:
Acked-by: Greg Kroah-Hartman
On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
>
>
> On 06-Jan-21 09:51, Greg Kroah-Hartman wrote:
> > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> > > There is a debug message using hardcoded function name instead of the
> >
ed Android
> kernel config.
>
> Fixes: e722a295cf49 ("staging: ion: remove from the tree")
> Cc: Greg Kroah-Hartman
> Cc: Hridya Valsaraju
> Cc: Rob Herring
> Cc: linux-me...@vger.kernel.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Matthias M
On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> There is a debug message using hardcoded function name instead of the
> __func__ macro. Replace it.
>
> Report from checkpatch.pl on the file:
>
> WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this
> function's
No need for a custom sysfs api for the greybus vibrator driver now that
it is hooked up to the kernel's input layer, so rip it out.
Cc: Johan Hovold
Cc: Alex Elder
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/greybus/vibrator.c | 125 ++---
1 file chang
Elder
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/greybus/vibrator.c | 59 ++
1 file changed, 59 insertions(+)
diff --git a/drivers/staging/greybus/vibrator.c
b/drivers/staging/greybus/vibrator.c
index 0e2b188e5ca3..94110cadb5bd 100644
--- a/drivers/staging
On Sat, Dec 26, 2020 at 04:02:56PM +0800, Dinghao Liu wrote:
> There is an allocation for priv->rx_urb[16] has no null check,
> which may lead to a null pointer dereference.
>
> Signed-off-by: Dinghao Liu
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: jovin555
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers/staging/
On Sun, Dec 27, 2020 at 04:56:45PM +0530, Angshuman Sengupta wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Angshuman Sengupta
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
On Wed, Dec 23, 2020 at 09:01:33AM +0100, Jérôme Pouiller wrote:
> On Tuesday 22 December 2020 16:27:01 CET Greg Kroah-Hartman wrote:
> > On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > >
On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > +/*
> > + * Internal helpers.
> > + *
> > + * About CONFIG_VMAP_STACK:
> > + * When CONFIG_VMAP_STACK is enabled, it is not possible to run DMA on
> > stack
> > + * allocated data. Functions below that wo
On Thu, Dec 10, 2020 at 12:20:10PM +, József Horváth wrote:
> I send this again, because my original mail content was corrupted.
>
> This is a serial port driver for
> Silicon Labs Si4455 Sub-GHz transciver.
>
> Signed-off-by: József Horváth
> ---
> .../bindings/staging/serial/silabs,si4455
On Thu, Dec 10, 2020 at 12:20:59PM +, József Horváth wrote:
> fix: coding style
> fix: error checking
> remove: doc silabs,si4455.txt
What does all of this mean?
Please read the documentation for how to write an effective changelog
text, and where to put the "changes from the first version" t
On Wed, Dec 09, 2020 at 12:09:58PM +0100, Info wrote:
> This is a serial port driver for
> Silicon Labs Si4455 Sub-GHz transciver.
>
> Signed-off-by: József Horváth
Note, your From: line does not match this line, so I can't take this.
But:
> ---
> .../bindings/staging/serial/silabs,si4455.txt
On Thu, Oct 29, 2020 at 09:52:16AM -0400, Brian O'Keefe wrote:
> Add 024c:0627 to the list of SDIO device-ids, based on hardware found in
> the wild. This hardware exists on at least some Acer SW1-011 tablets.
>
> Signed-off-by: Brian O'Keefe
> Reviewed-by: Hans de Goede
> ---
> drivers/staging
On Wed, Nov 04, 2020 at 10:49:18AM +, Ian Abbott wrote:
> On 02/11/2020 11:16, Ian Abbott wrote:
> > On 02/11/2020 10:25, Ian Abbott wrote:
> > > On 29/10/2020 14:18, Ian Abbott wrote:
> > > > Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor
> > > > write_calibration_bitstream()") ina
take through the staging tree? If so, I need an
ack from the networking maintainers.
If not, feel free to send it through the networking tree and add:
Acked-by: Greg Kroah-Hartman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Oct 26, 2020 at 05:11:11PM +0100, Jérôme Pouiller wrote:
> On Monday 26 October 2020 17:02:22 CET Arnd Bergmann wrote:
> >
> > From: Arnd Bergmann
> >
> > Move the added check of the 'band' variable after the
> > initialization. Pointed out by clang with
> >
> > drivers/staging/wfx/data
1 - 100 of 2620 matches
Mail list logo
