On 06/22, zack.chang wrote:
Nice, however there is to little information in the commit message of
wha exactly has been fixed. I assume it is 'line over 80 chars', right?
and this information shoule be wrien there.
thanks
- konrad
> Signed-off-by: zack.chang
> ---
> drivers/staging/android/i
On 06/12, Dean.lee wrote:
>
>
> On 2015년 06월 12일 18:17, Konrad Zapalowicz wrote:
> >On 06/12, Dean Lee wrote:
> >>remove OS Wrapper & Type files.
> >>now does not used os wrapper file.
> >>type file is included os wrapper file.
> >>
On 06/12, Juston Li wrote:
> fixed all checkpatch.pl ERROR: do not use C99 // comments
>
> Any C99 comments used to comment out code are simply removed.
> Also some of the errors occur inside '#if 0' blocks which I
> might as well fix since checkpatch.pl caught them but the blocks
> themselves sho
On 06/12, Dean Lee wrote:
> remove OS Wrapper & Type files.
> now does not used os wrapper file.
> type file is included os wrapper file.
> so delete files and rework include method.
I do not understand the commit message and it does not parse well.
- konrad
>
> Signed-off-by: Dean Lee
> ---
On 06/02, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
> > On 06/02, Sudip Mukherjee wrote:
> > > size_t should print using %zu, but here it was using %d and hence we
> > > were getting warning while printing.
> &
On 06/02, Sudip Mukherjee wrote:
> size_t should print using %zu, but here it was using %d and hence we
> were getting warning while printing.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> I think it will be easy to remove the other warnings if all the typedefs
> are removed first.
>
> drivers/
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango
The above line should not be here and it will appear as long as the
email client is not configured correctly. Just take a step back and
fix it as this is something that you do once and then it remains
*correct*
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango
>
> Remove braces around else clause with single line
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/xgifb/vb_init.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
On 01/11, Pavel Machek wrote:
> On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote:
> > On 01/11, atull wrote:
> > > On Sat, 10 Jan 2015, Konrad Zapalowicz wrote:
> > >
> > > > On 01/06, at...@opensource.altera.com wrote:
> > > > > From: Alan
On 01/11, atull wrote:
> On Sat, 10 Jan 2015, Konrad Zapalowicz wrote:
>
> > On 01/06, at...@opensource.altera.com wrote:
> > > From: Alan Tull
> >
> > Alan, there is something wrong with your email client configuration
> > and you need to fix.
>
On 01/06, at...@opensource.altera.com wrote:
> From: Alan Tull
Alan, there is something wrong with your email client configuration
and you need to fix.
thanks,
konrad
> v8 changes the compatible string for SOCFPGA FPGA managers
> to be more chip specific.
>
> "altr,fpga-mgr" becomes "altr,soc
On 01/06, Sudip Mukherjee wrote:
> On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote:
> > On 06/01/15 06:02, Sudip Mukherjee wrote:
> > >On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> > >>On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zap
On 01/04, Piotr Kubus wrote:
> This is a patch to the dmm32at.c file that fixes up a code indent error found
> by the checkpatch.pl tool.
Nice however improve your commit message. The rule is that the lines
should wrap at 72nd column except for quoted material such as compiler
output, etc...
The
On 01/03, Paul Bolle wrote:
> On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote:
> > On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote:
> > > *** BLURB HERE ***
> >
> > What blurb? What subject?
>
> jitendra used git-send-email to send this series. You'd expect
> git-send-ema
On 12/31, Lorenzo Stoakes wrote:
> On 31 December 2014 at 19:00, Konrad Zapalowicz
> wrote:
> >
> > You also fix the line length here which shall be the subject of a
> > separate patch as this is not C99 comments related change.
> >
>
> Apologies - I miss
On 12/31, Lorenzo Stoakes wrote:
> This patch fixes errors raised by checkpatch.pl relating to use of C99
> comments
> in r8192U_dm.c.
>
> Signed-off-by: Lorenzo Stoakes
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 841
> ++-
> 1 file changed, 432 insertions(+
On 12/31, Serguey Parkhomovsky wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning:
> symbol 'libcfs_arch_init' was not declared. Should it be static?
> drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning:
>
On 12/26, Damon Swayn wrote:
> Fixed a coding style issue
You need to be more specific here, describe what kind of issue this
patch is fixing. Keep in mind that this message, when formulated
properly, will end up as a comment to the Linux kernel source - it must,
therefore, contain valuable inform
On 11/30, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl warnings:
Your subject line is somewhat broken as it does not really follow the
canonical patch format. You can read up on it here (section 15)
https://www.kernel.org/doc/Documentation/SubmittingPatches and this is
the short ve
On 11/15, Pavel Machek wrote:
> On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > On 11/15, Christian Resell wrote:
> > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > For the eudyptula challenge (http://eudyptul
On 11/15, Christian Resell wrote:
> Simple style fix (checkpatch.pl: "space prohibited before that ','").
> For the eudyptula challenge (http://eudyptula-challenge.org/).
Nice, however we do not need the information about the 'eudyptula
challenge' in the commit message.
If you want to include ext
On 11/06, Greg KH wrote:
> On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
> > This commit removes the staging/dgnc driver in favor of the serial/jsm
> > driver.
> >
> > This is because the serial/jsm driver now supports all of the hardware
> &g
On 11/06, Greg KH wrote:
> On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote:
> > This commit adds the Digi Classic board implementation to the
> > staging/jsm driver.
> >
> > The code here is taken from the staging/dgnc driver and modified to
> >
inspiration coming from the diff between staging/dgnc and serial/jsm
as well as the LKML history for the jsm_neo.c
The code compiles now and has no sparse and checkpatch errors or
warnings.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/Makefile | 2 +-
drivers/tty/serial/jsm/jsm.h
This commit removes the address of Free Software Foundation from each
of the mentioned file in order to suppress the checkpatch warning.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/jsm.h| 5 -
drivers/tty/serial/jsm/jsm_cls.c| 5 -
drivers/tty/serial/jsm
This commit enables support for the Digi Classic adapters line in the
jsm driver. This means changes in:
- device probing code
- device cleanup code
- driver description (Kconfig)
The init/cleanup code is based on the staging/dgnc driver.
Signed-off-by: Konrad Zapalowicz
the series.
since Greg has already merged the patch 01 from the first series
this time it is not attached therefore this series has only 4
patches in it (previously was 5).
Konrad Zapalowicz (4):
drivers: serial: jsm: Add the Classic
This commit enables support for the Digi Classic adapters line in the
jsm driver. This means changes in:
- device probing code
- device cleanup code
- driver description (Kconfig)
The init/cleanup code is based on the staging/dgnc driver.
Signed-off-by: Konrad Zapalowicz
inspiration coming from the diff between staging/dgnc and serial/jsm
as well as the LKML history for the jsm_neo.c
The code compiles now and has no sparse and checkpatch errors or
warnings.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/Makefile | 2 +-
drivers/tty/serial/jsm/jsm.h
This commit adds the UART structure for the Digi Classic cards. This
code comes from the staging/dgnc driver.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/jsm.h | 59 +++-
1 file changed, 58 insertions(+), 1 deletion(-)
diff --git a
This commit enables support for the Digi Classic adapters line in the
jsm driver. This means changes in:
- device probing code
- device cleanup code
- driver description (Kconfig)
The init/cleanup code is based on the staging/dgnc driver.
Signed-off-by: Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each
of the mentioned file in order to suppress the checkpatch warning.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/jsm.h| 5 -
drivers/tty/serial/jsm/jsm_cls.c| 5 -
drivers/tty/serial/jsm
inspiration coming from the diff between staging/dgnc and serial/jsm
as well as the LKML history for the jsm_neo.c
The code compiles now and has no sparse and checkpatch errors or
warnings.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/Makefile | 2 +-
drivers/tty/serial/jsm/jsm.h
it is
highly recommended that someone tests it.
Konrad Zapalowicz (5):
drivers: serial: jsm: Add Classic board UART structure
drivers: serial: jsm: Add the Classic board implementation
drivers: serial: jsm: Enable support for Digi Classic adapters
staging: dgnc: Remove driver in favor of
This commit adds the UART structure for the Digi Classic cards. This
code comes from the staging/dgnc driver.
Signed-off-by: Konrad Zapalowicz
---
drivers/tty/serial/jsm/jsm.h | 59 +++-
1 file changed, 58 insertions(+), 1 deletion(-)
diff --git a
On 11/01, Aya Mahfouz wrote:
> This patch removes one debug message and replaces a dev_err
> call by pr_err.
Usually you would like to send this as two separate patches because
replacing a debug message is way different than removing some code. It
should look like:
PATCH 0/2 staging: medi
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
>
> Signed-off-by: Mariusz Gorski
> ---
> v3: Fixed commit summary
Great. Thanks.
regards,
konrad
> drivers/staging/panel/TODO | 2 --
> 1
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
>
> v2: Fixed commit summary
This is something that should not be a part of the commit message. This
kind of extra information shall be placed
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
Great however your topic is ill formated. It should contain the "staging:
panel:" prefix.
thanks,
konrad
>
> Signed-off-by: Mariusz Gorski
>
On 10/19, Chen Weixiang wrote:
> Remove code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Chen Weixiang
> ---
> drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +-
> 1 file changed, 9 insertions(+), 9
On 09/08, Bill Pemberton wrote:
> On 09/08/2014 04:17 PM, Greg KH wrote:
> >On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote:
> >>From: Bill Pemberton
> >>
> >>The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
> >>cards that dgnc (staging) supports. In fac
On 09/02, Greg KH wrote:
> On Tue, Sep 02, 2014 at 07:55:49PM +0200, Konrad Zapalowicz wrote:
> > On 09/02, Greg KH wrote:
> > > On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote:
> > > > This commit adds the struct list_head to the struct dgnc_b
On 09/02, Greg KH wrote:
> On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote:
> > This commit adds the struct list_head to the struct dgnc_board so that
> > it is now possible to use it with the Linux list facility.
> >
> > Signed-off-by: Konrad Zapal
than one or two boards the
gain here is smaller amount of memory (stack) being used by the driver.
Signed-off-by: Konrad Zapalowicz
---
Changelog:
v2:
- merge previous two patches on this subject into this one
- use list_for_each_entry where it makes sense
- remove the
On 09/01, Dan Carpenter wrote:
> On Sun, Aug 31, 2014 at 11:23:58PM +0200, Konrad Zapalowicz wrote:
> > Each registered board is asigned a data structure to keep it's state.
> > So far this was implemented using the static array of fixed-size. This
> > commit cha
These patches replace the fixed-size, static array used to keep track
of board structures with dynamic solution based on the list. I marked
this series as RFC since I need input on if this can be done better.
Konrad Zapalowicz (2):
staging: dgnc: Make the struct dgnc_board possible to use list
Each registered board is asigned a data structure to keep it's state.
So far this was implemented using the static array of fixed-size. This
commit changes the implementation by replacing the array with dynamic
solution based on the kernel list.
Signed-off-by: Konrad Zapalowicz
---
dr
This commit adds the struct list_head to the struct dgnc_board so that
it is now possible to use it with the Linux list facility.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b
From: Konrad Zapalowicz
This commit changes the memory allocation flags to ATOMIC in order to
avoid sleeping in the nowait/nolock code.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc
On 08/25, Dan Carpenter wrote:
> Hello Konrad Zapalowicz,
>
> The patch ea6e9dea2e72: "staging: dgnc: Fix frame size is larger than
> 1024B" from Aug 6, 2014, leads to the following static checker
> warning:
>
> drivers/staging/dgnc/dgnc_tty.c:479 dgnc_snif
,class}_destroy and unregister_chrdev functions may
be called with 'invalid' data perfectly fine. This means that this
variable is not needed and can safely be removed which is what this
commit does.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_dri
The dgnc_driver_start variable purpose was to indicate if the driver
'start' routine has been called. Now, because the 'start' routine can
only be called once this variable is not needed thus this commit
removes it.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dg
The polling counter variable is only exposed via sysfs and has no other
purpose.
Now, since the polling shall be implemented as a board specific feature
rather than being global in the driver this counter is obsolete.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 3
This commit removes the driver's global state variable. This is ok
because the state was changed only once at the end of init phase thus
the future usage of this variable is pointless.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 19 ---
dr
This is the fist stage of removal of unnecessary static, global
variables of this driver.
Konrad Zapalowicz (4):
staging: dgnc: Remove driver-wide state variable
staging: dgnc: Remove driver-wide polling counter variable
staging: dgnc: Remove not needed dgnc_driver_start variable
staging
On 08/15, Greg KH wrote:
> On Thu, Aug 14, 2014 at 05:53:10PM -0700, Aaron Brice wrote:
> > Bring braces in line with CodingStyle
> >
> > Signed-off-by: Aaron Brice
> > ---
> > Applies to next-20140814
> >
> > drivers/staging/dgnc/dgnc_neo.c | 10 --
> > drivers/staging/dgnc/dgnc_sysf
be put first.
Signed-off-by: Konrad Zapalowicz
---
v2:
- remove the __exit annotation for the cleanup function as it caused
the test-bot unhappy.
drivers/staging/dgnc/dgnc_driver.c | 84 ++
1 file changed, 39 insertions(+), 45 deletions(-)
diff
On 08/11, Greg KH wrote:
> On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote:
> > On 08/10, Greg KH wrote:
> > > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote:
> > > > This commit binds global variables of dgnc driver in a s
On 08/10, Greg KH wrote:
> On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote:
> > This commit binds global variables of dgnc driver in a structure so
> > that it is logically consistent. The structure is accessed via getter
> > function and as a result the ex
This commit binds global variables of dgnc driver in a structure so
that it is logically consistent. The structure is accessed via getter
function and as a result the externing of globals is removed. The names
of the variables are also changed to be more eye friendly.
Signed-off-by: Konrad
On 08/06, Dan Carpenter wrote:
> On Wed, Aug 06, 2014 at 09:01:24PM +0200, Konrad Zapalowicz wrote:
> > @@ -1935,8 +1935,8 @@ static void neo_vpd(struct dgnc_board *brd)
> >
> > if (((brd->vpd[0x08] != 0x82) /* long resource name tag */
> >
This commit fixes the checkpath warning 'void function return
statements are not generally useful' caused by the 'return' at the end
of 'void' function.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_cls.c | 2 --
1 file changed, 2 deletions(-)
dif
This commit fixes the missing blank lines after declarations checkpath
warnings found in dgnc_cls.c file.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_cls.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc
This series of patches fixes the checkpatch issues found in dgnc_cls.c
file:
- missing blank line after declaration
- void function return statements are not generally useful
Konrad Zapalowicz (2):
staging: dgnc: Fix missing blank line after declarations
staging: dgnc: Remove
This commit fixes the following checkpath error in dgnc_neo.c file:
'that open brace { should be on the previous line'
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_neo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dg
This commit fixes the checkpath warning about misused 'volatile'
modifier. In this case the 'volatile' was not needed as it was used
for regular automatic variable. Thos commit removes the 'volatile'.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_n
This commit fixes the following checkpath warning in dgnc_neo.c file:
'braces {} are not necessary for single statement blocks'
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_neo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/st
This commit deals with the checkapth warnings 'missing line after
declarations' in the dgnc_neo.c file.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_neo.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/st
This commit fixes the checkpatch warning:
drivers/staging/dgnc/dgnc_neo.c:37:
WARNING: Use #include instead of
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_neo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b
This series of patches deals with the checkpatch error and warnings,
other than 'line length over 80 chars', found in dgnc_neo.c file. All
except of patch 5/5 do not change the behavior.
Konrad Zapalowicz (5):
staging: dgnc: Fix included header from 'asm'
staging: dgnc: Fi
This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 91 ++
1 file changed, 44
This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 93 +++---
1 file changed, 46
This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 93 +++---
1 file changed, 46
It turned out that the TODO file contained the invalid information as
some of the work has already been done. This commit updates it with the
current status of what is left to be done.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/TODO | 5 -
1 file changed, 5 deletions(-)
diff
This commit slightly cleans up the dgnc_driver.c file. The changes
include removing one-line proxy functions as they were not needed.
Additionaly the pci 'remove' function is deleted because it was no
need for it.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_dri
This commit moves the utility functions out of dgnc_driver.c file and
puts them in the new dgnc_utils.{c,h} files. The accompanying changes
adjust the existing code to work with this design.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/Makefile | 3 +-
drivers/staging/dgnc
-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_tty.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index c712b43..2dc78f7 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers
(except on
line over 80 chars warnings).
Because the TODO file for this driver was not valid the bullet list in
it has been updated with the current status. The update is based on
what I have found in the driver devel mailing list archives for this
driver.
Konrad Zapalowicz (7):
staging: dgnc: Fix
This commit corrects the 'no space before tabs' checkpath warning.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driv
be put first.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/dgnc/dgnc_driver.c | 84 ++
1 file changed, 39 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index 764613b..1789cf3
On 07/15, Kevin Folz wrote:
> Hello,
>
>
>
> I noticed you two have worked on the staging rtl8821ae driver.
>
>
>
> I wrote to the mailing list last month, but have yet to receive a
> response.
>
> http://permalink.gmane.org/gmane.linux.kernel.wireless.general/125235
>
>
>
>
> I downl
code is ENOMEM. Luckily, this is
no issue.
Signed-off-by: Konrad Zapalowicz
---
v2:
- fix after the review:
- remove unnecessary comments
- remove unnecessary assignment
- fix pointer arithmetic
drivers/staging/vt6655/iwctl.c | 72 --
1 f
code is ENOMEM. Luckily, this is
no issue.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/vt6655/iwctl.c | 79 +-
1 file changed, 55 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
index e
halbtc_fill_h2c_cmd
halbtc_display_dbg_msg
halbtc_under_ips
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 93 +++---
1 file changed, 48 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c
b/drive
This commit fixes the sparse warning:
"warning: symbol 'X' was not declared. Should it be static?"
Where the X is one of the following
rtl_btc_operation
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/btcoexist/rtl_btc.c | 2 +-
1 file change
This commit fixes the compiler -Wunused-function warning. Several
functions had to be removed.
Removed symbols
halbtc_is_hw_mailbox_exist
halbtc_set_macreg
halbtc_get_macreg
halbtc_under_ips
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/btcoexist
mbols
halbtc8723b2ant_monitor_bt_enable_disable
halbtc8723b2ant_set_bt_auto_report
halbtc8723b2ant_bt_auto_report
Disabled symbols
halbtc8723b2ant_adc_backoff
halbtc8723b2ant_set_adc_backoff
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/btcoexist/halbtc8723b2
2ant_action_hid_a2dp
halbtc8723b2ant_run_coexist_mechanism
halbtc8723b2ant_wifioff_hwcfg
Signed-off-by: Konrad Zapalowicz
---
.../staging/rtl8821ae/btcoexist/halbtc8723b1ant.c | 203 +++--
1 file changed, 109 insertions(+), 94 deletions(-)
diff --git a/drivers/staging
This commit fixes the sparse warnings and compiler warnings in
drivers/staging/rtl8821ae/btcoexist module of rtl8821ae driver.
The most of the changes adds 'static' for local symbols plus
the -Wunused-function compiler warnings are fixed too.
Konrad Zapalowicz (7):
staging: rtl8
2ant_action_hid_a2dp
halbtc8723b2ant_run_coexist_mechanism
halbtc8723b2ant_wifioff_hwcfg
Signed-off-by: Konrad Zapalowicz
---
.../staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 141 +++--
1 file changed, 75 insertions(+), 66 deletions(-)
diff --git a/drivers/staging
Conditionally compiled symbols:
halbtc8723b1ant_bt_auto_report
halbtc8723b1ant_set_bt_auto_report
halbtc8723b1ant_action_wifi_only
halbtc8723b1ant_monitor_bt_enable_disable
Signed-off-by: Konrad Zapalowicz
---
.../staging/rtl8821ae/btcoexist/halbtc8723b1ant.c | 235 +
1
was not declared.
Should it be static?
All of this symbols are local, that is there are no references to them
in the other files from this driver.
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/rtl8821ae/sw.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
This commit fixes the following sparse warning:
drivers/staging/rtl8821ae/rtl8821ae/sw.c:
- 449:14: warning: duplicate const
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8821ae/rtl8821ae/sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
This patch set fixes sparse warnings in sw.c file of rtl8821ae driver.
In particular it deals with:
1) double const definition
2) missing 'static' for a few local symbols
Konrad Zapalowicz (2):
staging: rtl8821ae: fix double const in sw.c
staging: rtl8821ae: fix not declar
This commit fixes the following sparse warning:
drivers/staging/rtl8723au/os_dep/os_intfs.c:
- 322:14: warning: restricted __be16 degrades to integer
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This commit fixes the following checkpatch errors:
rtl8188eu/core/rtw_recv.c
- 1874: ERROR: code indent should use tabs where possible
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
This commit fixes the following checkpatch errors:
rtl8188eu/core/rtw_p2p.c
- 1508: ERROR: code indent should use tabs where possible
- 1509: ERROR: code indent should use tabs where possible
- 1510: ERROR: code indent should use tabs where possible
Signed-off-by: Konrad Zapalowicz
This patch removes the following checkpatch errors:
rtl8188eu/core/rtw_p2p.c:
- 1508: ERROR: code indent should use tabs where possible
- 1509: ERROR: code indent should use tabs where possible
- 1510: ERROR: code indent should use tabs where possible
rtl8188eu/core/rtw_recv.c
- 18
From: Konrad M Zapalowicz
This commit fixes the following checkpatch errors:
rtl8188eu/core/rtw_recv.c
- 1874: ERROR: code indent should use tabs where possible
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Konrad M Zapalowicz
This patch removes the following checkpatch errors:
rtl8188eu/core/rtw_p2p.c:
- 1508: ERROR: code indent should use tabs where possible
- 1509: ERROR: code indent should use tabs where possible
- 1510: ERROR: code indent should use tabs where possible
rtl818
1 - 100 of 101 matches
Mail list logo
