Re: [PATCH] staging: unisys: add visorclientbus driver

2014-11-06 Thread Ken Cox
On 11/06/2014 01:05 PM, Greg KH wrote: On Thu, Nov 06, 2014 at 12:53:32PM -0600, Ken Cox wrote: From: Benjamin Romer This patch adds the visorclientbus driver to the Unisys s-Par driver set. This driver is responsible for helping manage virtual devices like keyboards, mice, serial ports

[PATCH] staging: unisys: add visorclientbus driver

2014-11-06 Thread Ken Cox
-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 1 + drivers/staging/unisys/Makefile| 1 + drivers/staging/unisys/visorclientbus/Kconfig | 9 + drivers/staging/unisys/visorclientbus/Makefile | 13 + .../unisys/visorclientbus

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
hose taken care of. -- Ken Cox ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
On 09/15/2014 11:04 AM, Greg KH wrote: On Mon, Sep 15, 2014 at 10:56:07AM -0500, Ken Cox wrote: Greg and other reviewers, Ben Romer and I believe that the Unisys drivers in staging-next are now complete. Are there any other changes that you are aware of that we need to make to these drivers

Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
. Thanks in advance for your comments, -- Ken Cox ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: linux-next: Tree for Jul 3 (staging/unisys)

2014-07-03 Thread Ken Cox
On 07/03/2014 10:32 AM, Randy Dunlap wrote: On 07/02/14 22:53, Stephen Rothwell wrote: Hi all, Changes since 20140702: on x86_64: CONFIG_UNISYSSPAR=y CONFIG_UNISYS_VISORUTIL=m # CONFIG_UNISYS_VISORCHANNEL is not set CONFIG_UNISYS_CHANNELSTUB=y drivers/built-in.o: In function `channel_mod_in

[PATCH 4/4] Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

2014-07-03 Thread Ken Cox
vbuschannel_devinfo_to_string() was declared with the devinfo argument as a pointer to __iomem space. No callers of this function need the __iomem space, so I removed that constraint. Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to operate on I/O space. Signed-off-by

[PATCH 3/4] Staging: unisys: Remove ultra_vbus_init_channel function

2014-07-03 Thread Ken Cox
The function ultra_vbus_init_channel() is never called since previous server code was removed. Remove the dead code. Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 36 -- 1 file changed, 36 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 2/4] Staging: unisys: Remove isServer arg from init_vbus_channel()

2014-07-03 Thread Ken Cox
The init_vbus_channel() function is never called with the isServer argument equal to TRUE, so just get rid of the argument altogether. This also means that the code in the function that would be executed in the server case can be removed since it is never executed. Signed-off-by: Ken Cox

[PATCH 0/4] Staging: unisys: Code cleanup

2014-07-03 Thread Ken Cox
This series implements various cleanups for the Unisys drivers, including: -Renaming functions using Linux kernel conventions -Removing dead code -fixing noderef sparse warnings ___ devel mailing list de...@linuxdriverproject.org http://driverdev.

[PATCH 1/4] Staging: unisys: use Linux coding convention for function names

2014-07-03 Thread Ken Cox
NNEL_itoa() --> vbuschannel_itoa() Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 4 ++-- .../unisys/common-spar/include/vbusdeviceinfo.h| 28 +++--- drivers/staging/unisys/uislib/uislib.c | 2 +- 3 files changed, 17 insertions(+),

Re: randconfig build error with next-20140630, in drivers/staging/unisys/channels/chanstub.c

2014-06-30 Thread Ken Cox
On 06/30/2014 11:13 AM, Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `channel_mod_init': chanstub.c:(.init.text+0xcbcf): undefined reference to `unisys_spar_platform' make: *** [vmlinux] Error 1 Hi Jim, I have already submitted a patch

[PATCH] Staging:unisys: Add Kconfig dependency on UNISYS_VISORUTIL to UNISYS_CHANNELSTUB

2014-06-30 Thread Ken Cox
`channel_mod_init': chanstub.c:(.init.text+0xbe24): undefined reference to `unisys_spar_platform' Reported by: kbuild test robot Signed-off-by: Ken Cox --- drivers/staging/unisys/channels/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/channe

[PATCH v2 1/2] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
elsewhere. In addition, using these macros breaks the build if using gcc 4.9.0 Reported-by: Greg Kroah-Hartman Signed-off-by: Ken Cox --- drivers/staging/unisys/include/vbushelper.h | 8 +++- drivers/staging/unisys/uislib/uisutils.c| 11 --- drivers/staging

[PATCH v2 2/2] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-26 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys

[PATCH v2 0/2] Staging: unisys: Remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
This series removes all references to __DATE__ and __TIME__ from the unisys drivers and also removes BROKEN from the Kconfig so the drivers can be built. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

Re: [PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
On 06/25/2014 10:57 PM, Greg KH wrote: On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote: --snip-- .id_table = virthba_id_table, .probe = virthba_probe, .remove = virthba_remove, @@ -1413,9 +1413,6 @@ info_proc_read(struct file *file, char __user *buf, size_t

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-25 Thread Ken Cox
On 06/17/2014 06:01 PM, Greg KH wrote: On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../common-spar/include/channels

[PATCH 4/4] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-25 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Benjamin Romer Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b

[PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-25 Thread Ken Cox
elsewhere. In addition, using these macros breaks the build if using gcc 4.9.0 Reported-by: Greg Kroah-Hartman Signed-off-by: Ken Cox --- drivers/staging/unisys/uislib/uisutils.c| 8 +++- drivers/staging/unisys/virthba/virthba.c| 7 ++- drivers/staging

[PATCH 3/4] Staging: unisys: Remove build_date and build_time from virtpci_driver structure

2014-06-25 Thread Ken Cox
The drivers do not need to keep track of these fields since the same information is present elsewhere in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 2 -- drivers/staging/unisys/virtpci/virtpci.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers

[PATCH 0/4] Staging: unisys: Remove references to __DATE__ and __TIME__

2014-06-25 Thread Ken Cox
This series removes all references to __DATE__ and __TIME__ from the unisys drivers and also removes BROKEN from the Kconfig so the drivers can be built. PATCH 1: Gets rid of references to __DATE__ and __TIME__ PATCH 2: Removes buildDate and buildTime arguments from BusDeviceInfo_Init() PATCH 3: R

[PATCH 2/4] Staging: unisys: remove buildDate and buildTime arguments from BusDeviceInfo_Init

2014-06-25 Thread Ken Cox
The unisys drivers no longer need to record the build date and time since the same info is already in the kernel elsewhere. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/vbushelper.h | 8 +++- drivers/staging/unisys/uislib/uisutils.c| 7

Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-23 Thread Ken Cox
On 06/17/2014 05:49 PM, Greg KH wrote: On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote: The unisys drivers now properly check to make sure they are running on the s-Par platform before they will initialize. This was fixed in commit fcd0157ece so it is safe to allow the unisys drivers

[Patch v3 4/4] Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

2014-06-05 Thread Ken Cox
vbuschannel_devinfo_to_string() was declared with the devinfo argument as a pointer to __iomem space. No callers of this function need the __iomem space, so I removed that constraint. Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to operate on I/O space. Signed-off-by

[Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 40 -- drivers/staging/unisys/uislib/uislib.c | 2 +- 2

[Patch v3 1/4] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include

[PATCH v3 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings and also removing __iomem declarations where they are not needed. While we are at it, we fix up the function names of the functions that we are modifying so that they com

[Patch v3 3/4] Staging: unisys: make function names Linux compliant

2014-06-05 Thread Ken Cox
Changed function declarations in drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h so that the function names follow Linux coding standards. Signed-off-by: Ken Cox --- .../unisys/common-spar/include/vbusdeviceinfo.h| 28 +++--- 1 file changed, 14 insertions

Re: [PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
On 06/05/2014 11:22 AM, Greg KH wrote: On Thu, Jun 05, 2014 at 11:04:32AM -0500, Ken Cox wrote: Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox

[PATCH v2 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings. In the first patch, we clean up the function names so they are acceptable then we add the new functions in the second patch. __

[PATCH v2 1/2] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include

[PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../staging/unisys/common-spar/include/channels/vbuschannel.h | 11 ++- drivers/staging/unisys

[PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-03 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Benjamin Romer Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b

Re: [PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-28 Thread Ken Cox
On 05/28/2014 09:17 AM, Greg KH wrote: On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote: On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse

Re: [PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-28 Thread Ken Cox
On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef

[PATCH 4/6] Staging: unisys: Remove unused macros from visorchannel/visorchannel.h

2014-05-22 Thread Ken Cox
. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchannel/visorchannel.h | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel.h b/drivers/staging/unisys/visorchannel/visorchannel.h index 784f03a

[PATCH 6/6] Staging: unisys: visorchipset: Remove filexfer.c

2014-05-22 Thread Ken Cox
There is not any code using the functionality in filexfer.c so I removed it and filexfer.h. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchipset/Makefile | 2 +- drivers/staging/unisys/visorchipset/filexfer.c | 506 - drivers/staging/unisys/visorchipset

[PATCH 5/6] Staging: unisys: Fixup sparse warnings for dereferencing noderef types.

2014-05-22 Thread Ken Cox
Fixed the usage of the following so they don't try to dereference pointers to iomem. CHANNEL_U64_MISMATCH CHANNEL_U32_MISMATCH wait_for_valid_guid Signed-off-by: Ken Cox --- .../unisys/common-spar/include/channels/channel.h | 16 --- drivers/staging/u

[PATCH 2/6] Staging: unisys: Fix sparse warnings in uislib

2014-05-22 Thread Ken Cox
Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel() function so that it can operate on both memory space and IO space without getting sparse warnings. Signed-off-by: Ken Cox --- .../unisys/common-spar/include/channels/vbuschannel.h| 12 ++-- drivers/staging

[PATCH 3/6] Staging: unisys: virthba: declare virthba_queue_command as static

2014-05-22 Thread Ken Cox
virthba_queue_command() is only used inside virthba.c so declare it static. Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba

[PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-22 Thread Ken Cox
This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros _

[PATCH 1/6] Staging: unisys: Fix sparse warnings

2014-05-22 Thread Ken Cox
Fix sparse warnings caused by incorrect references to IO space. Signed-off-by: Ken Cox --- drivers/staging/unisys/uislib/uislib.c | 2 +- drivers/staging/unisys/visorchannel/visorchannel.h | 6 +++--- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 4

Re: [Patch V2 0/2] staging: unisys: Fix module loading on non s-Par platform

2014-05-12 Thread Ken Cox
On 04/28/2014 12:23 PM, Ken Cox wrote: Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. Also, MODULE_LICENSE("GPL") has been added to visorkmodutils.c. Greg, Have you had a chance to look a

[PATCH V2 2/2] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-28 Thread Ken Cox
The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c b/drivers/staging/unisys/visorutil/visorkmodutils.c index 7521027

[PATCH V2 1/2] Staging: unisys: detect s-Par firmware

2014-04-28 Thread Ken Cox
if no s-Par firmware is present. This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Ken Cox Tested by: Ken Cox --- drivers/staging/unisys/channels/chanstub.c | 3 ++ drivers

[Patch V2 0/2] staging: unisys: Fix module loading on non s-Par platform

2014-04-28 Thread Ken Cox
Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. Also, MODULE_LICENSE("GPL") has been added to visorkmodutils.c. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 4/4] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-28 Thread Ken Cox
On 04/25/2014 05:32 PM, Greg KH wrote: On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote: The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging

[PATCH 3/4] Staging: unisys: virthba: add MODULE_DEVICE_TABLE

2014-04-24 Thread Ken Cox
Add x86_cpu_id struct and call to MODULE_DEVICE_TABLE so this module will be auto loaded on boot. Signed-off-by: Ken Cox Tested-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b

[Patch 0/4] staging: unisys: Fix module loading on non s-Par platform

2014-04-24 Thread Ken Cox
This series fixes the problem reported by Fengguang Wu where the unisys modules will cause a panic if loaded on a non s-Par platform. Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. In addition, a MODULE_D

[PATCH 4/4] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-24 Thread Ken Cox
The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c b/drivers/staging/unisys/visorutil/visorkmodutils.c index 87ed5bf

[PATCH 2/4] Staging: unisys: Added check for s-Par platform in each init function.

2014-04-24 Thread Ken Cox
This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Ken Cox Tested by: Ken Cox --- drivers/staging/unisys/channels/chanstub.c| 5 + drivers/staging/unisys/uislib

[PATCH 1/4] staging: unisys: detect s-Par firmware

2014-04-24 Thread Ken Cox
platform and refuse to load if no s-Par firmware is present. This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Benjamin Romer Tested-by: Benjamin Romer Signed-off-by: Ken Cox Tested-by

Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

2014-04-07 Thread Ken Cox
Author: Ken Cox AuthorDate: Tue Mar 4 07:58:07 2014 -0600 Commit: Greg Kroah-Hartman CommitDate: Tue Mar 4 16:58:21 2014 -0800 staging: visorchipset driver to provide registration and other services I think Sasha has already sent a fix to resolve this issue that I'll be sendi

Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

2014-04-07 Thread Ken Cox
On 04/07/2014 06:17 AM, Fengguang Wu wrote: Hi Ken, I got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 12e364b9f08aa335dc7716ce74113e834c993765 Author: Ken Cox AuthorDate: Tue Mar 4 07:58:07 2014 -0600 Commit

Re: [PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-28 Thread Ken Cox
On 03/28/2014 07:53 AM, Dan Carpenter wrote: On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote: Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert

[PATCH 3/8] Staging: unisys: Remove FAIL_WPOSTCODE_1 macro

2014-03-19 Thread Ken Cox
Part of a series to get rid of goto statements embedded in macros. I'm breaking this up into a series of smaller patches for easier review. The later patches in the series will actually remove the goto statements. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timsk

[PATCH 7/8] Staging: unisys: Remove FAIL macro

2014-03-19 Thread Ken Cox
The FAIL macro ultimately includes a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 12 --- .../unisys/visorchannel/visorchannel_funcs.c | 97 ++ drivers/staging/unisys/visorchipset

[PATCH 5/8] Staging: unisys: Remove RETPTR macro

2014-03-19 Thread Ken Cox
The RETPTR macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 --- drivers/staging/unisys/uislib/uislib.c | 11 --- drivers/staging/unisys/uislib/uisqueue.c | 1

[PATCH 2/8] Staging: unisys: Cleanup macros to get rid of goto statements

2014-03-19 Thread Ken Cox
aking this up into a series of smaller patches for easier review. The later patches in the series will actually remove the goto statements. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 83 -- .../unisys/visorchipset/visorchipset_m

[PATCH 8/8] Staging: unisys: Remove RETINT macro

2014-03-19 Thread Ken Cox
The RETINT macro included a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 -- drivers/staging/unisys/uislib/uisqueue.c | 9 ++-- .../unisys/visorchannel/visorchannel_funcs.c | 10

[PATCH 6/8] Staging: unisys: Remove RETVOID macro

2014-03-19 Thread Ken Cox
The RETVOID macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 2 -- drivers/staging/unisys/uislib/uisqueue.c| 1 - drivers/staging/unisys/visorchipset/parser.c

[PATCH 4/8] Staging: unisys: Remove RETBOOL macro

2014-03-19 Thread Ken Cox
The RETBOOL macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 --- drivers/staging/unisys/uislib/uisqueue.c | 1 - .../unisys/visorchannel/visorchannel_funcs.c | 37

[Patch 0/8] Staging: unisys: Get rid of goto statements in macros

2014-03-19 Thread Ken Cox
This series gets rid of a number of macros that ultimately include a goto statement. The first patches clean up unused macros and macros that reference other macros which eventually contain a goto statement. The latter patches actually remove the goto statements. __

[PATCH 1/8] Staging: unisys: include: Remove unused macros from timskmod.h

2014-03-19 Thread Ken Cox
The following macros were never referenced and have been removed: DEVFROMID DEVFROMFILE DEVFROMINODE DEVFROMIDX TRY_WPOSTCODE_3 Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 118 -- 1 file changed, 118

Re: [PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-18 Thread Ken Cox
On 03/17/2014 04:43 PM, Mark Einon wrote: Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox diff --git

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Ken Cox
On 03/17/2014 07:26 PM, DaeSeok Youn wrote: I think vmalloc/kmalloc in uislib_malloc() can be removed and just use vmalloc/kmalloc directly. (UISMALLOC() macro is also removed.) And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which is just tracing buffer status(Malloc_FailuresAl

[Patch V2 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-17 Thread Ken Cox
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack by removing visor_hexDumpToBuffer() and using hex_dump_to_buffer() instead. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h | 22 -- .../unisys/visorchannel

Re: [PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-17 Thread Ken Cox
On 03/16/2014 05:13 PM, Mark Einon wrote: On 13/03/14 20:39, Ken Cox wrote: Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys

[PATCH 5/6] Staging: unisys: visorchipset: Clean up sparse warnings in visorchipset code.

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings due to accessing I/O space. Also declared functions and variables as static if they are only used locally. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchipset/controlvm_direct.c | 1 + drivers/staging/unisys/visorchipset/file.c

[PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys/visorutil/visorkmodutils.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions

[PATCH 2/6] Staging: unisys: Clean multiple sparse warnings

2014-03-13 Thread Ken Cox
Cleaned up multiple sparse warnings, mostly due to improper access of I/O space. Also declared functions and variables that were only used locally as static. Removed ULTRA_disp_channel_header(), ULTRA_disp_channel(), ULTRA_disp_vnic_channel() because they were never called. Signed-off-by: Ken

[PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-13 Thread Ken Cox
Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox --- drivers/staging/unisys/channels/channel.c| 166

[PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert() since they were not called from anywhere. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchannel

[patch 0/6] Staging: unisys: Clean sparse warnings in unisys driver code

2014-03-13 Thread Ken Cox
This series cleans up many sparse warnings in the unisys driver code. There are still some sparse warnings that will be cleaned up in a future patch, but the majority of the warnings are addressed by these patches. ___ devel mailing list de...@linuxdriv

[PATCH 3/6] Staging: unisys: uislib: Cleanup sparse warnings in uislib

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings, mostly related to accessing I/O space. Remove uislibcmpxchg64() and use cmpxchg() instead. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/uisqueue.h | 56 +++ drivers/staging/unisys/include/uisutils.h | 8

[PATCH] Staging: unisys: Fix multiple variable length array declarations

2014-03-07 Thread Ken Cox
There were multiple variable length arrays declared on the stack in proc handlers: char buf[count]; I changed these to be fixed length arrays. Signed-off-by: Ken Cox --- drivers/staging/unisys/uislib/uislib.c | 39 +--- drivers/staging/unisys/virthba

[PATCH] Staging: unisys: uislib: Fix locking in info_proc_read_helper()

2014-03-07 Thread Ken Cox
Make sure BusListLock is unlocked before returning. If an error is encountered early on in info_proc_read_helper() the function can return without unlocking. Also changed the PROCLINE macro so that it doesn't include a goto statement. Reported-by: Dan Carpenter Signed-off-by: Ke

[Patch V3] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
On 03/07/2014 10:02 AM, Greg KH wrote: On Fri, Mar 07, 2014 at 07:10:57AM -0600, Ken Cox wrote: A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys

[Patch V2] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers

[Patch V2] Staging: unisys: virthba: Add dependency on SCSI

2014-03-06 Thread Ken Cox
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with undefined symbols. Reported-by: kbuild test robot Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/virthba

[PATCH] Staging: unisys: virthba: Add dependency on SCSI

2014-03-06 Thread Ken Cox
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with undefined symbols. Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/virthba/Kconfig b/drivers/staging/unisys

Re: [PATCH 3/3] staging: unisys: Fix MAINTAINERS and TODO

2014-03-06 Thread Ken Cox
On 03/05/2014 10:40 PM, Greg KH wrote: On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote: Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox --- MAINTAINERS

[PATCH 1/3] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
A number of functions were used for debug at one time but that code has been removed. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h| 99 +--- drivers/staging/unisys/visorutil/visorkmodutils.c | 565 -- 2 files changed, 1 insertion(+), 663

[PATCH 3/3] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Ken Cox
Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox --- MAINTAINERS| 5 + drivers/staging/unisys/MAINTAINERS | 6 -- drivers/staging/unisys/TODO| 1

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
Please disregard patches 9-11 sent previously. Corrected patches follow. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/11] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Ken Cox
From: Ken Cox Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox --- MAINTAINERS| 7 +++ drivers/staging/unisys/MAINTAINERS | 6 -- drivers/staging/unisys

[PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
From: Ken Cox A number of functions were used for debug at one time but that code has been removed. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h| 99 +--- drivers/staging/unisys/visorutil/visorkmodutils.c | 565 -- 2 files changed, 1

Re: [patch V2 8/8] staging: s-Par driver documentation

2014-03-05 Thread Ken Cox
On 03/04/2014 06:57 PM, Greg KH wrote: On Tue, Mar 04, 2014 at 07:58:12AM -0600, Ken Cox wrote: Index: upstream-staging/drivers/staging/unisys/MAINTAINERS === Are you using cvs? Please start using git... I'm using qui

Re: [patch V2 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

2014-03-05 Thread Ken Cox
On 03/04/2014 06:54 PM, Greg KH wrote: On Tue, Mar 04, 2014 at 07:58:05AM -0600, Ken Cox wrote: +EXPORT_SYMBOL_GPL(proc_CreateType); You have some _very_ generic symbols that you are now exporting. Here's another funny one: +int hexDumpWordsToBuffer(char *dest, +

[patch V2 8/8] staging: s-Par driver documentation

2014-03-04 Thread Ken Cox
Documentation for the set of s-Par drivers Signed-off-by: Ken Cox Cc: Ben Romer Index: upstream-staging/drivers/staging/unisys/Documentation/proc-entries.txt === --- /dev/null +++ upstream-staging/drivers/staging/unisys

[patch V2 4/8] staging: visorchannelstub driver to provide channel support routines

2014-03-04 Thread Ken Cox
The visorchannelstub module provides support routines for storing and retrieving data from a channel. Signed-off-by: Ken Cox Cc: Ben Romer Index: upstream-staging/drivers/staging/unisys/Kconfig === --- upstream-staging.orig

[patch V2 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-04 Thread Ken Cox
This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a fully functional system will be submitted after review of this initial set. s-Par is firmware that

Re: [patch 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

2014-03-04 Thread Ken Cox
On 03/03/2014 04:20 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 02:05:07PM -0600, Romer, Benjamin M wrote: Hi Greg, The copyright text is old boilerplate that we'd been carrying. Be careful about "old boilerplate", that can get you in trouble :) We'll change it so that it's correctly GPL 2 o

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Ken Cox
On 03/03/2014 01:22 PM, Dan Carpenter wrote: What software do we need to test this? Is there a quick start guide? Unisys hardware/firmware is required. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailma

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Ken Cox
On 03/03/2014 01:12 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 11:01:14AM -0600, Ken Cox wrote: This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a

[patch 8/8] staging: s-Par driver documentation

2014-03-03 Thread Ken Cox
Documentation for the set of s-Par drivers Signed-off-by: Ken Cox Cc: Ben Romer Index: linux-2.6.staging/drivers/staging/unisys/Documentation/proc-entries.txt === --- /dev/null +++ linux-2.6.staging/drivers/staging/unisys

[patch 4/8] staging: visorchannelstub driver to provide channel support routines

2014-03-03 Thread Ken Cox
The visorchannelstub module provides support routines for storing and retrieving data from a channel. Signed-off-by: Ken Cox Cc: Ben Romer Index: upstream-staging/drivers/staging/unisys/Kconfig === --- upstream-staging.orig

  1   2   >