Re: [PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 07:12:28PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:57:43 CEST Kari Argillander wrote: > > > > On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > Fu

Re: [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:33PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Hi, > > The following PR contains now usual maintenance for the wfx driver. I have > more-or-less sorted the patches by importance: > - the first ones are fixes for a few corner-cases reported by use

Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:49:30PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:27:18 CEST Kari Argillander wrote: > > On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > Comments after t

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:54:36PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:31:00 CEST Kari Argillander wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender an

Re: [PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Function arguments must be aligned with left parenthesis. Apply that > rule. To my eyes something still go wrong with this patch. Might be my email fault, but every other patch looks ok. Now these are to

Re: [PATCH 13/31] staging: wfx: update with API 3.8

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > API 3.8 introduces new statistic counters. These changes are backward > compatible. It will be obvious to some what API 3.8 is. But at least me can rise my hand and admit that I do not. Probably wfx api

Re: [PATCH 17/31] staging: wfx: simplify hif_join()

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:50PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > The new code is smaller. > > Signed-off-by: Jérôme Pouiller > --- > drivers/staging/wfx/hif_tx.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/wfx/hif_tx

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:35PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > During the scan requests, the Tx traffic is suspended. This lock is > shared by all the network interfaces. So, a scan request on one > interface will block the traffic on a second interface. This causes

Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Comments after the last #endif of header files don't bring any > information and are redundant with the name of the file. Drop them. How so? You see right away that this indeed is header guard and not so

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-28 Thread Kari Argillander
On Thu, Jan 28, 2021 at 10:42:54AM +0100, Geert Uytterhoeven wrote: > Hi Kari, > > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander > wrote: > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > > > On Thu, 28 Jan 2021 00:32:22 +0200 > > > Kari Ar

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Kari Argillander
On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote: > On Thu, 28 Jan 2021 00:32:22 +0200 > Kari Argillander wrote: > > > #include "fbtft.h" > > > > > > #define DRVNAME "fb_st7789v" > > > @@ -66,6 +69,32 @@ enum st7789v_c

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Kari Argillander
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > diff --git a/drivers/staging/fbtft/fb_st7789v.c > b/drivers/staging/fbtft/fb_st7789v.c > index 3a280cc..cb

Re: [PATCH] staging: rtl8192e: fix bool comparison in expressions

2020-12-20 Thread Kari Argillander
On Thu, Dec 17, 2020 at 05:12:04PM +0530, Aditya Srivastava wrote: > There are certain conditional expressions in rtl8192e, where a boolean > variable is compared with true/false, in forms such as (foo == true) or > (false != bar), which does not comply with checkpatch.pl (CHECK: > BOOL_COMPARISON)

Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.

2020-12-20 Thread Kari Argillander
Good thing is that you really didn't send so many patches or atleast I won't see them. And it seems that you are new so welcome a board :) -- Kari Argillander ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: qlge: Removed duplicate word in comment.

2020-12-20 Thread Kari Argillander
any does it just for reading. That way if someone needs to send you email it wont be lost because you do not read that email anymore. Many does that they still send messages from they real email so that email do get so many emails. This is ofcourse your decission I'm just telling y

[PATCH] staging: pi433: Fix disordered switch case

2017-12-12 Thread Kari Argillander
Case: SHAPING_0_5 is writing DATAMODUL_MODLATION_SHAPE_0_3 value and vice versa Signed-off-by: Kari Argillander --- I have checked that defines are correct accounting to the datasheet. My first patch. Hopefully everything goes like needs to. I do not know if this should go to stable because