Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

2018-07-03 Thread Justin Skists
> On 03 July 2018 at 08:31 Tamir Suliman wrote: > +++ b/drivers/staging/speakup/keyhelp.c > @@ -167,7 +167,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, > u_char ch, u_short key) > synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO)); > build_key_data(); /*

Re: [PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.

2018-06-30 Thread Justin Skists
On 29 June 2018 19:10:07 BST, John Whitmore wrote: >There are two files named "rtl819x_HT.h" > >$ find . -name rtl819x_HT.h -print >./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h >./drivers/staging/rtl8192e/rtl819x_HT.h > >The two files are very similar but differ slightly. Unsed definitions

Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

2018-06-25 Thread Justin Skists
> On 25 June 2018 at 13:36 John Whitmore wrote: > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > > wrote: > > > Replaced memory initialising loop with memset, as suggested by Andy > > > Shevchenko > > > > > > > Sugg

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
> On 18 June 2018 at 09:46 Samuel Thibault wrote: > > > Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit: > > > On 18 June 2018 at 06:34 Gregory Nowak wrote: > > > With /sys/accessibility/speakup/synth set to bns, I am getting output > > >

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
> On 18 June 2018 at 06:34 Gregory Nowak wrote: > > > On Tue, Jun 12, 2018 at 08:31:06AM +0200, Samuel Thibault wrote: > > The load/unload is about the module itself, i.e. modprobe speakup_bns ; > > modprobe speakup_soft, switch between them, then rmmod speakup_bns ; > > speakup_soft or the co

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Justin Skists
On Wed, Jun 06, 2018 at 03:26:28PM +0200, Samuel Thibault wrote: > Hello, > > Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > > The synths[] array is a collection of synths acting like a list. > > There is no need for synths to be an array, so refactor synths[

Re: staging: rtl8192e: Series of coding style changes

2018-06-06 Thread Justin Skists
> On 06 June 2018 at 12:39 John Whitmore wrote: > Again these are just some simple coding style changes to the file, so nothing > of importance. If it keeps grumpy maintainers happy, then it's of great importance! :-) Justin ___ devel mailing list de

[PATCH] staging: speakup: refactor synths array to use a list

2018-06-04 Thread Justin Skists
: Justin Skists --- drivers/staging/speakup/spk_types.h | 2 ++ drivers/staging/speakup/synth.c | 40 ++--- 2 files changed, 15 insertions(+), 27 deletions(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index 3e082dc3d45c

Re: [PATCH 2/6] staging: android: Clean up license identifiers

2018-05-14 Thread Justin Skists
> On 14 May 2018 at 14:29 Dan Carpenter wrote: > > > On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote: > > Add the identifiers when missing and fix the ones already present > > according to checkpatch.pl. > > > > Signed-off-by: Nathan Chancellor > > --- > > drivers/staging/a

[PATCH] staging: lustre: lnet: add static to libcfs_dev declaration

2018-05-10 Thread Justin Skists
Add a static prefix to the declaration for libcfs_dev. This would fix the following sparse warning: drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol 'libcfs_dev' was not declared. Should it be static? Signed-off-by: Justin Skists --- drivers/staging/lustre/l

[PATCH] staging: lustre: lnet: use correct 'magic' test

2018-03-21 Thread Justin Skists
message. Fixes: 80782927e3aa ("staging: lustre: Fix unneeded byte-ordering cast") Cc: NeilBrown Signed-off-by: Justin Skists --- drivers/staging/lustre/lnet/lnet/acceptor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/accept

Re: [PATCH] staging: lustre: Fix unneeded byte-ordering cast

2018-03-20 Thread Justin Skists
On 20 March 2018 at 01:06, NeilBrown wrote: > On Sat, Mar 17 2018, Justin Skists wrote: > >> Fix sparse warning: >> >> CHECK drivers/staging//lustre/lnet/lnet/acceptor.c >> drivers/staging//lustre/lnet/lnet/acceptor.c:243:30: warning: cast to >> restrict

[PATCH] staging: lustre: Fix unneeded byte-ordering cast

2018-03-17 Thread Justin Skists
ned-off-by: Justin Skists --- drivers/staging/lustre/lnet/lnet/acceptor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c index fb478e20e204..13e981781b9a 100644 --- a/drivers/staging/lustre

[PATCH] staging/speakup: fix checkpatch.pl warning in speak_char()

2017-09-06 Thread Justin Skists
correct the following warning from checkpatch.pl:- WARNING: Prefer using '"%s...", __func__' to using 'speak_char', this function's name, in a string Signed-off-by: Justin Skists Acked-by: Samuel Thibault --- drivers/staging/speakup/main.c | 2 +- 1 file