[PATCH v3] staging: xgifb: remove macros with hidden variable

2017-12-01 Thread Joshua Abraham
This patch removes macros in XGI_main.h that contain a xgifb_info variable. These macros hurt readability by hiding said variable behind a define. It also uses a temporary variable to keep the replaced code from getting too long. Signed-off-by: Joshua Abraham --- drivers/staging/xgifb

[PATCH v2] staging: xgifb: remove macros with hidden variable

2017-11-30 Thread Joshua Abraham
This patch removes macros in XGI_main.h that contain a xgifb_info variable. These macros hurt readability by hiding said variable behind a define. Signed-off-by: Joshua Abraham --- drivers/staging/xgifb/XGI_main.h| 13 --- drivers/staging/xgifb/XGI_main_26.c | 227

[PATCH] staging: xgifb: remove unused macro XGIPART3

2017-11-29 Thread Joshua Abraham
Signed-off-by: Joshua Abraham This patch removes the unused macro XGIPART3. --- drivers/staging/xgifb/XGI_main.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h index a3af1cbbf8ee..5f55d0a39bc1 100644 --- a/drivers/staging

[PATCH] staging: nvec: Fix usleep_range is preferred over udelay

2017-11-29 Thread Joshua Abraham
Signed-off-by: Joshua Abraham This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging

[PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Joshua Abraham
This patch completes TODO improvements in rf69.c to change shift constants to a define. Signed-off-by: Joshua Abraham --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided

2017-11-07 Thread Joshua Abraham
This patch fixes the checkpatch.pl warning: "CHECK: multiple assignments should be avoided" Signed-off-by: Joshua Abraham --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa

[PATCH] staging: dgnc: Fix usleep_range is preferred over udelay

2017-11-07 Thread Joshua Abraham
This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt Signed-off-by: Joshua Abraham --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers