0 or NULL,
> where some of the fields already use labels, and where there are nested
> structures.
I responded to patches 6 and 8 with comments; for the rest (1-5, 7, 9):
Reviewed-by: Josh Triplett
___
devel mailing list
de...@linuxdriverp
294967295.
> This is a bug in the kernel source not sparse.
Except that "filter" has an "int channel" (signed), so it can
successfully test "channel < 0" and return early; it'll never call
ni_stc_dma_channel_select_bitfield(channel) with a negative number.
I do agree that this code should sort out the signedness of its types,
but in this case I don't think the bad shift can actually happen, making
this a false positive.
- Josh Triplett
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, May 22, 2014 at 09:58:02PM +0200, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist
Reviewed-by: Josh Triplett
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 110
> +-
Move functions declaration to coherent internal header file.
>
> Signed-off-by: Neil 'Superna' Armstrong
Reviewed-by: Josh Triplett
> drivers/staging/wlan-ng/prism2mgmt.h |5 +
> drivers/staging/wlan-ng/prism2sta.c |4
> 2 files changed, 5 insertions(+
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Josh Triplett
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
> 1 file changed, 3 insertio
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld
Reviewed-by: Josh Triplett
&g
erman
> Signed-off-by: Levente Kurusa
Reviewed-by: Josh Triplett
> drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> b/drivers/staging/media/davi
On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote:
> Mark functions as static in bpctl_mod.c because they are not used
> outside this file. Remove unused function from bpctl_mod.c.
>
[...]
>
> Signed-off-by: Rashika Kheria
Reviewed-by
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/wlags49_h2/wl_version.h | 4
1 file chang
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
1 file chang
make sure no new
uses get added.
Josh Triplett (7):
mtd: denali: Drop print of build date/time
net: wireless: brcm80211: Drop debug version with build date/time
staging: rtl8188eu: Drop print of build date/time
staging: rts5139: Drop print of build time
staging: wlags49_h2: Drop debug
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __TIME__,
which makes the build non-deterministic. (And, without __DATE__,
__TIME__ provided little useful information to begin with.)
Signed-off-by: Josh Tri
s’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/Qos.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 1609a2
ce.c:
> drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for
> ‘dgnc_tracer_free’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dgnc/dgnc_trace.c |1 +
> 1 file changed, 1 insertion(+)
>
rototype for
> ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/nvm.c | 61
> -
> 1 file changed, 61 deletions(-)
>
> diff --git a/drivers/staging/bcm/nvm.c
ce.c:
> drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for
> ‘dgap_tracer_free’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dgap/dgap_trace.c |1 +
> 1 file changed, 1 insertion(+)
>
totype for
> ‘t3e3_port_del_stats’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/sbe-2t3e3/ctrl.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/sbe-2t3e3/ctrl.c
p/dgap_parse.c:1252:7: warning: no previous prototype for
> ‘dgap_create_config_string’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for
> ‘dgap_get_config_letters’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by:
vious prototype for
> ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dwc2/core.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/core.c b
s prototype for
> ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/sm7xxfb/sm7xxfb.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
&
s prototype for ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/hv/hv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index f0c5e07.
.o
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c: In function
> 'request_code_segment':
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c:581:6: warning:
> 'status' may be used uninitialized in this function [-Wuninitialized]
>
>
> Signed-
On Mon, Nov 04, 2013 at 10:01:00AM +0300, Dan Carpenter wrote:
> I've dropped most of the people from the CC list.
>
> On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote:
> > On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote:
> > > On Sun, Nov
On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote:
> On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote:
> > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> > > The icount.reserved[] array isn't initialized so it leaks stack
> &g
On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> The icount.reserved[] array isn't initialized so it leaks stack
> information to userspace.
>
> Reported-by: Nico Golde
> Reported-by: Fabian Yamaguchi
> Signed-off-by: Dan Carpenter
Reviewed-by: Josh Tri
at code, especially as I don't test it :)
>
> Minchan, Jiang, Nitin, what do you think of the patch below? Can I get
> your ack on it so that I can apply it?
I think you actually want to review v3 of this patch, not v2.
- Josh Triplett
___
26 matches
Mail list logo
