Re: [PATCH v2] staging: xgifb: remove macros with hidden variable

2017-12-01 Thread Josh Abraham
On Fri, Dec 01, 2017 at 10:12:30AM +0300, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote: > > diff --git a/drivers/staging/xgifb/XGI_main_26.c > > b/drivers/staging/xgifb/XGI_main_26.c > > index 6feecc55d2bc..6de66eaad96b 100644 > > --- a/drivers/staging/xgif

Re: [PATCH] staging: xgifb: remove unused macro XGIPART3

2017-11-30 Thread Josh Abraham
On Thu, Nov 30, 2017 at 08:55:44AM +0300, Dan Carpenter wrote: > On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote: > > Signed-off-by: Joshua Abraham > > > > This patch removes the unused macro XGIPART3. > > > > The Signed-off-by line goes after the changelog. > > > --- > > drive

Re: [PATCH] staging: nvec: Fix usleep_range is preferred over udelay

2017-11-29 Thread Josh Abraham
On Wed, Nov 29, 2017 at 06:07:53PM +0200, Mikko Perttunen wrote: > On 11/29/2017 06:00 PM, Joshua Abraham wrote: > > Signed-off-by: Joshua Abraham > > > > This patch fixes the issue: > > > > CHECK: usleep_range is preferred over udelay; see > > Documentation/timers/timers-howto.txt > > > > ---

Re: [PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided

2017-11-08 Thread Josh Abraham
On Wed, Nov 08, 2017 at 10:20:48AM +0100, Greg KH wrote: > On Tue, Nov 07, 2017 at 07:45:03PM -0500, Joshua Abraham wrote: > > This patch fixes the checkpatch.pl warning: > > "CHECK: multiple assignments should be avoided" > > > > Signed-off-by: Joshua Abraham > > --- > > drivers/staging/fsl-dpa

Re: [PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Josh Abraham
On Wed, Nov 08, 2017 at 02:52:30PM +0300, Dan Carpenter wrote: > On Wed, Nov 08, 2017 at 06:25:06AM -0500, Joshua Abraham wrote: > > This patch completes TODO improvements in rf69.c to change shift > > constants to a define. > > > > Signed-off-by: Joshua Abraham > > --- > > drivers/staging/pi433