Re: [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

2017-08-31 Thread Jonathan Whitaker
Thank you for all of the feedback! On Thu, Aug 31, 2017 at 2:07 AM, Dan Carpenter wrote: > Thanks! > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-deve

[PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

2017-08-30 Thread Jonathan Whitaker
Removed printk statements for debugging. The same information can be acquired via ftrace, so these print statements are uneccessary. Signed-off-by: Jonathan Whitaker --- Changes in v2: - Wrapped the changelog text to 72 columns. - Fixed the commit subject to be more clear. Changes in v3

[PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

2017-08-29 Thread Jonathan Whitaker
It is prefered to use '"%s...", __func__ instead of function names for logging. This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' style. These warnings were reported by checkpatch.pl. Signed-off-by: Jonathan Whitak

[PATCH] Staging: ks7010: Fix alignment should match open parenthesis.

2017-08-28 Thread Jonathan Whitaker
This commit fixes alignment styling as reported by checkpatch.pl. Signed-off-by: Jonathan Whitaker --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index

[PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl.

2017-08-28 Thread Jonathan Whitaker
This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' style. These warnings were reported by checkpatch.pl. Signed-off-by: Jonathan Whitaker --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti