[PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation - Style

Remove the unnecessary line continuation character to clear checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 10/11] staging:rtl8192u: Correct code alignment - Style

Correct the alignment of a function, this clears checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 03/11] staging:rtl8192u: Clear error with line ending ( - Style

Rewrite function call to clear the checkpatch issue with lines ending with a '(' character. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++--- 1 file

[PATCH 00/11] staging:rtl8192u: Coding Style changes

Just a number of simple coding style changes in the file ieee80211_module.c John Whitmore (11): staging:rtl8192u: Add missing SPDX-License-Identifier - Style staging:rtl8192u: Removed commented out include - Style staging:rtl8192u: Clear error with line ending ( - Style staging:rtl8192u

[PATCH 08/11] staging:rtl8192u: Add missing blank lines - Style

Add missing blank lines after declarations. This clears the resulting checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 ++ 1 file changed, 2

[PATCH 11/11] staging:rtl8192u: Correct comparison with NULL - Style

Correct code to remote comparison with NULL, this clears the resulting checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion

[PATCH 07/11] staging:rtl8192u: Correct code indentation - Style

Rewrite code block to correct the indentation of code. This clears the resulting checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++--- 1 file changed, 3

[PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style

Rewrite a test for NULL to comply with the coding style and clear the checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 04/11] staging:rtl8192u: Remove extra blank lines - Style

Remove the extra blank lines to clear checkpatch issue. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- 1 file changed, 3 deletions(-) diff --git a

[PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style

Add the missing SPDX-License-Identifier tag to file to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 + 1 file changed, 1 insertion

[PATCH 02/11] staging:rtl8192u: Removed commented out include - Style

Remove commented out #include directive. Additionally shorted a block comment to clear the checkpatch issue with line length. These are coding style changes which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211

[PATCH 05/11] staging:rtl8192u: Add spaces around + operator - Style

Add spaces around '+' operator to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH 05/13] staging:rtl8192u: Remove AdvCoding and GreenField - Style

On Fri, Sep 28, 2018 at 02:35:50PM +0200, Greg KH wrote: > On Wed, Sep 26, 2018 at 08:16:56PM +0100, John Whitmore wrote: > > The member variables AdvCoding and GreenField are unused in code so > > have been removed from the structure and associated initialisation > > functio

Re: [PATCH 05/13] staging:rtl8192u: Remove AdvCoding and GreenField - Style

On Fri, Sep 28, 2018 at 05:31:40PM +0300, Dan Carpenter wrote: > On Wed, Sep 26, 2018 at 08:16:56PM +0100, John Whitmore wrote: > > The member variables AdvCoding and GreenField are unused in code so > > have been removed from the structure and associated initialisation > > fu

[PATCH 00/13] staging:rtl8192u: Style & memory leak fix

but fixed it anyhow. I've tried to find this device, or a datasheet on it, so that I could actually make sure it still worked but that's not been possible. Apparently it's a discontinued device, but that possibly makes it a safer sandbox to start messing with. John Whitmo

[PATCH 05/13] staging:rtl8192u: Remove AdvCoding and GreenField - Style

The member variables AdvCoding and GreenField are unused in code so have been removed from the structure and associated initialisation function. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 06/13] staging:rtl8192u: Remove TxSTBC and RxSTBC - Style

Remove the member variables TxSTBC and RxSTBC as neither is used in code. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 -- drivers/staging/rtl8192u/ieee80211

[PATCH 13/13] staging:rtl8192u: Remove potential memory leak

Add call to ieee80211_networks_free() to avoid potential memory leak if allocation of pHTInfo fails. If the third allocation fails only the first successful allocation is freed, not the second. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 5 + 1

[PATCH 11/13] staging:rtl8192u: Remove TxBFCap - Style

The member variable TxBFCap is not used in code so has simply been removed from the code. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 3 --- drivers/staging/rtl8192u

[PATCH 09/13] staging:rtl8192u: Remove Rsvd2 - Style

Remove the unused member variable Rsvd2 from structure. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u

[PATCH 12/13] staging:rtl8192u: Remove ASCap - Style

Remove the unused member variable ASCap from code. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 4 drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 2 files

[PATCH 07/13] staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style

Remove the unused member variables DelayBA, PSMP and Rsvd1. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 3 --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2

[PATCH 10/13] staging:rtl8192u: Remove ExtHTCapInfo - Style

The member variable ExtHTCapInfo is not used in code so has been removed. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 3 --- drivers/staging/rtl8192u/ieee80211

[PATCH 01/13] staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style

on runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211.h| 1 - .../rtl8192u/ieee80211/rtl819x_HTProc.c | 57 --- 2 files changed, 58 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging

[PATCH 04/13] staging:rtl8192u: Move HTSetConnectBwModeCallback() - Style

emoved and the function implementation moved so that it is defined before it is used in the file. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211.h| 1 - .../rtl8192u

[PATCH 03/13] staging:rtl8192u: Remove definition of HTSetConnectBwMode - Style

Remove the redundant declaration of the function HTSetConnectBwMode() as it is not needed in the code. The function is already declared in header file, multiple declarations add nothing. This is a style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore

[PATCH 02/13] staging:rtl8192u: Make HTMcsToDataRate static - Style

The function HTMcsToDataRate() is not used outside the file in which it is defined, so has been declared as 'static' and the prototype removed from the header file. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --

[PATCH 08/13] staging:rtl8192u: Remove LSigTxopProtect - Style

Remove the unused member bit LSigTxopProtect. This member is not used in code so has been replaced with a 'padding' bit, to keep byte boundary alignment. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/stagin

Re: [PATCH 20/20] staging:rtl8192u: Rename OWN - Style

On Mon, Sep 10, 2018 at 05:09:27PM +0200, Greg KH wrote: > On Sat, Sep 01, 2018 at 12:02:50AM +0100, John Whitmore wrote: > > Rename the member variable 'OWN' to 'own', this is to comply with the > > coding standard, where variables are named in lowercase. >

Re: [PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

On Mon, Sep 10, 2018 at 10:19:29AM +0200, Greg KH wrote: > On Tue, Sep 04, 2018 at 11:56:23AM +0100, John Whitmore wrote: > > The function dot11d_init() was previously renamed to clear a style > > issue. Unfortunately the new name used, dot11d_init(), clashes with > > a syb

[PATCH 4/4] staging:rtl8192u: Remove typedef from enum opt_rst_type_e - Style

Remove the typedef directive from enumerated type opt_rst_type_e, this change clears the checkpatch issue with defining new types in the code. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 2/4] staging:rtl8192u: Refactor GET_COMMAND_PACKET_FRAG_THRESHOLD - Style

ntime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_firmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.h b/drivers/staging/rtl8192u/r819xU_firmware.h index 794dca7dcd95..e78e547044b4 100644 ---

[PATCH 1/4] staging:rtl8192u: Remove unused RTL8190_CPU_START_OFFSET - Style

The defined constant RTL8190_CPU_START_OFFSET is not used in the code so has been removed. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_firmware.h | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 0/4] staging:rtl8192u: Style changes r819xU_firmware.h

This short series of patches just clears simple checkpatch issues with the header file r819xU_firmware.h. John Whitmore (4): staging:rtl8192u: Remove unused RTL8190_CPU_START_OFFSET - Style staging:rtl8192u: Refactor GET_COMMAND_PACKET_FRAG_THRESHOLD - Style staging:rtl8192u: Remove typedef

[PATCH 3/4] staging:rtl8192u: Remove typedef from firmware_init_step_e - Style

Remove the typedef directive from enumerated type firmware_init_step_e this clears the checkpatch issue with adding new types to the code. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

The function dot11d_init() was previously renamed to clear a style issue. Unfortunately the new name used, dot11d_init(), clashes with a sybmol which is exported with the same name. To correct this problem the function has been renamed to rtl8192u_dot11d_init(). Signed-off-by: John Whitmore

[PATCH 0/1] staging:rtl8192u: Fix naming clash of exported symbol

I can only apologise for the oversight, sorry. John Whitmore (1): staging:rtl8192u: Rename dot11d_init to fix name clash drivers/staging/rtl8192u/ieee80211/dot11d.c | 6 +++--- drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 3 files chang

[PATCH 04/20] staging:rtl8192u: Add SPDX-License-Identifier - Style

Add SPDX-License-Identifier tag to the start of header file. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u

[PATCH 13/20] staging:rtl8192u: Rename PktSize Style

Rename the member variable 'PktSize' to 'pkt_size', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 20/20] staging:rtl8192u: Rename OWN - Style

Rename the member variable 'OWN' to 'own', this is to comply with the coding standard, where variables are named in lowercase. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl819

[PATCH 08/20] staging:rtl8192u: Fix space characters - Style

Fix the spacing issues, remove space after cast operation, and replace spaces at start of line with tab. These changes are purely coding style changes to resolve checkpatch issues. There should be no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 09/20] staging:rtl8192u: Remove RT_DEBUG_DATA - Style

Remove the RT_DEBUG_DATA Macro. The macro causes a number of checkpatch issues, and is not actually used in code, so can simply be removed without issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 06/20] staging:rtl8192u: Rename Rx_Smooth_Factor - Style

Rename the MACRO Rx_Smooth_Factor to RX_SMOOTH_FACTOR, this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging

[PATCH 17/20] staging:rtl8192u: Rename LastSeg - Style

Rename the member variable 'LastSeg' to 'last_seg', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 05/20] staging:rtl8192u: Rename RTL819xU_MODULE_NAME - Style

Rename the MACRO RTL819xU_MODULE_NAME to RTL819XU_MODULE_NAME, this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers

[PATCH 00/20] staging:rtl8192u: r8192U.h cleanup - Style

Yet another series of patchs to cleanup and clear some checkpatch isses, this time the file r8192U.h. These are all simple changes which are mostly renaming variables. A MACRO has been removed as it's not used in the code, and added SPDX-License-Identifier. John Whitmore (20): staging:rtl

[PATCH 01/20] staging:rtl8192u: Remove write_cam() - Style

Remove the function write_cam() as it is unused. Simple style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 1 - drivers/staging/rtl8192u/r8192U_core.c | 7 --- 2 files changed, 8 deletions(-) diff --git a

[PATCH 07/20] staging:rtl8192u: Refactor RT_TRACE - Style

Refactor the MACRO RT_TRACE to add parentheses around the parameter 'component', this clears the checkpatch warning with respect to precedence issues. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/stagin

[PATCH 02/20] staging:rtl8192u: Remove read_cam() - Style

Remove the function read_cam(), as it is unused in code. Simple style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 -- drivers/staging/rtl8192u/r8192U_core.c | 9 - 2 files changed, 11 deletions

[PATCH 11/20] staging:rtl8192u: Rename OFDM_Table_Length - Style

Rename the defined constant OFDM_Table_Length to OFDM_TABLE_LENGTH, this clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h| 2 +- drivers

[PATCH 12/20] staging:rtl8192u: Rename CCK_Table_length - Style

Rename the constant CCK_Table_length to CCK_TABLE_LENGTH, this clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h| 2 +- drivers/staging

[PATCH 03/20] staging:rtl8192u: Remove unused functions - Style

Remove unused function declarations. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 10 -- drivers/staging/rtl8192u/r8192U_core.c | 7 --- 2 files changed, 17 deletions

[PATCH 10/20] staging:rtl8192u: Rename PHY_Beacon_RSSI_SLID_WIN_MAX - Style

Rename the Macro PHY_Beacon_RSSI_SLID_WIN_MAX to PHY_BEACON_RSSI_SLID_WIN_MAX, this clears the checkpatch issue with CamelCase naming. This is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 14/20] staging:rtl8192u: Rename Offset - Style

Rename the member variable 'Offset' to 'offset', this clears the checkpatch issue with CamelCase naming. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- driv

[PATCH 15/20] staging:rtl8192u: Rename Reserved... structure members - Style

Rename the 'Reserved...' members of the 'tx_desc_819x_usb' structure to 'reserved...'. This change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore

[PATCH 19/20] staging:rtl8192u: Rename LINIP - Style

Rename the member variable 'LINIP' to 'linip', this change is to conform to the coding style guidelines, member variables in lowercase. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/stagi

[PATCH 16/20] staging:rtl8192u: Rename CmdInit - Style

Rename the member variable 'CmdInit, to 'cmd_init', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 18/20] staging:rtl8192u: Rename FirstSeg - Style

Rename the member variable 'FirstSeg' to 'first_seg', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change and as such should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl819

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Thu, Aug 30, 2018 at 03:34:01PM -0700, Joe Perches wrote: > On Wed, 2018-08-29 at 22:55 +0100, John Whitmore wrote: > > On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > > > On 08/29/2018 04:14 PM, Joe Perches wrote: > [] > > > > Perhaps support f

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Thu, Aug 30, 2018 at 11:26:28AM +0300, Dan Carpenter wrote: > On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue &g

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > On 08/29/2018 04:14 PM, Joe Perches wrote: > > On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue > > > with CamelCase na

[PATCH 16/21] staging:rtl8192u: Rename MPDUDensity - Style

Rename the bitfield member 'MPDUDensity' to 'mpdu_density', this clears the checkpatch issue with CamelCase naming. This is a coding style change which should not have an impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/

[PATCH 07/21] staging:rtl8192u: Rename TxSTBC - Style

ug logging have been removed. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 2 files changed, 1 inser

[PATCH 11/21] staging:rtl8192u: Rename DssCCk - Style

Rename the bitfield member 'DssCCk' to 'dss_cck', this clears the checkpatch issue with CamelCase naming. This is a coding style change which should not impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h

[PATCH 15/21] staging:rtl8192u: Rename MaxRxAMPDUFactor - Style

Rename the bitfield member 'MaxRxAMPDUFactor' to 'max_rx_ampdu_factor', this clears the checkpatch issue with CamelCase naming. The change is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ie

[PATCH 20/21] staging:rtl8192u: Rename TxBFCap - Style

h should not have an impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ie

[PATCH 19/21] staging:rtl8192u: Rename ExtHTCapInfo - Style

is is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --g

[PATCH 13/21] staging:rtl8192u: Rename Rsvd1 - Style

ntime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h index 7f11257e2675..132a6da3bf51

[PATCH 10/21] staging:rtl8192u: Rename MaxAMSDUSize - Style

Rename the bitfield member variable 'MaxAMSDUSize' to 'max_amsdu_size', this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ie

[PATCH 14/21] staging:rtl8192u: Rename LSigTxopProtect - Style

en removed. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deleti

[PATCH 12/21] staging:rtl8192u: Rename PSMP - Style

change which should not impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 21/21] staging:rtl8192u: Rename ASCap - Style

on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h

[PATCH 17/21] staging:rtl8192u: Rename Rsvd2 - Style

execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h index 9066f309bac9..2b73279b45d8 100

[PATCH 08/21] staging:rtl8192u: Rename RxSTBC - Style

yle change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 09/21] staging:rtl8192u: Rename DelayBA - Style

should not impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl81

[PATCH 18/21] staging:rtl8192u: Rename MCS - Style

Rename the member 'MCS' to 'cap_mcs', since the uppercase name conflicts with the coding standard. The 'cap' has been prepended to make the variable easier to find in the code. This is a coding style change which should have no impact on runtime code execution.

[PATCH 04/21] staging:rtl8192u: Rename GreenField - Style

ich should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

s a purely coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 06/21] staging:rtl8192u: Rename ShortGI40Mhz - Style

Rename the bitfield member 'ShortGI40Mhz' to 'short_gi40_mhz', this clears the checkpatch issue with CamelCase naming. This change is a simple coding style change, which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/stagin

[PATCH 02/21] staging:rtl8192u: Rename ChlWidth - Style

Rename 'ChlWidth', member variable of the structure ht_capability_ele. This change is to clear the checkpatch issue with CamelCase naming. The bitfield's name has been changed to 'chl_width'. This is a coding style change which should have no impact on runtime code execut

[PATCH 05/21] staging:rtl8192u: Rename ShortGI20Mhz - Style

Rename the bitfield member 'ShortGI20Mhz' to 'short_gi20_mhz'. This change clears the checkpatch issue with CamelCase naming of variables. The change if purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- driv

[PATCH 00/21] staging:rtl8192u: Refactor ht_capability_ele - Style

ed in code. At a future time the structure might be stripped of these member variables, but for the moment they have been left, as I'm not sure that the size of the structure is not significant, and possibly mapped to Hardware. John Whitmore (21): staging:rtl8192u: Rename Ad

[PATCH 03/21] staging:rtl8192u: Rename MimoPwrSave - Style

Rename the bitfield name MimoPwrSave, to clear the checkpatch issue with CamelCase naming, to 'mimo_power_save'. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT

Re: [PATCH 3/4] staging:rtl8192u: Refactor member variable enabled - Style

On Wed, Aug 29, 2018 at 02:20:33PM +0300, Dan Carpenter wrote: > Like you mentioned in the 0/4 email, the right thing to do here is just > to delete all references to ->enabled. > Thank you for your response, I'll do that in a future series of patches. jwhitmore _

[PATCH 2/4] staging:rtl8192u: Add required SPDX-License-Identifier - Style

Add the required SPDX-License-Identifier to the file r8180_93cx6.h, this clears a checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8180_93cx6.h | 1 + 1 file changed, 1 insertion

[PATCH 4/4] staging:rtl8192u: Rename member pDot11dInfo - Style

Rename 'pDot11dInfo', this member variable of the structure ieee80211_device causes a checkpatch issue, CamelCase naming. The member has been renamed 'dot11d_info' to clear this issue. This is a coding style change which should have no impact on runtime code execution.

[PATCH 1/4] staging:rtl8192u: Remove unused definitions - Style

Remove unused definitions from the file r8180_93cx6.h. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8180_93cx6.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers

[PATCH 3/4] staging:rtl8192u: Refactor member variable enabled - Style

it has been renamed from 'enabled' to 'dot11d_enabled'. These are purely coding style changes which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8192u/ieee80211/dot

[PATCH 0/4] staging:rtl8192u: Style and a question?

th a memcopy or a memset, but if it is being set I've missed it completely. There may be a kernel specific mechanism which I'm not yet familiar with? In my ignorance I'd be tempted to remove all code which relies on the variable being True, but then that function dot11d_update_country_ie

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > Remove a number of unused constant definitions. > > > > This is a coding style change which should have no impact on runtime > > code execut

[PATCH 2/6] staging:rtl8192u: Rename function PHY_RF8256_Config() - Style

Rename the function PHY_RF8256_Config() to phy_rf8256_config(). This change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8190_rtl8256.c

[PATCH 3/6] staging:rtl8192u: Refactor phy_RF8256_Config_ParaFile() - Style

, (r8190_rtl8256.h). These changes are purely coding style in nature and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8190_rtl8256.c | 11 --- drivers/staging/rtl8192u/r8190_rtl8256.h | 1 - 2 files changed, 8 insertions(+), 4 deletions

[PATCH 4/6] staging:rtl8192u: Rename PHY_SetRF8256CCKTxPower() - Style

Rename the function PHY_SetRF8256CCKTxPower() to phy_set_rf8256_cck_tx_power(), to clear the checkpatch issue with CamelCase naming. This is a purely coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 6/6] staging:rtl8192u: Add SPDX-License-Identifier tag - Style

Add the missing SPDX-License-Identifier tag to clear the checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8190_rtl8256.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

[PATCH 5/6] staging:rtl8192u: Rename PHY_SetRF8256OFDMTxPower() - Style

Rename function PHY_SetRF8256OFDMTxPower() to phy_set_rf8256_ofdm_tx_power(), to clear the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8190_rtl8256.c | 2

[PATCH 0/6] staging:rtl8192u: r8190_rtl8256.h - Style changes

This is a simple checkpatch cleanup of the file r8190_rtl8256.h, mostly to clear CamelCase naming problems. The directory contains a copying file which suggests GPL2.0 so that has been added as the missing SPDX-License-Identifier tag. John Whitmore (6): staging:rtl8192u: Rename

[PATCH 1/6] staging:rtl8192u: Rename PHY_SetRF8256Bandwidth() - Style

declaration in r8190_rtl8256.h to truncate the line length to the checkpatch limit. These changes are simple coding style changes which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8190_rtl8256.c | 8 drivers/staging/rtl8192u

[PATCH 20/21] staging:rtl8192u: Rename EEPROM_Customer_ID - Style

Rename the constant EEPROM_Customer_ID to EEPROM_CUSTOMER_ID, this change clears the checkpatch issue with CamelCase naming. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U_core.c | 2

[PATCH 21/21] staging:rtl8192u: Rename EEPROM_ChannelPlan - Style

Rename the constant EEPROM_ChannelPlan to EEPROM_CHANNEL_PLAN, this clears the checkpatch issue with CamelCase naming. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U_core.c | 2

[PATCH 19/21] staging:rtl8192u: Rename EEPROM_Default_TxPower - Style

rename the constant EEPROM_Default_TxPower to EEPROM_DEFAULT_TX_POWER, this clears the checkpatch issue with CamelCase issue. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U_core.c | 2

  1   2   3   4   5   6   7   >