[PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- v1- First attempt: removed comparison to true. v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed in v1. v3- Corrected the 'odd&

[PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- v1: Initial attempt. v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable' Also considered clearing 'CHECK: Logical continuation

[PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b

[PATCH] staging: rtl8712/: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone CHECK: Comparison to NULL should be written "!oldest" Signed-off-by: John Oldman --- drivers/staging/rtl8712/rtl871x_mlme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[PATCH] staging: rtl8723bs: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 70 ++--- 1 file changed, 32 insertions(+), 38 deletions

[PATCH] staging: rtl8192u: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192u/r8192U_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging

[PATCH] staging: rtl8192e: Using comparison to false is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers

[PATCH] staging: rtl8192e: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers

[PATCH] staging: rtl8192e: Using comparison to true is error prone

clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH] staging: rtl8192e: Using comparison to true is error prone

fix below issue reported by checkpatch.pl: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH] staging: rtl8192u: Using comparison to true is error prone

fix below issue reported by checkpatch: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] staging: rtl8723bs: Using comparison to true is error prone

fix below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH V2] Staging: rtl8723bs: os_de: if-else coding style issue

Coding style issues: This patch clears the checkpatch.pl "braces {} are not necessary for single statement blocks" and "else_should_follow_close_brace" warnings. Signed-off-by: John Oldman --- v1: First attempt v2: Followed The rule is that "if one side of the if else s

[PATCH] Staging: rtl8723bs: os_de: if-else coding style issue

Coding style issues: This patch clears the checkpatch.pl "braces {} are not necessary for single statement blocks" and "else_should_follow_close_brace" warnings. Signed-off-by: John Oldman --- v1: First attempt v2: Followed The rule is that "if one side of the if else s

[PATCH] Staging: rtl8723bs: os_de: if-else coding style issues

Coding style issues: This patch clears the checkpatch.pl "braces {} are not necessary for single statement blocks" and "else_should_follow_close_brace" warnings." Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 49 +++-- 1 fi

[PATCH V4] staging: vc04_services: Block comment alignment

Coding style issue reported by checkpatch.pl This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. Also cleared /** and blank line. Signed-off-by: John Oldman --- v1: Initial attempt. v2: Resubmitted with shorter comment line, as suggested

Re: [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment

yea I agree, will re-submit... Cheers john On Wed, 13 May 2020 at 12:58, Greg KH wrote: > > On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote: > > Coding style issue > > This patch clears the checkpatch.pl "Block comments should align the * on > > each

[PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment

Coding style issue This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. Signed-off-by: John Oldman --- v1: Initial attempt. v2: Resubmitted with shorter comment line, as suggested by Greg KH. v3: Resubmitted with descriptiuon text moved into t

Re: [PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment

Thanks for the feedback Greg. Will resubmit the patch as you suggest. Thanks john On Sun, 10 May 2020 at 07:55, Greg KH wrote: > > On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote: > > Coding style issue > > > > Signed-off-by: John Oldman > > --- &

[PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment

Coding style issue Signed-off-by: John Oldman --- v1: Initial attempt. V2: Resubmitted with shorter comment line, as suggested by Greg KH. This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. .../interface/vchiq_arm/vchiq_connected.

Re: [PATCH] staging: vc04_services: interface: vchiq_arm: vchiq_connected.c: Block comments should align the * on each line

Hi Greg Yea, thanks for the feedback. Will fix and resend... John On Sat, 9 May 2020 at 18:11, Greg KH wrote: > > On Sat, May 09, 2020 at 02:07:14PM +0100, John Oldman wrote: > > Coding style issue > > Your subject line needs to be much shorter, don't you think? >

[PATCH] staging: vc04_services: interface: vchiq_arm: vchiq_connected.c: Block comments should align the * on each line

Coding style issue Signed-off-by: John Oldman --- .../interface/vchiq_arm/vchiq_connected.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services

[PATCH] staging: media: usbvision: usbvision-core Correct spelling

Correct spelling in comment Signed-off-by: John Oldman --- drivers/staging/media/usbvision/usbvision-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/usbvision/usbvision-core.c b/drivers/staging/media/usbvision/usbvision-core.c index f05a5c84dc18

Re: [PATCH] Staging: mt7621-dma: mtk-hsdma.c: Fix Missing a blank line after declarations

KH wrote: > > On Sun, Apr 26, 2020 at 05:13:19PM +0100, John Oldman wrote: > > Fixed coding style issue > > No you didn't :) > > > > > Signed-off-by: John Oldman > > --- > > drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + > > 1 file changed, 1

[PATCH-3] staging: rts5208: rtsx: Use balanced braces for if/else if blocks

Coding style issues Signed-off-by: John Oldman --- v1: Initial attempt v2: Do more blocks v3: Single patch drivers/staging/rts5208/rtsx.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c

[PATCH 1/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue

Fix coding style issue Signed-off-by: John Oldman --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index be0053c795b7..ca836ca2ee81 100644 --- a/drivers/staging/rts5208

[PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements

Make a better job of fixing coding style issues, this time fixing all blocks as per Joe Perches' comment. Signed-off-by: John Oldman --- drivers/staging/rts5208/rtsx.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/dr

[PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue

Make a better job of fixing coding style issues, this time fixing all blocks as per Joe Perches' comment. Signed-off-by: John Oldman --- drivers/staging/rts5208/rtsx.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/dr

[PATCH 1/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue

Fix coding stype issue Signed-off-by: John Oldman --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index be0053c795b7..ca836ca2ee81 100644 --- a/drivers/staging/rts5208

[PATCH] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue

Fix coding style issue Signed-off-by: John Oldman --- drivers/staging/rts5208/rtsx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index be0053c795b7..ca836ca2ee81 100644 --- a/drivers/staging/rts5208

[PATCH] Staging: mt7621-dma: mtk-hsdma.c: Fix Missing a blank line after declarations

Fixed coding style issue Signed-off-by: John Oldman --- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index 14592ed9ce98..dd35d0bce6ca 100644 --- a/drivers/staging