Re: [PATCH] mips: ralink: allow to choose function which belongs with multiple groups

2019-04-01 Thread John Crispin
On 31/03/2019 09:31, NOGUCHI Hiroshi wrote: This allows the signals which can be assigned from multiple GPIO pins to be really assigned as expected. That one case is "refclk" signal in MT76x8. It was forcibily assigned to the pin matched by signal name at first. Eventually it always appears as G

Re: [PATCH v2] staging: mt7621-spi: drop support for SPI mode 1/2/3

2018-12-06 Thread John Crispin
since they are broken. Also drop RT2880_SPI_MODE_BITS macro because we now have only SPI_LSB_FIRST implemented and the mode_bits is so short that we don't need a macro there. Signed-off-by: Chuanhong Guo Acked-by: John Crispin --- Changes since v1: drop unspoorted modes from mode

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread John Crispin
forward you guys all the Smatch warnings. -dan ] Hello John Crispin, The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC" from Mar 15, 2018, leads to the following static checker warning: drivers/staging/mt7621-mmc/sd.c:951 msdc_command_start()

Re: [bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

2018-04-05 Thread John Crispin
Hi Dan, I explained why I think this should not be merged, i do not plan to fix any issues, please send all maintenance requests towards NeilBrown. And .. it was merged it with an out dated defunct mail addr of mine.     John On 05/04/18 13:56, Dan Carpenter wrote: Hello John Crispin

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread John Crispin
On 15/03/18 21:12, NeilBrown wrote: On Thu, Mar 15 2018, John Crispin wrote: On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread John Crispin
On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have commit message and those are required and some of the commit messages are just