Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl

2019-04-16 Thread Jiri Kosina
t; drivers/hid/usbhid/hiddev.c | 11 +---- For hiddev.c: Reviewed-by: Jiri Kosina -- Jiri Kosina SUSE Labs ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] HID: hyperv: pr_err() strings should end with newlines

2017-10-05 Thread Jiri Kosina
On Mon, 25 Sep 2017, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. > > Signed-off-by: Arvind Yadav Applied to for-4.15/hyperv. -- Jiri Kosi

Re: [PATCH v6 04/22] power_supply: Move run-time configuration to separate structure

2015-03-11 Thread Jiri Kosina
Zolnierkiewicz > Acked-by: Pavel Machek > > [for the nvec part] > Reviewed-by: Marc Dietrich > > [for drivers/platform/x86/compal-laptop.c] > Reviewed-by: Darren Hart Reviewed-by: Jiri Kosina for changes in drivers/hid/* -- Jiri Kosina SUSE Labs

RE: [PATCH 3/3 v2] hyperv: hid-hyperv.c: match wait_for_completion_timeout return type

2015-01-26 Thread Jiri Kosina
ease make sure that next time you format the changelog properly (whatever goes after '---' is normally ignored). -- Jiri Kosina SUSE Labs ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] HID: hyperv: register as a wakeup source

2014-08-04 Thread Jiri Kosina
ic int mousevsc_remove(struct hv_device *dev) > { > struct mousevsc_dev *input_dev = hv_get_drvdata(dev); > > + device_init_wakeup(&dev->device, false); > vmbus_close(dev->channel); > hid_hw_stop(input_dev->hid_device); > hid_destroy_device(input_dev->

Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

2014-03-28 Thread Jiri Kosina
ation. > Make the corresponding API in hid-core mandatory too, which removes the > need to test against it in some various places. > > Signed-off-by: Benjamin Tissoires > Reviewed-by: David Herrmann > Signed-off-by: Jiri Kosina > > Made .raw_request

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-19 Thread Jiri Kosina
On Thu, 19 Dec 2013, David Herrmann wrote: > As this thread doesn't really contain any oops message nor the exact > driver name (except mentioning hyperv and magicmouse), FWIW I recall the oopses being present somewhere in the ubuntu bug tracker, referenced in this thread. Thanks

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-19 Thread Jiri Kosina
Isn't "report->id" already covered by "if (report_enum->numbered)" > above? The test for "id > 0" won't work here as in this case > "report_enum->numbered" must already be set to true by the hid-desc > parser, doesn't it? Rig

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-16 Thread Jiri Kosina
On Fri, 27 Sep 2013, Joseph Salisbury wrote: > >> commit b1a1442a23776756b254b69786848a94d92445ba > >> Author: Jiri Kosina > >> Date: Mon Jun 3 11:27:48 2013 +0200 > >> > >> HID: core: fix reporting of raw events > >> > >> Reve

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-30 Thread Jiri Kosina
ouse_raw_event(struct hid_device *hdev, } input_sync(input); - return 1; + return 0; } static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hdev) -- Jiri Kosina SUSE Labs ___ devel m

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-27 Thread Jiri Kosina
On Wed, 25 Sep 2013, Joseph Salisbury wrote: > After further testing reverting the following commit does in fact > resolve the bug: > > commit b1a1442a23776756b254b69786848a94d92445ba > Author: Jiri Kosina > Date: Mon Jun 3 11:27:48 2013 +0200 > > HID: core: fix

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-24 Thread Jiri Kosina
27;t > > immediately see how that is possible. > > > > regards, > > dan carpenter > > Thanks for the details. We'll continue the bisect and let you know how > it goes. Did this please yield any useful result? Thanks, -- Jiri Kosina SUSE Labs ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel