The i2c-dev module is for access to I2C buses from user-space.
Kernel drivers do not care about its presence.
Signed-off-by: Jean Delvare
Cc: Matt Sickler
Cc: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c |1 -
1 file changed, 1 deletion(-)
--- linux-5.2-rc7.orig
maintained. If
it is deemed not worth the maintenance effort then it should be
deleted. I don't care either way.
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
MEDIA_CEC is no longer a tristate option, so the user can't actually
choose M. Whether the code is built-in or built as a module is
decided somewhere else.
Signed-off-by: Jean Delvare
Fixes: 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems")
Cc: Hans Verkuil
Cc: Ar
r they are correct and you should not touch them.
>
> Do you find such changes worthwhile (without touching also any surrounding
> source code)?
You keep asking more and more from me. May I remind you this is your
"project" in the first place, not mine? If you have no idea what
ernel/2106190
Personally I see no value in such statistics. Either labels are wrong
(either wrong indentation or wrong name) and should be fixed, or they
are correct and you should not touch them. Whether the same label name
is used somewhere else is irrelevant. Labels are local
lustre: Fix a jump label position in osc_get_info()
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c71d264543f759fea147734cb63de36397817534
> https://lkml.org/lkml/2015/12/21/401
Intending labels with a tab is wrong, so fixing it is welcome. I'd turn
the tab
out jump label renaming?
Renaming from "out0:", "out1:" etc to something meaningful, yes. Did
you have anything else in mind?
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
the
documentation, which should be fixed. One space before label is the way
to go.
> > Quoting Jean Delvare:
I'm honored :)
> > "> It is generally accepted to indent labels with a single space. This
> > > avoids breaking the -p option of diff."
>
> W
as aligned.
As the driver maintainer, I am fine with both unaligned or tab-aligned.
Space-aligned as I did originally was not a good idea, I admit.
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
atters
that they are meaningful. As much as possible you should pass error
codes from the lower layers. parport_claim_or_block() and
i2c_bit_add_bus() return proper error codes so you should record and
transmit them. Only parport_register_device() does not, so you have to
craft one and -ENODEV seems appropriate to me.
Note: I can test this driver.
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
"if UNISYSSPAR" block.
Signed-off-by: Jean Delvare
Cc: Benjamin Romer
Cc: David Kershner
Cc: Greg Kroah-Hartman
---
This is an humble proposal if you like it. I don't use the driver
myself, I don't even know what it is for ;-)
I am also wondering if all these o
gspca_sonixb
driver now, so that it gets sufficient testing before the sn9c102
driver is finally phased out.
Signed-off-by: Jean Delvare
Cc: Hans de Goede
Cc: Mauro Carvalho Chehab
Cc: Luca Risolia
Cc: Greg Kroah-Hartman
---
I consider this a bug fix, I believe it should go upstream ASAP
12 matches
Mail list logo
