Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

Hi , I have updated the patch --subject-prefix="PATCH v3" and made the commit as per your suggestion , i don't know why does the script doesn't update my changes,will try to sort out the issue , sorry for the inconvenience. Regards, Jaya Durga On Mon, Jul 9, 2018 at 6:26 PM,

[PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

From: root CHECK: Macro argument reuse 'gdm' - possible side-effects? convert GDM_TTY_READY to gdm_tty_ready static function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/gdm724x/gdm_tty.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

From: root CHECK: Macro argument reuse 'gdm' - possible side-effects? convert GDM_TTY_READY to gdm_tty_ready static function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/gdm724x/gdm_tty.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

From: root CHECK: Macro argument reuse 'gdm' - possible side-effects? convert GDM_TTY_READY to gdm_tty_ready static function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/gdm724x/gdm_tty.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

From: root CHECK: Macro argument reuse 'gdm' - possible side-effects? convert GDM_TTY_READY to gdm_tty_ready static function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/gdm724x/gdm_tty.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; Signed-off-by: Jaya Durga --- drivers/staging/speakup/speakup_keypc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c

[PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

CHECK: Macro argument reuse 'addr' - possible side-effects? convert AD7280A_DEVADDR to ad7280a_devaddr static function to fix checkpath check v3: small style changes Signed-off-by: Jaya Durga --- drivers/staging/iio/adc/ad7280a.c | 21 + 1 file changed, 13 insert

[PATCH v3 2/3] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission

Replace symbolic permissions with their octect representation to fix checkpatch warnings. Signed-off-by: Jaya Durga --- drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b

[PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

CHECK: Macro argument reuse 'addr' - possible side-effects? convert AD7280A_DEVADDR to ad7280a_devaddr static function to fix checkpath check v3: small style changes Signed-off-by: Jaya Durga --- drivers/staging/iio/adc/ad7280a.c | 21 + 1 file changed, 13 insert

[PATCH v2 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

CHECK: Macro argument reuse 'addr' - possible side-effects? convert AD7280A_DEVADDR to ad7280a_devaddr static function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/iio/adc/ad7280a.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

[PATCH 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

CHECK: Macro argument reuse 'addr' - possible side-effects? convert AD7280A_DEVADDR to inline function to fix checkpath check Signed-off-by: Jaya Durga --- drivers/staging/iio/adc/ad7280a.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission

Replace symbolic permissions with their octect representation to fix checkpatch warnings. Signed-off-by: Jaya Durga --- drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b

[PATCH] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; Signed-off-by: Jaya Durga --- drivers/staging/speakup/speakup_keypc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c

[PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro

Replace all instances of (1 << 27) with BIT(27) to fix checkpatch check messages Signed-off-by: Jaya Durga --- drivers/staging/lustre/lustre/include/lustre_compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_compa

[PATCH 7/7] Staging: rtl8712 : rtl871x_io.c:fix coding style of kmalloc usage

CHECK: multiple assignments should be avoided CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...) over kmalloc(sizeof(struct intf_priv)...) Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/rtl871x_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong

Fix checkpatch.pl issue WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: Jaya Durga --- drivers/staging/wlan-ng/hfa384x.

[PATCH 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong

Fix checkpatch.pl issue WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst Signed-off-by: Jaya Durga --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b

[PATCH 5/5] Staging: android: ion_cma_heap.c: fix coding style of kmalloc usage

This patch fixes coding style of kmalloc usage found by checkpatch.pl CHECK: Prefer kmalloc(sizeof(*table)...) over kmalloc(sizeof(struct sg_table)...) Signed-off-by: Jaya Durga --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding style issue

hop_set DwellTime to dwell_time Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 7 --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 21 ++--- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 8 drivers/staging/rtl8712

[PATCH 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding

hop_set DwellTime to dwell_time Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 7 --- drivers/staging/rtl8712/osdep_intf.h | 5 - drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 21 ++--- drivers/staging/rtl8712

[PATCH 4/4] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' may be better as '(x)' to avoid precedence issues. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/osdep_intf.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/s

[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH 3/3] Staging: rtl8712 : wifi.h: Fixed Macro argument reuse

CHECK: Macro argument reuse 'pframe' - possible side-effects? Convert get_tofr_ds macro to inline functions to fix checkpatch check Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/wifi.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.Consider using octal permissions '0644'. Signed-off-by: Jaya Durga --6 --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

From: Jaya Durga Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' may be better as '(x)' to avoid precedence issues. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/osdep_intf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH] Staging: wlan-ng: hfa384x_usb: Fixed sparse warning cast to restricted __le16

when building with make C=1 CF=-D__CHECK_ENDIAN__ drivers/staging/wlan-ng/hfa384x_usb.c:3383:36: warning: cast to restricted __le16 fixed by using the le16_to_cpus function. Signed-off-by: Jaya Durga --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning

warning: cast to restricted __le16 Signed-off-by: Jaya Durga --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index a812e55..0e95e45 100644 --- a/drivers

[PATCH 11/11] Staging: rtl8712: ieee80211: fixed coding style issue

Fixed WARNING: line over 80 characters Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 97ef063..b823656 100644 --- a/drivers

[PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

Fixed WARNING: line over 80 characters Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 6e673c1..97ef063 100644 --- a/drivers

[PATCH 7/9] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Renamed IEs to ie_s Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- drivers/staging/rtl8712/rtl871x_cmd.c | 20 ++-- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 drivers/staging

[PATCH 9/9] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Renamed Ssid to ssid Renamed Ssid_Length to ssid_length Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 4 ++-- drivers/staging/rtl8712/os_intfs.c| 4 ++-- drivers/staging/rtl8712/rtl871x_cmd.c | 8 +++ drivers

[PATCH 8/9] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Renamed Privacy to privacy Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c| 2 +- drivers/staging/rtl8712/rtl871x_mlme.c | 8 drivers/staging/rtl8712/wlan_bssdef.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 6/6] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Renamed cap_Privacy to cap_privacy Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- drivers/staging/rtl8712/wifi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers

[PATCH 5/5] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Renamed cap_ShortPremble to cap_short_premble Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- drivers/staging/rtl8712/wifi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b

[PATCH 3/4] Staging: rtl8712: ieee80211: fixed camelcase coding style

-> fh_config #HopPattern -> hop_pattern #HopSet -> hop_set #DwellTime -> dwell_time Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 7 --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 25 +-

[PATCH 4/4] Staging: rtl8712: ieee80211:fixed warning line over 80 characters coding style issue

fixed warning line over 80 characters coding style issue Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 42cb46c..a7152df

[PATCH 3/3] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 7 --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 25 + drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 9 - drivers/staging/rtl8712/rtl871x_mlme.c

[PATCH 2/2] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Fixed coding style issue Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 512bf16..66d9daf 100644 --- a/drivers

[PATCH] Staging: rtl8712: ieee80211: fixed brace coding style issue

Fixed coding style issue Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d84da2b..512bf16 100644 --- a/drivers/staging/rtl8712