Re: [PATCH] staging: skein: move macros into header file

2017-07-28 Thread Jason Cooper
n/skein_block.c | 323 > > drivers/staging/skein/skein_block.h | 323 > > 2 files changed, 323 insertions(+), 323 deletions(-) Acked-by: Jason Cooper thx, Jason. ___ devel mailing

Re: [PATCH v2] staging: skein: threefish_block.c Remove blank lines

2016-11-20 Thread Jason Cooper
Hi Walt, > On Nov 19, 2016, at 11:54, Walt Feasel wrote: > > Make suggested checkpatch modification for > > CHECK: Please don't use multiple blank lines > > Signed-off-by: Walt Feasel I Acked the previous version, so you should place that above your S-o-b when submitting a new version. If n

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-15 Thread Jason Cooper
Hi Walt, Please ignore our side conversation, On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to CHECK: Please don't use multiple blank lines > > Signed-off-by: Walt Feasel Acked-by: Jason Coo

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-15 Thread Jason Cooper
Hi Dan, On Mon, Nov 14, 2016 at 01:34:15PM +0300, Dan Carpenter wrote: > Please just delete the blank lines. Sure, if that's what you guys prefer. > You aren't that special like a snow flake. Someone put his grumpy pants on backwards, didn't he? thx, Jason. ___

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-12 Thread Jason Cooper
Hi Walt, Thanks for the patch, unfortunately, it's a NAK. If you search the ml archives, you'll see this has been addressed before. On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to CHECK: Please don't use multiple blank

Re: Move skein out of staging?

2016-01-25 Thread Jason Cooper
Hi Ksenija, On Mon, Jan 25, 2016 at 01:18:46PM +0100, Ksenija Stanojević wrote: > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > skein driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? Well, I haven't

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.

2015-12-08 Thread Jason Cooper
Sanidhya, *Much* better. Only two two small nits (things which Greg may be able to fix up when applying), and one comment. nit: Patch subject should be 'staging: skein: ...' On Mon, Dec 07, 2015 at 09:37:24PM -0500, Sanidhya Solanki wrote: > The original code defined macros in the source code,

Re: [PATCH] staging: skein: macros moved to header file

2015-12-04 Thread Jason Cooper
Oh hell. :) Go ahead and try to configure git send-mail, or configure Thunderbird according to Documentation/email-clients.txt. If you want, send it to me off list first to confirm it's not getting mangled like below. I think you just won the obfuscated C contest... thx, Jason. On Fri, Dec 0

Re: [PATCH] staging: skein: cleans up macros

2015-12-03 Thread Jason Cooper
Sanidhya, Sorry I haven't been very responsive, but I'm glad to see your progress here. Once you make the recommended changes, try using 'git format-patch' and 'git send-email' to pick and send the patch to the mailinglists. On Tue, Dec 01, 2015 at 08:42:28AM +, Sanidhya Solanki wrote: > Pat

Re: [PATCH] staging: skein: Adds * on subsequent lines in block comment

2015-09-21 Thread Jason Cooper
ging/skein/skein_api.h | 48 > +++ > 1 file changed, 24 insertions(+), 24 deletions(-) Acked-by: Jason Cooper > diff --git a/drivers/staging/skein/skein_api.h > b/drivers/staging/skein/skein_api.h > index 7da8b38..4cf7003 100644 > --- a/driv

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-14 Thread Jason Cooper
Shirish, Please don't toppost, I've corrected it below. On Mon, Jan 12, 2015 at 11:14:57AM -0800, shirish gajera wrote: > On Mon, Jan 12, 2015 at 6:15 AM, Jason Cooper wrote: > > On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote: > > > This patch fix

Re: [PATCH] staging: skein: Fix checkpatch warnings

2015-01-12 Thread Jason Cooper
On Mon, Jan 12, 2015 at 05:33:47PM +0300, Dan Carpenter wrote: > On Mon, Jan 12, 2015 at 09:14:18AM -0500, Jason Cooper wrote: > > Arno, > > > > On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote: > > > Remove do {} while (0) loops around single statement

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-12 Thread Jason Cooper
On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Single statement macros should not use a do {} while (0) loop > > I remove do while from the single statement macro. > > Signed-off-by: Shirish Gajera > --- > drivers/stag

Re: [PATCH] staging: skein: Fix checkpatch warnings

2015-01-12 Thread Jason Cooper
Arno, On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote: > Remove do {} while (0) loops around single statements in > skein/skein_block.c > > Signed-off-by: Arno Tiemersma > --- > drivers/staging/skein/skein_block.c | 16 > 1 file changed, 4 insertions(+), 12 delet

Re: [PATCH v2 0/2] staging: skein: Fixing various coding style problems

2014-12-30 Thread Jason Cooper
rning > > drivers/staging/skein/skein_block.c | 17 ----- > drivers/staging/skein/skein_generic.c | 1 - > 2 files changed, 4 insertions(+), 14 deletions(-) Awesome! For the whole series, Acked-by: Jason Cooper thx, Jason. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] skein: checkpatch: trailing whitespace

2014-12-30 Thread Jason Cooper
Andreas, On Tue, Dec 30, 2014 at 12:33:34AM +0100, Andreas Siegling wrote: > This small patch will fix the trailing whitespace in > drivers/staging/skein/skein_generic.c. > > After applying the patch, there will only remain the checkpatch warning: > WARNING: Single statement macros should n

Re: [PATCH] staging: skein: Fixing various coding style problems

2014-12-21 Thread Jason Cooper
Mathieu, On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote: > From: Mathieu Poirier > > Fixing errors related to the usage of do {} while (0) loop > in single statement macros, trailing semicolon in macros and > trailing whitespace. Huh. iirc, I added those do {} while

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Jason Cooper
On Wed, Dec 17, 2014 at 09:32:16AM -0800, Greg KH wrote: > On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > Enable FPGA manager for Altera socfpga. > > > > Signed-off-by: Alan Tull > > --- > > v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_S

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Jason Cooper
On Sun, Nov 09, 2014 at 07:51:36PM +0100, Niklas Svensson wrote: > > On 11/08/2014 08:56 PM, Jason Cooper wrote: > > On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: > >> drivers/staging/skein/skein_generic.c:30:5: warning: symbol > >> 'skein2

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-08 Thread Jason Cooper
On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: > drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' > was not declared. Should it be static? > drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' > was not declared. Should it b

Re: [PATCH v3 1/1] staging: skein: Removes skein_debug include

2014-10-30 Thread Jason Cooper
--- > drivers/staging/skein/skein_base.h | 17 - > drivers/staging/skein/skein_block.c | 51 > + > 3 files changed, 1 insertion(+), 85 deletions(-) Well done, Eric. Reviewed-by: Jason Cooper thx, Jason. ___

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

2014-10-29 Thread Jason Cooper
Mikael, On Wed, Oct 29, 2014 at 05:55:34PM +0100, Mikael Svantesson wrote: > Signed-off-by: Mikael Svantesson > --- > drivers/staging/skein/skein_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jason Cooper For future patches, please remember to add the

Re: [PATCH v2 1/1] staging: skein: Removes skein_debug include

2014-10-29 Thread Jason Cooper
+= SKEIN_256_BLOCK_BYTES; > > /* run the rounds */ Fix that up and please add my: Reviewed-by: Jason Cooper to the next version (below your Signed-off-by:). thx, Jason. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

2014-10-28 Thread Jason Cooper
On Tue, Oct 28, 2014 at 09:04:51AM -0400, Jonathan Corbet wrote: > On Fri, 14 Feb 2014 12:30:01 +0300 > Dan Carpenter wrote: > > > -If this patch fixes a problem reported by somebody else, consider adding a > > -Reported-by: tag to credit the reporter for their contribution. Please > > -note tha

Re: [PATCH v6 0/7] staging: skein: CryptoAPI and Module Support

2014-10-27 Thread Jason Cooper
Module Support > staging: skein: Inlines rotl_64 > staging: skein: Removes unneeded #define For patches 1 through 6, Reviewed-by: Jason Cooper We'll keep working on #7, but feel free to take the first six when you get a moment Greg. thx, Jason. > staging: skein: Removes skein_de

Re: [PATCH v6 7/7] staging: skein: Removes skein_debug include

2014-10-27 Thread Jason Cooper
On Fri, Oct 24, 2014 at 05:34:56PM -0500, Eric Rost wrote: > Removes skein_debug.h include since skein_debug.h is nonexistent. > > Signed-off-by: Eric Rost > --- > drivers/staging/skein/skein_base.h | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/staging

Re: [PATCH v5 3/7] staging: skein: Adds CryptoAPI Support

2014-10-24 Thread Jason Cooper
Eric, We're almost there... :) On Fri, Oct 24, 2014 at 06:55:33AM -0500, Eric Rost wrote: > Adds CryptoAPI support to the Skein Hashing Algorithm driver. > > Signed-off-by: Eric Rost > --- > drivers/staging/skein/Makefile| 3 +- > drivers/staging/skein/skein_generic.c | 191 > ++

Re: [PATCH v5 2/7] staging: skein: Renames skein to skein_base

2014-10-24 Thread Jason Cooper
On Fri, Oct 24, 2014 at 06:55:16AM -0500, Eric Rost wrote: > Renames skein.c to skein_base.c and skein.h to skein_base.h It's worth a mention in here that this is in preparation for skein.ko. > Signed-off-by: Eric Rost > --- > drivers/staging/skein/Makefile| 2 +- > drivers/staging/sk

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Thu, Oct 23, 2014 at 03:28:45PM +0300, Dan Carpenter wrote: > On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: > > Adds crypto API support for the skein module. Also collapses the > > threefish module into the skein module. > > Why is this in staging anyway? It seems very small and n

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: > Adds crypto API support for the skein module. Also collapses the > threefish module into the skein module. > > Signed-off-by: Eric Rost > --- > drivers/staging/skein/Kconfig | 22 +-- > drivers/staging/skein/Makefile

Re: [PATCH v2] staging: skein: Loadable Module Support

2014-10-22 Thread Jason Cooper
On Wed, Oct 22, 2014 at 10:54:26AM -0500, Eric Rost wrote: > On Wed, 2014-10-22 at 11:10 -0400, Jason Cooper wrote: > > At some point, Eric Rost wrote: ... > > > diff --git a/drivers/staging/skein/Makefile > > > b/drivers/staging/skein/Makefile > > > index

Re: [PATCH v2] staging: skein: Loadable Module Support

2014-10-22 Thread Jason Cooper
Eric, Awesome! You must have been reading my TODO list :) On Tue, Oct 21, 2014 at 09:44:27AM -0500, Eric Rost wrote: > Adds loadable module support for Skein256, Skein512, and Skein1024 Hash > Algorithms. This description is accurate, but incomplete. You're also integrating skein into the cryp

Re: [PATCH] staging: skein: Fixed Conditional white space problems

2014-09-29 Thread Jason Cooper
Eric, On Mon, Sep 29, 2014 at 07:40:11PM -0500, Eric Rost wrote: > > >I'll be looking to see that no object > > code has changed (./scripts/objdiff) across your patch series. > > Hmm... I'm thinking of digging into it, but I'm not sure the #if's can > be gotten rid of sans object code changes, si

Re: [PATCH] Fixed Conditional white space problems

2014-09-28 Thread Jason Cooper
ght look like: > staging: skein: fixed conditional... > > Care to fix that up and resend? With Greg's comments addressed, Acked-by: Jason Cooper thx, Jason. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: skein: Fixed Conditional white space problems

2014-09-28 Thread Jason Cooper
On Sun, Sep 28, 2014 at 06:14:45PM -0400, Greg KH wrote: > How about working on getting rid of the #if crap in this driver, that > will fix up this { } mess automatically. Yes, I commented on that earlier, it's a rather big job and may not be appropriate for a beginner. Eric, if you'd like to tac

Re: Eudyptula Challenge (Task 10)

2014-07-28 Thread Jason Cooper
On Mon, Jul 28, 2014 at 05:53:19AM -0700, Christoph Hellwig wrote: > Can you folks please stop this challenge Bullshit? More checkpatch > fixes is not something we'll need at all. Greg and Dan have previously said that the staging tree is a good place for newcomers to submit checkpatch cleanup pa

Re: [PATCH] staging: skein: fix sparse warning for static arrays

2014-06-02 Thread Jason Cooper
c? > skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. > Should it be static? > > by declaring the initialization vectors in question as static. The header > skein_iv.h is only included by skein.c > > Signed-off-by: James A Shackleford >

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-22 Thread Jason Cooper
On Thu, May 22, 2014 at 10:52:06AM -0600, Jake Edge wrote: > On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote: > > On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote: > > > On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote: > > > > > > but som

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jason Cooper
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote: > On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote: > > > Do you have any other series pending for this driver? > > No and I won't be doing anything else for the next couple of days -- > some darn w

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jason Cooper
ting all of the threefish block functions in one file, like the > skein block functions are all in one file, made sense. Fine by me. For the whole series: Acked-by: Jason Cooper Thanks for the help! Do you have any other series pending for this driver? I suspect Anton does and I'd lik

Re: [PATCH v2 00/06] staging: crypto: skein: fixing style issues

2014-05-19 Thread Jason Cooper
Dan, On Mon, May 19, 2014 at 11:53:21AM +0300, Dan Carpenter wrote: > Was there really a v1 version of this patchset because I don't see it in > my inbox? There was. Anton is doing this as part of the Eudyptula Challenge [1], and he sent the first version to me offlist. I helped him with some o

Re: [PATCH v2 06/06] staging: crypto: skein: rename files

2014-05-19 Thread Jason Cooper
On Mon, May 19, 2014 at 07:29:26AM -0600, Jake Edge wrote: > On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote: > > > rename drivers/staging/skein/{skeinBlockNo3F.c => > > skein_block_no_3f.c} (99%) > > fwiw, this file (skeinBlockNo3F.c) seems to be unused ... it kind of looks > like a tempor

Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

2014-05-19 Thread Jason Cooper
On Mon, May 19, 2014 at 12:08:39PM +0300, Dan Carpenter wrote: > On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote: > > +/* ignore all asserts, for performance */ > > +#define skein_assert_ret(x, ret_code) > > +#define skein_assert(x) > > Not related to this patch, but defining away ass

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jason Cooper
On Sun, May 18, 2014 at 05:04:50PM -0600, Jake Edge wrote: > On Sun, 18 May 2014 18:52:31 -0400 Jason Cooper wrote: > > > Jake, would you mind dropping this patch and perhaps assisting me with > > reviewing Anton's series? I'll have him resend it as-is and we ca

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jason Cooper
Jake, Anton, On Sun, May 18, 2014 at 12:56:15PM -0600, Jake Edge wrote: > > Clean up file names and locations. Get rid of include/ directory and move > those up to the top-level. Rename files to get rid of upper case. Remove > skeinBlockNo3F.c as it was unused (temporary file or something?). >

[PATCH V3 02/21] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since V2:

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
On Tue, Mar 18, 2014 at 02:28:20PM +, Greg KH wrote: > On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: > > On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > > > On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: > > > > These ar

[PATCH V2 18/21] staging: crypto: skein: remove externs from .c files

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a

[PATCH V2 21/21] staging: crypto: skein: add TODO file

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null

[PATCH V2 20/21] staging: crypto: skein: remove unnecessary line continuation

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c

[PATCH V2 17/21] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a

[PATCH V2 19/21] staging: crypto: skein: remove braces from single-statement block

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b

[PATCH V2 16/21] staging: crypto: skein: fix brace placement errors

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff

[PATCH V2 06/21] staging: crypto: skein: remove unneeded typedefs

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein

[PATCH V2 09/21] staging: crypto: skein: fixup pointer whitespace

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18

[PATCH V2 02/21] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since RFC:

[PATCH V2 15/21] staging: crypto: skein: fix do/while brace formatting

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein

[PATCH V2 08/21] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18

[PATCH V2 07/21] staging: crypto: skein: remove all typedef {struct, enum}

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42

[PATCH V2 13/21] staging: crypto: skein: remove trailing whitespace

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c

[PATCH V2 04/21] staging: crypto: skein: remove skein_port.h

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644

[PATCH V2 03/21] staging: crypto: skein: remove brg_*.h includes

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions

[PATCH V2 00/21] staging: add skein/threefish crypto algos

2014-03-23 Thread Jason Cooper
n particular, I really don't like the adhoc macro definitions, nor the camelCase. The plan is to get skein and threefish registered into the crypto API, build as modules, and then move it to crypto/. thx, Jason. Jason Cooper (21): staging: crypto: skein: import code from Skein3Fish.gi

[PATCH V2 05/21] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-18 Thread Jason Cooper
On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > On Tue, Mar 11, 2014 at 09:32:35PM +0000, Jason Cooper wrote: > > These are the minimum changes required to get the code to build > > statically in the kernel. It's necessary to do this first so that we > > can

Re: [RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-12 Thread Jason Cooper
On Tue, Mar 11, 2014 at 09:32:32PM +, Jason Cooper wrote: > To facilitate tinkering with this, One can pull from the following: > > git://git.infradead.org/users/jcooper/linux.git tags/staging-skein-3.14-rc1 > > This is based on v3.14-rc1, and is prone to rebasing based on

[RFC PATCH 17/22] staging: crypto: skein: fix brace placement errors

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff

[RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-11 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- drivers/stagi

[RFC PATCH 07/22] staging: crypto: skein: remove unneeded typedefs

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein

[RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-11 Thread Jason Cooper
on v3.14-rc1, and is prone to rebasing based on comments. thx, Jason. Jason Cooper (22): scripts: objdiff: detect object code changes between two commits staging: crypto: skein: import code from Skein3Fish.git staging: crypto: skein: allow building statically staging: crypto: skein: rem

[RFC PATCH 08/22] staging: crypto: skein: remove all typedef {struct, enum}

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42

[RFC PATCH 06/22] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include

[RFC PATCH 14/22] staging: crypto: skein: remove trailing whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c

[RFC PATCH 01/22] scripts: objdiff: detect object code changes between two commits

2014-03-11 Thread Jason Cooper
values as diff(1). This was written specifically to support adding the skein and threefish cryto drivers to the staging tree. I needed a programmatic way to confirm that commits changing >90% of the lines didn't inadvertently change the code. Signed-off-by: Jason Cooper --- scripts

[RFC PATCH 20/22] staging: crypto: skein: remove braces from single-statement block

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b

[RFC PATCH 16/22] staging: crypto: skein: fix do/while brace formatting

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein

[RFC PATCH 05/22] staging: crypto: skein: remove skein_port.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644

[RFC PATCH 19/22] staging: crypto: skein: remove externs from .c files

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a

[RFC PATCH 22/22] staging: crypto: skein: add TODO file

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null

[RFC PATCH 10/22] staging: crypto: skein: fixup pointer whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18

[RFC PATCH 18/22] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a

[RFC PATCH 04/22] staging: crypto: skein: remove brg_*.h includes

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions

[RFC PATCH 21/22] staging: crypto: skein: remove unnecessary line continuation

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c

[RFC PATCH 09/22] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18