[PATCH v2 1/7] staging/wilc1000: Introduce linux_spi_msg_init

n the callee. Thats because of the strange expected return values. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 183 -- 1 file changed, 47 insertions(+), 136 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/st

[PATCH v2 6/7] staging/wilc1000: Remove unneeded USE_SPI_DMA

After zeroing the message, the value is zero anyway and we don't have to set it explicitly. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wil

[PATCH v2 2/7] staging/wilc1000: Sanitize linux_spi_write_read

Removed unneeded newlines. Improved control flow to get rid of indents. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff

[PATCH v2 4/7] staging/wilc1000: Sanitize linux_spi_write

Removed unneeded newlines. Moved variable definitions to the top. Improved control flow to get rid of indents. Replaced while with for. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 87

[PATCH v2 0/7] staging/wilc1000: Refactor spi read and write functions

The code for sending and receiving spi data had multiple style problems, was repetative and contained errors. This series simplifies the code and fixes some of the problems. v1 to v2: Readded module.h, as MODULE_DEVICE_TABLE depends on it. Janosch Frank (7): staging/wilc1000: Introduce

[PATCH v2 3/7] staging/wilc1000: Sanitize linux_spi_read

Removed unneeded newlines. Moved variable definitions to the top. Improved control flow to get rid of indents. Replaced while with for. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 79

[PATCH v2 5/7] staging/wilc1000: Remove unneeded imports

Apart from spi.h and module.h, none of the imports are used anymore. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000/linux_wlan_spi.c index

[PATCH v2 7/7] staging/wilc1000: Remove unneeded forward declaration

linux_spi_deinit is not used from within linux_wlan_spi.c, so the declaration is useless. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000

Re: [PATCH 5/7] staging/wilc1000: Remove unneeded imports

/linux/commits/Janosch-Frank/staging-wilc1000-Refactor-spi-read-and-write-functions/20160111-022042 config: x86_64-randconfig-s0-01110305 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by

[PATCH 6/7] staging/wilc1000: Remove unneeded USE_SPI_DMA

After zeroing the message, the value is zero anyway and we don't have to set it explicitly. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wil

[PATCH 7/7] staging/wilc1000: Remove unneeded forward declaration

linux_spi_deinit is not used from within linux_wlan_spi.c, so the declaration is useless. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000

[PATCH 4/7] staging/wilc1000: Sanitize linux_spi_write

Removed unneeded newlines. Moved variable definitions to the top. Improved control flow to get rid of indents. Replaced while with for. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 87

[PATCH 1/7] staging/wilc1000: Introduce linux_spi_msg_init

n the callee. Thats because of the strange expected return values. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 183 -- 1 file changed, 47 insertions(+), 136 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/st

[PATCH 5/7] staging/wilc1000: Remove unneeded imports

The only external function is spi_sync from spi/spi.h, no external kernel variables are used. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging

[PATCH 3/7] staging/wilc1000: Sanitize linux_spi_read

Removed unneeded newlines. Moved variable definitions to the top. Improved control flow to get rid of indents. Replaced while with for. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 79

[PATCH 2/7] staging/wilc1000: Sanitize linux_spi_write_read

Removed unneeded newlines. Improved control flow to get rid of indents. Added additional error message and improved existing ones. Signed-off-by: Janosch Frank --- drivers/staging/wilc1000/linux_wlan_spi.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff

[PATCH 0/7] staging/wilc1000: Refactor spi read and write functions

The code for sending and receiving spi data had multiple style problems, was repetative and contained errors. This series simplifies the code and fixes some of the problems. Janosch Frank (7): staging/wilc1000: Introduce linux_spi_msg_init staging/wilc1000: Sanitize linux_spi_write_read