Hi Alexandre,
On Thursday 09 January 2014 14:31:22 Alexandre Belloni wrote:
> Sorry to chime in only now but it seems that this series is breaking the
> touchscreen calibration on 3.13 (and -rc7 is out so it might be too
> late).
>
> At first, I though I became a terrible clicker ;) but I found so
Hi Jonathan,
On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
> a couple of the patch descriptions say that they are untested on i.MX28.
On Monday 23 September 2013 16:36:35 Juergen Beisert wrote:
> For battery driven systems it is a very bad idea to collect the touchscreen
> data with
Hi Fabio,
On Monday 23 September 2013 17:13:03 Fabio Estevam wrote:
> On 09/23/2013 11:36 AM, Juergen Beisert wrote:
> > + lradc->clk = devm_clk_get(&pdev->dev, NULL);
> > + clk_prepare_enable(lradc->clk);
>
> clk_prepare_enable() may fail, so better check its return value.
Thanks for the com
Hi Lothar,
On Monday 23 September 2013 17:30:18 Lothar Waßmann wrote:
> > [...]
> > @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device
> > *pdev) if (IS_ERR(lradc->base))
> > return PTR_ERR(lradc->base);
> >
> > + lradc->clk = devm_clk_get(&pdev->dev, NULL);
> > +
Hi Lothar,
On Monday 23 September 2013 15:40:18 Lothar Waßmann wrote:
> Jürgen Beisert writes:
> > The i.MX28 manual says the LRADC delay unit is driven by a 2 kHz clock,
> > but does not say what kind of clock it is (or is derived from). I guess
> > now, this clock isn&#
On Monday 23 September 2013 15:24:37 Jürgen Beisert wrote:
> Hi Lothar,
>
> On Monday 23 September 2013 14:12:02 Lothar Waßmann wrote:
> > [...]
> >
> > > @Lothar: What kernel revision did you use? I had to go back to 3.9 to
> > > get a
> >
Hi Lothar,
On Monday 23 September 2013 14:12:02 Lothar Waßmann wrote:
> [...]
> > @Lothar: What kernel revision did you use? I had to go back to 3.9 to get
> > a
>
> Current linux-next (3.12-rc1).
Okay.
> > working kernel on the MX28EVK. More recent vanilla kernels stop working
> > (MMC and netw
Hi Marek,
On Monday 23 September 2013 12:36:27 Marek Vasut wrote:
> > [...]
> > I also found an MX28EVK with a touchscreen here and: yes it does not work
> > with the modified driver. But now I'm confused, because of Lothar's
> > statement about the TX28 platform.
> >
> > @Lothar: What kernel revi
Hi Marek,
On Monday 23 September 2013 09:55:58 Jürgen Beisert wrote:
> On Monday 23 September 2013 01:55:04 Marek Vasut wrote:
> > > The following series replaces the current busy loop touchscreen
> > > implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven
Hi Marek,
On Monday 23 September 2013 01:55:04 Marek Vasut wrote:
> > The following series replaces the current busy loop touchscreen
> > implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven
> > implementation.
> >
> > Since i.MX23 and i.MX28 silicon differs, the existing implementati
Hi Jonathan,
On Saturday 21 September 2013 14:42:37 Jonathan Cameron wrote:
> The device tree list has moved, so I've changed the cc.
>
> Few comments inline. Basically I'd go for longer more
> descriptive names when the abreviation isn't a really
> well known common one.
>
> Note I'm not all tha
Hi Jonathan,
On Monday 16 September 2013 17:30:32 Jonathan Cameron wrote:
> >On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> >> On 09/11/13 09:18, Juergen Beisert wrote:
> >> > For battery driven systems it is a very bad idea to collect the
> >> > touchscreen data within a kernel bu
Hi Dmitry,
On Monday 16 September 2013 17:28:46 Dmitry Torokhov wrote:
> [...]
> > > static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> > > @@ -641,6 +1056,7 @@ static void mxs_lradc_ts_unregister(struct
> > > mxs_lradc *lradc)
> > >
> > > cancel_work_sync(&lradc->ts_work);
> > >
> > >
Hi Marek,
On Monday 16 September 2013 16:23:48 Marek Vasut wrote:
> > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > > On 09/11/13 09:18, Juergen Beisert wrote:
> > > > For battery driven systems it is a very bad idea to collect the
> > > > touchscreen data within a kernel busy l
Hi Jonathan,
On Monday 16 September 2013 10:10:22 Jürgen Beisert wrote:
> [...]
> > While this driver is placed in IIO within staging at the moment, these
> > changes are definitely input related. Hence I have cc'd Dmitry and the
> > input list.
> >
> > I am
Hi Jonathan,
On Sunday 15 September 2013 18:10:18 Jonathan Cameron wrote:
> On 09/15/13 11:56, Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> >> For battery driven systems it is a very bad idea to collect the
> >> touchscreen data within a kernel busy loop.
> >>
> >> This
Hi Jonathan,
On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
> [...]
> > +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
> > +{
> > + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void mxs_lradc_reg_clear(struct mxs_lradc *l
Hi Jonathan,
On Sunday 15 September 2013 12:50:09 Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> > least for the 4 wire touchscreen.
> >
> > Note: support for the remaining LRADC channels is not tes
Hi Jonathan,
On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > For battery driven systems it is a very bad idea to collect the
> > touchscreen data within a kernel busy loop.
> >
> > This change uses the features of the hardware to delay a
On Tuesday 10 September 2013 23:21:16 Marek Vasut wrote:
> Dear Dan Carpenter,
>
> > On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> > > > This patch seems to combine two things -- register access rework AND
> > > > adjustment of the driver
On Tuesday 10 September 2013 22:54:44 Dan Carpenter wrote:
> On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> > > This patch seems to combine two things -- register access rework AND
> > > adjustment of the driver for MX23 touchscreen.
> >
> >
Hi Marek,
On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote:
> > On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
> > > > at least for the 4 wire touchscreen.
> > > >
> > > > Signed-off-by: Juergen Beisert
Hi Marek,
On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> > least for the 4 wire touchscreen.
> >
> > Signed-off-by: Juergen Beisert
> > CC: linux-arm-ker...@lists.infradead.org
> > CC: de...@driverdev.osuosl.o
On Friday 06 September 2013 14:26:11 Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 12:08:42PM +0200, Juergen Beisert wrote:
> > +static int mxs_lradc_read_ts_channel(struct mxs_lradc *lradc)
> > +{
> > + u32 reg;
> > + int val;
> > +
> > + reg = readl(lradc->base + LRADC_CTRL1);
> > +
> > +
Hi Dan,
On Thursday 05 September 2013 20:16:39 Dan Carpenter wrote:
> I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> the callers and makes the lines shorter.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/ad
Hi Dan,
On Wednesday 04 September 2013 16:27:39 Dan Carpenter wrote:
> [...]
> ACTUALLY! When I look at it now the third argument is almost always
> "set", "clear" or "toggle".
>
> So we could do:
>
> static inline void lradc_reg_set(struct mxs_lradc *lradc, u32 val,
>
Hi Dan,
On Wednesday 04 September 2013 16:36:24 Dan Carpenter wrote:
> On Wed, Sep 04, 2013 at 03:01:43PM +0200, Juergen Beisert wrote:
> > +#defineLRADC_CTRL0_MX28_PLATE_MASK \
> > + LRADC_CTRL0_MX28_YNNSW | LRADC_CTRL0_MX28_YPNSW | \
> > + LRADC_CTRL0_MX28_YPPSW | LRADC_C
Hi Marek,
On Wednesday 04 September 2013 16:06:34 Marek Vasut wrote:
> [...]
> > +# define LRADC_CTRL0_MX28_TOUCH_DETECT_ENABLE (1 << 23)
> > +# define LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE(1 << 22)
> > +# define LRADC_CTRL0_MX28_YNNSW/* YM */(1 << 21)
> > +# define LRADC_CTR
Hi Dan,
On Wednesday 04 September 2013 16:37:14 Dan Carpenter wrote:
> On Wed, Sep 04, 2013 at 03:01:46PM +0200, Juergen Beisert wrote:
> > Signed-off-by: Juergen Beisert
> > CC: linux-arm-ker...@lists.infradead.org
> > CC: de...@driverdev.osuosl.org
> > CC: Marek Vasut
> > CC: Fabio Estevam
>
29 matches
Mail list logo
