Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function

2015-01-02 Thread Insop Song
Reviewed-by: Insop Song Thank you, ISS On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote: > Remove the function bitswap() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Sign

Re: [PATCH 1/3] staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function

2014-10-27 Thread Insop Song
On Mon, Oct 27, 2014 at 02:17:38PM +0300, Dan Carpenter wrote: > On Sun, Oct 26, 2014 at 10:56:34AM -0700, Insop Song wrote: > > Devendra > > > > Since these are small changes, I want one patch set instead of three unless > > Greg says otherwise. > > > >

Re: [PATCH 1/3] staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function

2014-10-26 Thread Insop Song
Devendra Since these are small changes, I want one patch set instead of three unless Greg says otherwise. Thank you, ISS On Sat, Oct 25, 2014 at 02:01:54AM +0530, Devendra Naga wrote: > the error path is cleanup to return the correct (function call return value) > error code. > > Signed-off-by

Re: [PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

2014-10-03 Thread Insop Song
That should clean up. Thank you. Reviewed-by: Insop Song ISS On Fri, Oct 03, 2014 at 10:37:46AM -0700, Joe Perches wrote: > On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote: > > On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote: > > > This patch remove unnecessary KE

Re: [PATCH] staging: gs_fpgaboot: remove unnecessary return statements

2014-09-04 Thread Insop Song
Okay, thank you. Reviewed-by: Insop Song On Thu, Sep 04, 2014 at 10:05:36PM +0200, Michał Bartoszkiewicz wrote: > This fixes "void function return statements are not generally useful" > warnings from checkpatch.pl. > > Signed-off-by: Michał Bartoszkiewicz > --- >

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
Dan, Thank you for pointing that out. This was for reviewing, so I would put this instead, then. Reviewed-by: Insop Song Regards, ISS ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
igned-off-by: Paul Bolle Signed-off-by: Insop Song > --- > Completely untested. > > By the way, do de...@driverdev.osuosl.org and > de...@linuxdriverproject.org deliver to the same list? > > drivers/staging/gs_fpgaboot/Makefile | 2 -- > 1 file changed, 2 dele

RE: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Insop Song
update for 3.15-rc1. > > > > > > Loads of cleanup fixes, a few drivers removed, and some new ones > added. > > > > > > All have been in linux-next for a while. > > > > > >[...] > > > > > > Insop Song (1): > > >

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-21 Thread Insop Song
On Mon, Jan 20, 2014 at 10:06 AM, Greg KH wrote: > On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: >> >> >> >> On the FPGA side, there are dedicated pins for programming, and >> >> through these you cannot get meaningful information (again unless

[PATCH v5 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song --- drivers/staging/Kconfig |2 + drivers/staging/Makefile

[PATCH v5 0/1] staging: fpgaboot: Xilinx FPGA firmware download drive

2014-01-20 Thread Insop Song
Xilinx FPGA firmware download driver v5 - update based on Greg's feedback - updated README to reflect the use case of the driver Insop Song (1): staging: fpgaboot: Xilinx FPGA firmware download driver drivers/staging/Kconfig |2 + drivers/staging/Mak

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
On Mon, Jan 20, 2014 at 10:51 AM, Hartley Sweeten wrote: > I have not looked at this driver but... > > Couldn't this be done from user space using urjtag? > > http://urjtag.org/ > Thank you for letting me know urjtag. This can be useful to replace existing jtag dongles. However, the use case fo

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Insop Song
On Thu, Jan 16, 2014 at 1:41 PM, Greg KH wrote: > On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: >> >> There is no way to detect FPGA until it is programmed. >> >> This is a reason and the only reason of this driver to download the >> >> prog

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Insop Song
On Thu, Jan 16, 2014 at 8:09 AM, Greg KH wrote: > On Thu, Jan 16, 2014 at 12:56:15AM -0800, Insop Song wrote: >> On Tue, Jan 14, 2014 at 10:00 AM, Greg KH wrote: >> > On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: >> >> On Tue, Jan 14, 2014 at 1:18 AM,

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Insop Song
On Tue, Jan 14, 2014 at 10:00 AM, Greg KH wrote: > On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: >> On Tue, Jan 14, 2014 at 1:18 AM, Insop Song wrote: >> > On Mon, Jan 13, 2014 at 10:44 AM, Greg KH >> > wrote: >> >> On Sat, Jan 11, 201

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Insop Song
On Tue, Jan 14, 2014 at 1:18 AM, Insop Song wrote: > On Mon, Jan 13, 2014 at 10:44 AM, Greg KH wrote: >> On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: >>> On Sat, Jan 11, 2014 at 4:10 PM, Greg KH wrote: >>> > On Sat, Jan 11, 2014 at 03:56:48PM -080

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Insop Song
On Mon, Jan 13, 2014 at 10:44 AM, Greg KH wrote: > On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: >> On Sat, Jan 11, 2014 at 4:10 PM, Greg KH wrote: >> > On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote: >> >> On Sat, Jan 11, 2014 at

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Insop Song
On Sat, Jan 11, 2014 at 4:09 PM, Greg KH wrote: > On Sat, Jan 11, 2014 at 02:16:05PM -0800, Insop Song wrote: >> On Sat, Jan 11, 2014 at 12:51 PM, Greg KH wrote: >> > On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: >> >> This driver downloads Xilinx

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Insop Song
On Sat, Jan 11, 2014 at 4:10 PM, Greg KH wrote: > On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote: >> On Sat, Jan 11, 2014 at 1:05 PM, Greg KH wrote: >> > On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote: >> >> On Thu, Jan 09, 2014 at 11:4

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Insop Song
On Sat, Jan 11, 2014 at 1:05 PM, Greg KH wrote: > On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote: >> On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: >> > This driver downloads Xilinx FPGA firmware using gpio pins. >> > It loads Xilinx FPGA bitstrea

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Insop Song
On Sat, Jan 11, 2014 at 12:51 PM, Greg KH wrote: > On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: >> This driver downloads Xilinx FPGA firmware using gpio pins. >> It loads Xilinx FPGA bitstream format firmware image and >> program the Xilinx FPGA using Sele

[PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-09 Thread Insop Song
This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song --- drivers/staging/Kconfig |2 + drivers/staging/Makefile

[PATCH v4 0/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-09 Thread Insop Song
Xilinx FPGA firmware download driver v4 - update based on feedback - merge change into one patch Insop Song (1): staging: fpgaboot: Xilinx FPGA firmware download driver drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 + drivers/staging

Re: [PATCH v3 2/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
On Thu, Jan 9, 2014 at 7:20 AM, Greg KH wrote: > On Thu, Jan 09, 2014 at 01:36:15AM -0800, Insop Song wrote: >> --- /dev/null >> +++ b/drivers/staging/gs_fpgaboot/TODO >> @@ -0,0 +1,14 @@ >> +TODO: >> +- get bus width input instead of hardcoded bus width

RE: [PATCH v2 2/2] stagin: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 09, 2014 7:11 AM > To: Insop Song > Cc: de...@driverdev.osuosl.org > Subject: Re: [PATCH v2 2/2] stagin: fpgaboot: Driver for downloading Xilinx > FPGA image > >

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
On Thu, Jan 9, 2014 at 6:32 AM, Greg KH wrote: > On Thu, Jan 09, 2014 at 12:21:06AM -0800, Insop Song wrote: >> On Wed, Jan 8, 2014 at 10:16 PM, Greg KH wrote: >> > Why is this driver going into the staging directory? We need a TODO >> > file listing the issues that

[PATCH v3 0/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
(please ignore v2, v3 updates minor typos) Update based on Greg's feedback Driver for downloading Xilinx FPGA image V2 - Add TODO - remove EXPORT_SYMBOL - update README fie format Insop Song (2): stagin: fpgaboot: Driver for downloading Xilinx FPGA image stagin: fpgaboot: Drive

[PATCH v3 1/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
This module downloads Xilinx FPGA image using gpio pins. It loads Xilinx FPGA bitstream format image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song --- drivers/staging/Kconfig |2 + drivers/staging/Makefile |1

[PATCH v3 2/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
Review feedback, add TODO, remove EXPORT_SYMBOL, update README fie format Signed-off-by: Insop Song --- drivers/staging/gs_fpgaboot/README| 50 +++-- drivers/staging/gs_fpgaboot/TODO | 14 drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1

[PATCH v2 2/2] stagin: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
Review feedback, add TODO, remove EXPORT_SYMBOL, update README fie format Signed-off-by: Insop Song --- drivers/staging/gs_fpgaboot/README| 50 +++-- drivers/staging/gs_fpgaboot/TODO | 14 drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1

[PATCH v2 1/2] stagin: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
This module downloads Xilinx FPGA image using gpio pins. It oads Xilinx FPGA bitstream format image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song --- drivers/staging/Kconfig |2 + drivers/staging/Makefile |1

[PATCH v2 0/2] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
Update based on Greg's feedback Driver for downloading Xilinx FPGA image V2 - Add TODO - remove EXPORT_SYMBOL - update README fie format Insop Song (2): stagin: fpgaboot: Driver for downloading Xilinx FPGA image stagin: fpgaboot: Driver for downloading Xilinx FPGA image drivers/st

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Insop Song
On Wed, Jan 8, 2014 at 10:16 PM, Greg KH wrote: > > On Wed, Jan 08, 2014 at 10:00:15PM -0800, Insop Song wrote: >> This module downloads Xilinx FPGA image using gpio pins >> >> DESIGN >> -- >> * load Xilinx FPGA bitstream format[1] image

[PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-08 Thread Insop Song
* platform independent file: gs_fpgaboot.c * platform dependent file: io.c Signed-off-by: Insop Song --- drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 + drivers/staging/gs_fpgaboot/Kconfig |8 + drivers/staging/gs_fpgaboot/Makefile

[PATCH 0/1] staging: Driver for downloading Xilinx FPGA image

2014-01-08 Thread Insop Song
: -- [x] run checkpatch [x] specify where to apply the patch [x] build test using "ppc64e_defconfig" [x] running test, running code is built with 3.8.13 kernel due to target specific kernel Thank you,