Re: [PATCH v3] staging: usbip: userspace: add support for viewing imported devices

2013-12-24 Thread Ilija Hadzic
Reviewed-by: Ilija Hadzic On Tue, 24 Dec 2013, Valentina Manea wrote: As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Sample output: Imported USB devices Po

Re: [PATCH v2] staging: usbip: add support for viewing imported devices

2013-12-23 Thread Ilija Hadzic
This looks better, but there are still two minor issues: You have one trailing whtespace error. Please the scripts/checkpatch.pl script on the patch and correct the error. The title of the commit message should indicate that this is an userspace patch (this seems to be the convention that ot

Re: [PATCH] staging: usbip: add support for viewing imported devices

2013-12-23 Thread Ilija Hadzic
On Mon, 23 Dec 2013, Valentina Manea wrote: As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Yeah, I guess most people (incluing myself) have been just happy with just cat-ing the files