The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/dr
Checking the return of dev_alloc_skb as stated in the following bug:
https://bugzilla.kernel.org/show_bug.cgi?id=60411
Signed-off-by: Iker Pedrosa
Reported-by: RUC_Soft_Sec rucsoft...@gmail.com
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
file.
> > Just a suggestion.
> >
>
> Put the '|' character at the end of the line. That's the New Unwritten
> Style Guidelines. Most of the kernel does it this way and it's easier
> to read.
>
> But this could be f
Second of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index 48ed95c..999b7046 100644
--- a/drivers
Prototype of two functions added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 4 +---
drivers/staging/winbond/mto.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers
Fourth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (24):
Staging: winbond: mto: removed function declaration
Staging: winbond: mto: avoided use of extern functions
Staging: winbond: mto: deleted extern functions
Staging: winbond: phy_calibration: first of the patches
Second of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibration.c
b/drivers
Deleted declaration of external functions that weren't used on this driver.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index 22bb264..8d41eed 100644
Fifth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond
White space deleted before semicolons.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 5883d23..80b4b34 100644
--- a/drivers/staging/winbond
Seventh of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index
Third of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
The following function declarations have been removed because they aren't
implemented.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index 560c0ab..0d0f9fb 1
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 3fa1ae4..a2868f2 100644
--- a
First of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 46 ++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/winbond
Erased all the errors given by checkpatch stating trailing whitespace.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 75b7752
Sixth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
First of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Deleted an space before a tabulation.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg_s.h
b/drivers/staging/winbond/wb35reg_s.h
index dc79faa..cdbbf35 100644
--- a/drivers
The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/dr
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Fixed lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_f.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h
b/drivers/staging/winbond/wb35reg_f.h
index 95dc980..cd6710c 100644
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
the same problem please copy
the output so that I can figure out what is the problem.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
index
the same problem please copy
the output so that I can figure out what is the problem.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 54 +--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b
Erased the spaces that existed after opening some square brackets '['.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h
b/drivers/staging/winbond/wb35tx_s.h
ind
own for the next series of patches but I will wait to start them
until the previous are accepted.
--
Regards,
Iker Pedrosa
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Erased the spaces that existed after opening some square brackets '['.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h
b/drivers/staging/winbond/wb35tx_s.h
ind
Fixed lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_f.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h
b/drivers/staging/winbond/wb35reg_f.h
index 95dc980..cd6710c 100644
First of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 46 ++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/winbond
White space deleted before semicolons.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 5883d23..80b4b34 100644
--- a/drivers/staging/winbond
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index 48ed95c..999b7046 100644
--- a/drivers
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Seventh of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index
Prototype of two functions added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 4 +---
drivers/staging/winbond/mto.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Deleted an space before a tabulation.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg_s.h
b/drivers/staging/winbond/wb35reg_s.h
index dc79faa..cdbbf35 100644
--- a/drivers
The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/dr
Third of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Fifth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 3fa1ae4..c128bc9 100644
--- a
First of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Second of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Fourth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond
Sixth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 52 +--
1 file changed
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
The following function declarations have been removed because they aren't
implemented.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index 560c0ab..0d0f9fb 1
Erased all the errors given by checkpatch stating trailing whitespace.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 75b7752
Second of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibration.c
b/drivers
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (24):
Staging: winbond: mto: removed function declaration
Staging: winbond: mto: avoided use of extern functions
Staging: winbond: mto: deleted extern functions
Staging: winbond: phy_calibration: fixed some lines
Deleted declaration of external functions that weren't used on this driver.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index 22bb264..8d41eed 100644
So, what should I do? Do I send the patch via bugzilla? I'm a newbie and I
don't know that to do, what do you recommend me?
On Fri, 9 Aug 2013 15:38:13 +0300
Dan Carpenter wrote:
> On Thu, Aug 08, 2013 at 12:56:44PM +0200, Iker Pedrosa wrote:
> > Checking the return of dev_
According to Documentation/timers/timers-howto.txt it is not recommended to use
msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is
recommended to use usleep instead.
On Mon, 12 Aug 2013 12:05:10 +0200
Pavel Machek wrote:
> On Mon 2013-08-05 11:58:27, Iker Pedrosa wr
Checking the return of dev_alloc_skb as stated in the following bug:
https://bugzilla.kernel.org/show_bug.cgi?id=60401
Signed-off-by: Iker Pedrosa
---
drivers/staging/rtl8192e/rtllib_rx.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers
t; Justin P. Mattock
>
>
>
> From: Iker Pedrosa
> Sent: Monday, August 5, 2013 2:58 AM
> To: pa...@ucw.cz
> Cc: gre...@linuxfoundation.org, justinmatt...@gmail.com,
> ikerpedro...@gmail.com, mujeeb.a...@gmail.com, harsh1ku...@gmail.com,
> de...@driverdev.osuosl.
Fixed some coding style issues
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mds.c | 56 +--
1 file changed, 33 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
index faa93f0..fcc3d21
Fixed some coding style issues.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mds_f.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
index ce8be07..ce5a78c 100644
--- a/drivers/staging
Deleted an extern function that wasn't used in this driver.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mds_f.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
index ce5a78c..159b2eb 100644
--- a/drivers/st
Prototype of a function added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.h | 1 +
drivers/staging/winbond/wb35reg.c | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond
Changed sleep function from msleep to usleep according to the documentation.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg.c
b/drivers/staging/winbond/wb35reg.c
index
White space deleted before a semicolon.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg.c
b/drivers/staging/winbond/wb35reg.c
index 34a2618..1314f93 100644
--- a/drivers
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (6):
Staging: winbond: wb35reg: changed sleep function from msleep to
usleep
Staging: winbond: wb35reg: white space deleted
Staging: winbond: wb35reg: avoided use of extern function
Staging: winbond: mds: fixed
Fixed some coding style issues
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg.c
b/drivers/staging/winbond/wb35reg.c
index 9be1b3b..35d3beb
66 matches
Mail list logo