Re: [PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread Hannes Reinecke
The error handling does need to be fixed (have patches pending) > but that is interrelated with hotplug and can wait. > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 7405

Re: [PATCH 2/2] scsi: storvsc: Use the specified target ID in device lookup

2016-01-10 Thread Hannes Reinecke
e these really 32-bit values? Both the LUN and the target? Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffe

Re: [PATCH V4 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-28 Thread Hannes Reinecke
#if IS_ENABLED(CONFIG_SCSI_FC_ATTRS) + fc_release_transport(fc_transport_template); +#endif } MODULE_LICENSE("GPL"); My original question still stands: Where is the point if supporting FC devices if CONFIG_SCSI_FC_ATTRS is disabled? I would rather disable FC support comp

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-20 Thread Hannes Reinecke
, as it's not immediately clear from the patch. So: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Ime

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread Hannes Reinecke
y. Have you checked whether it actually makes a difference in the assembler output? Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH V3 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-18 Thread Hannes Reinecke
tion != VSTOR_OPERATION_COMPLETE_IO || - vstor_packet->status != 0) - return -EINVAL; - if (process_sub_channels) handle_multichannel_storage(device, max_chns); The same applies here; please make the FC support configurable both during configuration and during runtime.

Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-18 Thread Hannes Reinecke
ght want so save kernel memory wherever they can. So always attaching to the fc transport template will make them very unhappy. Alternatively you could split out FC device handling into a separate driver, but seeing the diff that's probably overkill. Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH V3 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

2015-12-18 Thread Hannes Reinecke
annes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-29 Thread Hannes Reinecke
On 08/29/2014 09:39 AM, Bart Van Assche wrote: On 08/29/14 08:19, Hannes Reinecke wrote: On 08/29/2014 04:42 AM, Mike Christie wrote: How are distros handling 0x6/0x3f/0x0e (report luns changed) when it gets passed to userspace? Is everyone kicking off a new full (add and delete) scan to

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-28 Thread Hannes Reinecke
On 08/29/2014 04:42 AM, Mike Christie wrote: On 08/27/2014 09:31 AM, Hannes Reinecke wrote: On 08/19/2014 07:54 PM, Christoph Hellwig wrote: On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: The host asks the guest to scan when a LUN is removed or added. The only way a guest

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-27 Thread Hannes Reinecke
for every HBA. But this is quite some work. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürn

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Hannes Reinecke
pliance. MSFT targets currently +* claim SPC-2 compliance while they implement post SPC-2 features. +* With this patch we can correctly handle WRITE_SAME_16 issues. +*/ + sdevice->sdev_bflags |= msft_blist_flags; + return 0; } Reviewed-by: Hannes Reinecke

Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-14 Thread Hannes Reinecke
On 07/14/2014 11:00 AM, Christoph Hellwig wrote: On Mon, Jul 14, 2014 at 10:57:53AM +0200, Hannes Reinecke wrote: Okay, that's fine by me. Should I take this as a reviewed-by tag? Yes, please do. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h..

Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-14 Thread Hannes Reinecke
On 07/14/2014 10:30 AM, Christoph Hellwig wrote: On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote: Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher than that; ie Well-known LUN won't work here. Also the SCSI stack will be using REPORT LUNS anyway

Re: [PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-13 Thread Hannes Reinecke
: set_host_byte(scmnd, DID_TARGET_FAILURE); } Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-13 Thread Hannes Reinecke
vm_srb->win8_extension.srb_flags = 0; + vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN | +SRB_FLAGS_DATA_OUT); break; } Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler

2014-07-13 Thread Hannes Reinecke
, .slave_configure = storvsc_device_configure, Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH V3 3/7] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-13 Thread Hannes Reinecke
; Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB

Re: [PATCH V3 4/7] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-13 Thread Hannes Reinecke
= VMSTOR_WIN8_MINOR; + break; } - if (dev_id->driver_data == SFC_GUID) scsi_driver.can_queue = (STORVSC_MAX_IO_REQUESTS * STORVSC_FC_MAX_TARGETS); Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reine

Re: [PATCH V3 2/7] Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the Host

2014-07-13 Thread Hannes Reinecke
= -1, /* no use setting to 0 since ll_blk_rw reset it to 1 */ Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg G

Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-13 Thread Hannes Reinecke
T LUNS deal with the actual LUNs. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread Hannes Reinecke
vsc_device_alloc, .slave_destroy =storvsc_device_destroy, Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendö