Re: [PATCH] This is my first commit

2014-05-27 Thread H. Peter Anvin
Hi Kevin, I suggest reading the file Documentation/SubmittingPatches for general guidance as how to submit patches. > +#define MAJOR_NUM 100 > +#define MAJOR_MIN 0 Fixed device numbers need to be allocated from (currently managed by Alan Cox). However, this should pro

Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread H. Peter Anvin
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: > + new_val = inb(PIC_MASTER_IMR); > + if (probe_val != new_val) { Nitpick: Linux coding style should have this as: if (new_val != probe_val) -hpa ___ devel mailing list de...@li

Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread H. Peter Anvin
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: > This patch implements the proposal put forth by H. Peter Anvin > . > > In version V1 of the patch, I had cleaned up the code based on comments from > Peter. > In version V2 of the patch, I have addressed additional comment

Re: [PATCH V1 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-11 Thread H. Peter Anvin
On 04/11/2014 05:50 PM, K. Y. Srinivasan wrote: > > + /* > + * Check to see if we have a PIC. > + * Mask all except the cascade and read > + * back the value we just wrote. If we don't > + * have a PIC, we will read 0xff as opposed to the > + * value we wrote. > +

Re: [PATCH 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-11 Thread H. Peter Anvin
On 04/11/2014 04:02 PM, K. Y. Srinivasan wrote: > > diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c > index 2e977b5..0a57a19 100644 > --- a/arch/x86/kernel/i8259.c > +++ b/arch/x86/kernel/i8259.c > @@ -299,11 +299,22 @@ static void unmask_8259A(void) > static void init_8259A(int a

Re: [PATCH] x86, hyperv: bypass the timer_irq_works() check

2014-01-24 Thread H. Peter Anvin
On 01/23/2014 10:02 PM, Jason Wang wrote: > This patch bypass the timer_irq_works() check for hyperv guest since: > > - It was guaranteed to work. > - timer_irq_works() may fail sometime due to the lpj calibration were > inaccurate > in a hyperv guest or a buggy host. > > In the future, we sho

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-10-09 Thread H. Peter Anvin
On 09/27/2013 08:35 AM, KY Srinivasan wrote: > > Thanks Olaf. Could you submit the patch. > Haven't heard anything from Olaf... could you fold in the fix and resumbit? -hpa ___ devel mailing list de...@linuxdriverproject.org http://driverdev

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-23 Thread H. Peter Anvin
On 09/23/2013 06:02 AM, KY Srinivasan wrote: > > Peter, > Please let me know if there are other issues I need to address here. Now that > Dmitry has queued up the > Hyper-V keyboard driver, with this patch we can fully support Linux on our > uefi firmware. > I just got back from Plumber's -- t

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-12 Thread H. Peter Anvin
On 09/12/2013 05:06 PM, KY Srinivasan wrote: > > Peter, > > Let me know if you want me to address any additional issues in this patch. > Please address Jan and Gleb's feedback. -hpa ___ devel mailing list de...@linuxdriverproject.org http:/

Re: [PATCH V2 4/4] x86: correctly detect hypervisor

2013-08-05 Thread H. Peter Anvin
On 08/05/2013 07:34 AM, Konrad Rzeszutek Wilk wrote: > > Could you provide me with a git branch so I can test it overnight please? > Pull tip:x86/paravirt. -hpa ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriver