Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

2014-07-21 Thread Guillaume Morin
On 21 Jul 19:08, Greg KH wrote: > Odd thing is, that function doesn't seem to even use that variable > anywhere... Can you just remove it entirely? Oh that's right. Resubmitted. Thanks Guillaume. -- Guillaume Morin ___ devel

[PATCH v2] staging: llite: rw.c: remove gfp_mask

2014-07-21 Thread Guillaume Morin
sparse reported that gfp_mask was of the wrong type to store gfp flags. The variable is not used so it can be removed. Signed-off-by: Guillaume Morin Suggested-by: gre...@linuxfoundation.org --- v2: remove the variable instead of just fixing the type since it is not used drivers/staging

[PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

2014-07-21 Thread Guillaume Morin
Use gfp_t to store GPF_* flags instead of unsigned int. This was reported by sparse. Signed-off-by: Guillaume Morin --- drivers/staging/lustre/lustre/llite/rw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging

[PATCH v2] staging: dgnc_driver.c: code style fixes

2014-06-28 Thread Guillaume Morin
From: Guillaume Morin Simple code style fixes: - "if(" -> "if (" - "switch(" -> "switch (" - move one open brace to the line of the declaration instead of its own line - remove trailing whitespace Signed-off-by: Guillaume Morin --- Changes

[PATCH] staging: dgnc_driver.c: code style fixes

2014-06-27 Thread Guillaume Morin
From: Guillaume Morin Simple code style fixes Signed-off-by: Guillaume Morin --- drivers/staging/dgnc/dgnc_driver.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index d52a9e8..68460af