Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Francois Romieu
Joe Perches : > On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote: [...] > > How about kernel tinification ? > > The tiny case where a large number of ethernet drivers are included? No. A couple of bytes here and there vs a cosmetic kernel wide chan

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Francois Romieu
Mark Einon : [...] > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm > > directly, its members will be NULL and thus never called. Also, you can > > make et131x_pm_ops const. > > Ok, I can change this. > > Btw, this appears to be a fairly standard way of using .driver.pm

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Francois Romieu
Richard Weinberger : > Am 09.07.2014 00:47, schrieb Francois Romieu: [...] > > What are you taking about ? netconsole does not need to receive. > > Isn't netconsole is only one user of netpoll ? Out of tree users are irrelevant. See netpoll

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Francois Romieu
Richard Weinberger : [...] > This won't work as netpoll runs with IRQs disabled. > ->ndo_poll_controller() has to make sure that SKBs can be received and > transmitted > while IRQs are off. I thought calling the channel callback by hand would be > enough to receive SKBs. What are you taking abou