Re: [PATCH] staging: ks7010: clean up code

2017-03-04 Thread Ernestas Kulik
On Fri, 2017-03-03 at 23:24-0800, Joe Perches wrote: > > More stuff the changelog doesn't show :( > > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and rem

[PATCH v2] staging: ks7010: fix sparse warnings

2017-03-04 Thread Ernestas Kulik
Currently, sparse generates many warnings for the driver. This commit changes the types of struct fields/function variables to match the endianness at their assignment. Signed-off-by: Ernestas Kulik --- Changes from v1: * Change the type of the variable being passed to ntohs() instead of casting

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > struct hostif_hdr.event is declared at uint16_t > and not as __le16 so I believe this is incorrect > and actually introduces a sparse error. Sure, but I change that in the patch. :) On Sat, 2017-03-04 at 08:28 +0200, Ernestas

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 17:23-0800, Joe Perches wrote: > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and removes unused fields in structs. > > There's

[PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
This fixes type warnings generated by sparse, replaces instances of ntohs() with be16_to_cpu() and removes unused fields in structs. Signed-off-by: Ernestas Kulik --- drivers/staging/ks7010/ks7010_sdio.c | 12 ++-- drivers/staging/ks7010/ks_hostif.c | 30 + drivers/staging/ks7010

[PATCH 2/2] staging: lustre: llite: use octal permissions

2017-01-24 Thread Ernestas Kulik
Using octal permissions instead of symbolic ones is preferred. Signed-off-by: Ernestas Kulik --- drivers/staging/lustre/lustre/llite/dir.c | 2 +- drivers/staging/lustre/lustre/llite/file.c | 2 +- drivers/staging/lustre/lustre/llite/llite_lib.c | 4 ++-- drivers/staging/lustre

[PATCH 1/2] staging: lustre: libcfs: use octal permissions

2017-01-24 Thread Ernestas Kulik
Using octal permissions instead of symbolic ones is preferred. Signed-off-by: Ernestas Kulik --- drivers/staging/lustre/lnet/libcfs/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs