Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-03-03 Thread Eric Engestrom
On Friday, 2017-03-03 14:04:26 +0300, Dan Carpenter wrote: > On Thu, Mar 02, 2017 at 01:44:36PM -0800, Laura Abbott wrote: > > static struct sg_table *ion_map_dma_buf(struct dma_buf_attachment > > *attachment, > > enum dma_data_direction direction) > > { > >

Re: [PATCH v3 4/5] staging/android: add Doc for SW_SYNC ioctl interface

2016-08-11 Thread Eric Engestrom
of this feature. > > v2: take in Eric suggestions for the Documentation > > Signed-off-by: Gustavo Padovan > Reviewed-by: Eric Engestrom > --- > drivers/staging/android/sw_sync.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff -

Re: [PATCH v2 6/6] dma-buf/sw_sync: de-stage SW_SYNC

2016-08-11 Thread Eric Engestrom
To create fences on this timeline the SW_SYNC_IOC_CREATE_FENCE > ioctl should be used. To increment the timeline value use SW_SYNC_IOC_INC. > > Also it exports Sync information on > > /sync/info > > Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom > -

Re: [PATCH v2 5/6] staging/android: add Doc for SW_SYNC ioctl interface

2016-08-11 Thread Eric Engestrom
t paragraph could use some love: comma before "SW_SYNC_IOC_INC", "that has seqno smaller or equal to it." > + * > + * struct sw_sync_ioctl_create_fence > + * @value: the seqno to initiate the fence with s/initiate/initialise/ With these fixed, Reviewed-by:

Re: [PATCH v2 4/6] staging/android: prepare sw_sync files for de-staging

2016-08-11 Thread Eric Engestrom
++ b/drivers/staging/android/sync_debug.h > @@ -1,5 +1,5 @@ > /* > - * include/linux/sync.h > + * Sync File validation framework "and debug information" With that added, Reviewed-by: Eric Engestrom > * > * Copyright (C) 2012 Google, Inc. > * > -- > 2.

Re: [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h

2016-08-11 Thread Eric Engestrom
On Mon, Aug 08, 2016 at 06:24:19PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > The common behaviour for trace headers is to have them in the same folder > they are used, instead of creating a special trace/ directory. > > Signed-off-by: Gustavo Padovan

Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework

2016-08-11 Thread Eric Engestrom
On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The first 2 patches are clean up and impro

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-07 Thread Eric Engestrom
On Tue, Jul 05, 2016 at 01:47:05PM -0700, Markus Mayer wrote: > All functions return a pointer to the terminating '\0' character in the > modified string ("dst" or "s", respectively). I think this is going to be confusing. From the man: The strcpy() and strncpy() functions return a pointe