[PATCH 3/7] Staging: vt6655: comment after statement formatting

2015-01-15 Thread Emrys Bayliss
This patch makes the formatting of the comments in mac.h more consistent. * Where a comment follows a statement, it is separated by a single space. Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 24 1 file changed, 12 insertions(+), 12 deletions

[PATCH 7/7] Staging: vt6655: Checkpatch fix: c99 comment headings

2015-01-15 Thread Emrys Bayliss
This patch fixes some of the following checkpatch.pl errors in mac.h ERROR: do not use C99 // comments This patch reformats all single line c99 style comments to the preferred style. Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 122

[PATCH 4/7] Staging: vt6655: Checkpatch fix: c99 comments after statements

2015-01-15 Thread Emrys Bayliss
This patch fixes some c99 errors in mac.h: ERROR: do not use C99 // comments All instances where the c99 comment occurs after a statement. Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH 6/7] Staging: vt6655: comment headings formatting

2015-01-15 Thread Emrys Bayliss
This patch makes the formatting of the comments in mac.h more consistent. * Where a heading takes up three comment lines it is reduced to one. * A newline always separates column headings Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 93

[PATCH 5/7] Staging: vt6655: Checkpatch fix: lines longer than 80 columns

2015-01-15 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl errors in mac.h: WARNING: line over 80 characters Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/mac.h

[PATCH 1/7] Staging: vt6655: Checkpatch fix: unnecessary whitespace

2015-01-15 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl errors in mac.h: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Emrys Bayliss --- drivers/staging/vt6655/mac.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/mac.h

[PATCH 2/7] Staging: vt6655: Checkpatch fix: empty c99 comments

2015-01-15 Thread Emrys Bayliss
This patch fixes some of the following checkpatch.pl errors in mac.h: ERROR: do not use C99 // comments This patch truncates statements which are followed by empty c99 comments. Signed-off-by: Emrys Bayliss --- This patch contains several checkpatch errors which are fixed later in the series

[PATCH 0/7] Staging: vt6655: Fix style and checkpatch issues

2015-01-15 Thread Emrys Bayliss
Fix checkpatch and formatting issues in drivers/staging/vt6655/mac.h Emrys Bayliss (7): Staging: vt6655: Checkpatch fix: unnecessary whitespace Staging: vt6655: Checkpatch fix: empty c99 comments Staging: vt6655: comment after statement formatting Staging: vt6655: Checkpatch fix: c99

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This was supposed to be a v3 patch. Resent. On 01/14/2015 04:03 AM, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement

[PATCH v3] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:558: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- The else statement was replaced with a block to avoid the following compiler error: "warning: ISO C90 forbids mixed declarations and

[PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:558: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- The else statement was replaced with a block to avoid the following compiler error: "warning: ISO C90 forbids mixed declarations and

[PATCH] Staging: vt6656: Code cleanup: remove unreachable return

2015-01-13 Thread Emrys Bayliss
This patch removes an unnecessary return statement that cannot be reached. Signed-off-by: Emrys Bayliss --- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index ea5140a..0cce140 100644 --- a

[PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-12 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Emrys Bayliss
> > On 11/01/15 16:42, Joe Perches wrote: >> On Mon, 2015-01-12 at 03:19 +1100, Emrys Bayliss wrote: >>> This patch fixes the following checkpatch.pl error: >>> rxtx.c:588: WARNING: else is not generally useful after a break or return >>> >>> Signed-

[PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- drivers/staging/vt6656/rxtx.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b

[PATCH] Staging: rts5208: fix space prohibited before ', ' error in ms.c

2015-01-05 Thread Emrys Bayliss
Fix the checkpatch.pl errors: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Emrys Bayliss --- drivers/staging/rts5208/ms.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c ind