[PATCH 1/4] staging: olpc_dcon: olpc_dcon: Fix open parenthesis alignment.

2017-01-08 Thread Emmanuil Chatzipetru
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 2/4] staging: olpc_dcon: olpc_dcon_xo_1_5: Remove redundant return statement.

2017-01-08 Thread Emmanuil Chatzipetru
dcon_was_irq(); should return a boolean value if PMIO_Rx50[6] is either set or unset, which is evaluated in the first return statement. Therefore, the following return statement is redundant and thus, removed. Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c

[PATCH 3/4] staging: olpc_dcon: olpc_dcon: Fix spaces between operator and variables.

2017-01-08 Thread Emmanuil Chatzipetru
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] staging: olpc_dcon: olpc_dcon_xo_1_5: Remove multiple blank lines.

2017-01-08 Thread Emmanuil Chatzipetru
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/olpc

[PATCH v3 1/2] staging: greybus: audio_topology: Fix spaces between operator and string

2017-01-04 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "CHECK: spaces preferred around that '*' (ctx:VxV) " Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/audio_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v3 2/2] staging: greybus: log: Fix line over 80 characters.

2017-01-04 Thread Emmanuil Chatzipetru
the warnings of the compiler. Also, while at it, drop the redundant cast in the comparison as well to maintain consistency. Signed-off-by: Emmanuil Chatzipetru --- v2: As Johan suggested, is better to keep the already two-tab indendation to be persisent. Therefore, the 80 line characters limit is f

Re: [PATCH v2] staging: greybus: log: Fix line over 80 characters.

2017-01-04 Thread Emmanuil Chatzipetru
Hello, On Wed, Jan 04, 2017 at 04:26:35PM +0100, Johan Hovold wrote: > On Wed, Jan 04, 2017 at 04:14:45PM +0100, Emmanuil Chatzipetru wrote: > > Fix coding style issue caught by checkpatch.pl related to the following > > warning: > > - CHECK: WARNING: line over 80 charac

[PATCH v2] staging: greybus: log: Fix line over 80 characters.

2017-01-04 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: WARNING: line over 80 characters While at it, drop the redundant cast in the comparison. Signed-off-by: Emmanuil Chatzipetru --- v2: - As Johan suggested, is better to keep the already two-tab

[PATCH 2/2] staging: greybus: log: Fix line over 80 characters.

2017-01-04 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: WARNING: line over 80 characters Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus

[PATCH 1/2] staging: greybus: audio_topology: Fix spaces between operator and string

2017-01-04 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "CHECK: spaces preferred around that '*' (ctx:VxV) " Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/audio_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2] staging: greybus: svc_watchdog: replace printk() with pr_err()

2016-12-22 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ." Signed-off-by: Emmanuil Chatzipetru --- v2: Add svc_watchdog to the su

[PATCH v2] staging: greybus: svc_watchdog: Fix spaces on a single definition statement

2016-12-22 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "CHECK: spaces preferred around that '*' (ctx:VxV) " Signed-off-by: Emmanuil Chatzipetru --- v2: Add svc_watchdog to the subject line drivers/staging/greybus/svc_watchdog.c | 2 +

Re: [PATCH] staging: greybus: Fix static array of pointers declaration as static const.

2016-12-22 Thread Emmanuil Chatzipetru
Hello, > On Wed, Dec 21, 2016 at 04:38:26PM +0100, Emmanuil Chatzipetru wrote: > > Fix coding style issue caught by checkpatch.pl related to the following > > warning: > > - "WARNING: char * array declaration might be better as static const" > > &g

[PATCH] staging: greybus: Fix spaces on a single definition statement

2016-12-21 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "CHECK: spaces preferred around that '*' (ctx:VxV) " Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/svc_watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] staging: greybus: Fix static array of pointers declaration as static const.

2016-12-21 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "WARNING: char * array declaration might be better as static const" Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/svc_watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] staging: greybus: replace printk() with pr_err()

2016-12-21 Thread Emmanuil Chatzipetru
Fix coding style issue caught by checkpatch.pl related to the following warning: - "WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ." Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/svc_