Re: [PATCH] Staging: rtl8192e: Fix potential NULL pointer dereference

2014-07-02 Thread Emil Goode
Hello Greg, On Wed, Jul 02, 2014 at 09:33:34AM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 02, 2014 at 11:25:51AM +0200, Emil Goode wrote: > > We need to make sure the struct rtllib_device pointer ieee is not NULL > > after the goto rx_dropped label since it is der

[PATCH] Staging: rtl8192e: Fix potential NULL pointer dereference

2014-07-02 Thread Emil Goode
We need to make sure the struct rtllib_device pointer ieee is not NULL after the goto rx_dropped label since it is dereferenced there. Signed-off-by: Emil Goode --- drivers/staging/rtl8192e/rtllib_rx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: lustre: remove unused variables

2014-05-06 Thread Emil Goode
The following commit left some unused variables behind. commit 80db2734acbc78db12798cfb611d6acc7fe389e6 Author: Fredrick John Berchmans Date: Fri May 2 19:50:15 2014 -0700 staging: lustre use kernel socket sockopt apis Signed-off-by: Emil Goode --- drivers/staging/lustre/lustre/libcfs

[PATCH v2 2/2] staging: lustre: Fix sparse warnings about use of obsolete initializer

2013-07-27 Thread Emil Goode
This patch fixes a lot of sparse warnings about use of obsolete struct and array initializer. Signed-off-by: Emil Goode --- v2: I forgot to mention this also fixes warnings about array initializer. drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 16 +++ drivers/staging/lustre/lustre

[PATCH v2 1/2] staging: lustre: Fix non-ANSI sparse warnings

2013-07-27 Thread Emil Goode
This patch fixes a lot of non-ANSI sparse warnings by adding void to parameterless functions. Signed-off-by: Emil Goode --- v2: A bit more specific commit message. .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c|6 +++--- drivers/staging/lustre/lnet/lnet/api-ni.c

Re: [PATCH 1/2] staging: lustre: Fix non-ANSI sparse warnings

2013-07-27 Thread Emil Goode
t; add a void parameter to functions which don't get one. > > Andi > > > Signed-off-by: Emil Goode ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: lustre: Fix sparse warnings about obsolete struct initializer

2013-07-27 Thread Emil Goode
This patch fixes a lot of sparse warnings about use of obsolete struct initializer. Signed-off-by: Emil Goode --- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 16 +++ drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 50 ++-- drivers/staging/lustre/lustre/ldlm

[PATCH 1/2] staging: lustre: Fix non-ANSI sparse warnings

2013-07-27 Thread Emil Goode
This patch fixes a lot of non-ANSI sparse warnings. Signed-off-by: Emil Goode --- .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c|6 +++--- drivers/staging/lustre/lnet/lnet/api-ni.c|2 +- drivers/staging/lustre/lnet/selftest/console.c |2