Re: [patch] staging: unisys: remove some dead code

2016-01-07 Thread Don Zickus
ff-by: Dan Carpenter Acked-by: Don Zickus > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c > b/drivers/staging/unisys/visorbus/visorchipset.c > index 07594f4..ff2bd077 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys

Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

2015-06-29 Thread Don Zickus
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: > > This patch fixes checkpatch warnings > > Signed-off-by: Ravi Teja Darbha David, Is this code removed after you ripped out the parahotplug stuff? IOW, the next round of updates from Ben might obsolete this patch. Cheers, Don > ---

Re: [PATCH v5 04/13] staging: unisys: Do not use 0 as the default bus root device number

2015-06-05 Thread Don Zickus
On Fri, Jun 05, 2015 at 06:04:14PM +0300, Dan Carpenter wrote: > Sorry, I should have read on the later patches. That sounds fine. Hi Dan, No worries. I will take the blame for that. I should have communicated that or done a better job making less confusing. :-( Cheers, Don __

Re: [PATCH v5 04/13] staging: unisys: Do not use 0 as the default bus root device number

2015-06-04 Thread Don Zickus
On Thu, Jun 04, 2015 at 05:19:44PM +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2015 at 09:22:40AM -0400, Benjamin Romer wrote: > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c > > b/drivers/staging/unisys/visorbus/visorchipset.c > > index 4dd0a07..618732b 100644 > > --- a/drivers/

Re: [PATCH 00/13 V3] Continued rest of unisys driver update

2015-06-01 Thread Don Zickus
On Sun, May 31, 2015 at 10:17:30AM +0900, Greg KH wrote: > On Tue, May 26, 2015 at 02:40:45PM -0400, Don Zickus wrote: > > Hi, > > > > GregKH ran into an issue where the last 13 patches didn't apply. > > > > It looks like Ben cleaned up the patches to

Re: [PATCH 12/13] staging: unisys: Remove unneeded fields in diagchannel.h

2015-06-01 Thread Don Zickus
On Sun, May 31, 2015 at 10:16:37AM +0900, Greg KH wrote: > On Tue, May 26, 2015 at 02:40:57PM -0400, Don Zickus wrote: > > From: David Kershner > > > > Diagchannel.h is used primarily for the diagnostics channel. The > > diagnostics channel is not being used by linux g

Re: staging: unisys: Convert bus functions to pass bus_info pointer around

2015-05-28 Thread Don Zickus
On Wed, May 27, 2015 at 07:02:51PM +0300, Dan Carpenter wrote: > Hello Don Zickus, > > This is a semi-automatic email about new static checker warnings. > > The patch 3032aeddd85e: "staging: unisys: Convert bus functions to > pass bus_info pointer around" fro

[PATCH 08/13] staging: unisys: Convert bus creation to use visor_device

2015-05-26 Thread Don Zickus
visor_device. Various cleanups include re-arranging the failure paths to make more sense. Signed-off-by: Don Zickus --- drivers/staging/unisys/include/visorbus.h | 3 + drivers/staging/unisys/visorbus/visorbus_main.c| 130 - drivers/staging/unisys/visorbus

[PATCH 10/13] staging: unisys: Removed unused entries from struct visor_channeltype_descriptor

2015-05-26 Thread Don Zickus
From: Jes Sorensen min_size/max_size aren't used anywhere, and they were just causing headaches in the drivers being ported over to the new interfaces. Signed-off-by: Jes Sorensen Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 2 -- 1 file changed, 2 deletions(-

[PATCH 13/13] staging: unisys: Clean up diag_serverity enum

2015-05-26 Thread Don Zickus
From: David Kershner Get rid of unused values in the enum. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/diagchannel.h | 32 +++- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/staging/unisys/inc

[PATCH 12/13] staging: unisys: Remove unneeded fields in diagchannel.h

2015-05-26 Thread Don Zickus
From: David Kershner Diagchannel.h is used primarily for the diagnostics channel. The diagnostics channel is not being used by linux guests currently, so the majority of the file is not needed. What is left is what is needed to perform postcode vmcalls. Those postcodes will eventually end up in t

[PATCH 11/13] staging: unisys: Update diag serverity enum

2015-05-26 Thread Don Zickus
From: David Kershner Give the enum the correct values instead of based on other values. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/diagchannel.h | 34 1 file changed, 10 insertions(+), 24 deletions(-) diff --git

[PATCH 06/13] staging: unisys: Remove server flags

2015-05-26 Thread Don Zickus
The bus driver doesn't work in server mode, just remove the left over pieces. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_main.c| 66 +++--- drivers/staging/unisys/visorbus/visorbus_private.h | 5 -- drivers/staging/unisys/visorbus/visorchip

[PATCH 04/13] staging: unisys: Migrate bus from devdata to visor_device

2015-05-26 Thread Don Zickus
dev and 'struct visorbus_devdata' to 'struct visor_device'. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_main.c | 127 +++- 1 file changed, 57 insertions(+), 70 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main

[PATCH 09/13] staging: unisys: Convert device creation to use visor_device

2015-05-26 Thread Don Zickus
visor_device. Various cleanups include re-arranging the failure paths to make more sense. Pay attention to the create_visor_device function. This had a lot of churn to simplify everything. Lots of functions disappeared because they are not needed any more. Signed-off-by: Don Zickus --- drivers

[PATCH 07/13] staging: unisys: Do not use 0 as the default bus root device number

2015-05-26 Thread Don Zickus
Fix visorbus.h to use u32 there. Fix the resulting printk warning too. Signed-off-by: Don Zickus --- drivers/staging/unisys/include/visorbus.h | 4 ++-- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- drivers/staging/unisys/visorbus/visorchipset.c | 6 -- 3 files changed, 7 inser

[PATCH 02/13] staging: unisys: Convert pending_msg_hdr to a pointer

2015-05-26 Thread Don Zickus
#x27;responders' instead of bus/dev_info. That change causes some fallout in the success case. Instead of setting state bits and clearing info in the responders, do all that magic in the responder wrappers. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_private.h | 4

[PATCH 01/13] staging: unisys: Move channel creation up the stack

2015-05-26 Thread Don Zickus
so I just deleted it. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_main.c| 88 +++--- drivers/staging/unisys/visorbus/visorbus_private.h | 16 +--- drivers/staging/unisys/visorbus/visorchipset.c | 54 - 3 files changed, 63 inserti

[PATCH 03/13] staging: unisys: Prepare vbus_hdr_info to be public

2015-05-26 Thread Don Zickus
used in the public namespace. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_main.c | 52 ++--- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus

[PATCH 05/13] staging: unisys: Remove unused cruft

2015-05-26 Thread Don Zickus
Removing stuff that isn't being used. Another prepartion patch to allow us to use visor_device everywhere without the baggage of bus/dev_info. Signed-off-by: Don Zickus --- drivers/staging/unisys/visorbus/visorbus_main.c| 72 -- drivers/staging/unisys/vis

[PATCH 00/13 V3] Continued rest of unisys driver update

2015-05-26 Thread Don Zickus
. No functional changes, just surrounding patch context refresh. David Kershner (3): staging: unisys: Update diag serverity enum staging: unisys: Remove unneeded fields in diagchannel.h staging: unisys: Clean up diag_serverity enum Don Zickus (9): staging: unisys: Move channel creation u

[PATCH 40/44 V2] staging: unisys: Convert device creation to use visor_device

2015-05-18 Thread Don Zickus
visor_device. Various cleanups include re-arranging the failure paths to make more sense. Pay attention to the create_visor_device function. This had a lot of churn to simplify everything. Lots of functions disappeared because they are not needed any more. Signed-off-by: Don Zickus --- V2

[PATCH 32/44 V2] staging: unisys: Move channel creation up the stack

2015-05-18 Thread Don Zickus
so I just deleted it. Signed-off-by: Don Zickus --- V2: Fix bus/dev_create error path by adding bus/dev_info = NULL (Dan Carpenter) --- drivers/staging/unisys/visorbus/visorbus_main.c| 87 +++--- drivers/staging/unisys/visorbus/visorbus_private.h | 16 +--- drivers/stag

Re: [PATCH 32/44] staging: unisys: Move channel creation up the stack

2015-05-18 Thread Don Zickus
On Sat, May 16, 2015 at 02:38:57PM +0300, Dan Carpenter wrote: > On Wed, May 13, 2015 at 01:22:26PM -0400, Benjamin Romer wrote: > > --- a/drivers/staging/unisys/visorbus/visorchipset.c > > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > > @@ -1197,6 +1197,7 @@ bus_create(struct controlvm_me

Re: [PATCH 40/44] staging: unisys: Convert device creation to use visor_device

2015-05-18 Thread Don Zickus
On Sat, May 16, 2015 at 02:32:33PM +0300, Dan Carpenter wrote: > On Wed, May 13, 2015 at 01:22:34PM -0400, Benjamin Romer wrote: > > @@ -1022,29 +997,21 @@ create_visor_device(struct visor_device *bdev, > > goto away; > > } > > > > - /* note: device_register is simply device_ini

Re: [PATCH 34/44] staging: unisys: Prepare vbus_hdr_info to be public

2015-05-18 Thread Don Zickus
On Sat, May 16, 2015 at 02:22:16PM +0300, Dan Carpenter wrote: > On Wed, May 13, 2015 at 01:22:28PM -0400, Benjamin Romer wrote: > > + hdr_info = kzalloc(sizeof(*hdr_info), GFP_KERNEL); > > + if (!hdr_info) { > > + rc = NULL; > > + goto away_mem; > > + } > > + > > dev_

Re: [PATCH 134/141] staging: unisys: Hide vbus_hdr_info from public visor_device

2015-05-11 Thread Don Zickus
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote: > On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote: > > > > > > This function leaks hdr_info on later error paths. > > > > Never mind. I'm wrong. Sorry for the noise. > > > > To be honest, I think I was right original

Re: [PATCH 125/141] staging: unisys: Convert cmd functions to visor_device

2015-05-11 Thread Don Zickus
On Sat, May 09, 2015 at 12:06:32PM +0300, Dan Carpenter wrote: > On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote: > > On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote: > > > On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote: > &

Re: [PATCH 126/141] staging: unisys: Convert the epilog functions to visor_device

2015-05-08 Thread Don Zickus
On Fri, May 08, 2015 at 04:02:06PM +0200, Greg KH wrote: > On Fri, May 08, 2015 at 09:56:41AM -0400, Don Zickus wrote: > > On Fri, May 08, 2015 at 11:00:18AM +0300, Dan Carpenter wrote: > > > On Tue, May 05, 2015 at 06:37:43PM -0400, Benjamin Romer wrote: > &

Re: [PATCH 126/141] staging: unisys: Convert the epilog functions to visor_device

2015-05-08 Thread Don Zickus
On Fri, May 08, 2015 at 11:00:18AM +0300, Dan Carpenter wrote: > On Tue, May 05, 2015 at 06:37:43PM -0400, Benjamin Romer wrote: > > From: Don Zickus > > @@ -1128,7 +1119,7 @@ device_epilog(u32 bus_no, u32 dev_no, struct > > spar_segment_state state, u32 cmd, > &