Also increment the kernel module version number to match the
userspace version, as compatibility with old userspace utilities
is now at least partially broken.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/usbip_common.h | 2 +-
drivers/staging
context as well as the fd.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 24 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 24 +-
.../staging/usbip/userspace/src/usbip_network.c| 279
(usbip, probably has more entropy available than the
server) and transferred over the already established TLS connection.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 21 ++
.../usbip/userspace/libsrc/usbip_host_driver.c
f-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub.h | 5
drivers/staging/usbip/stub_dev.c | 61 +++-
2 files changed, 65 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbi
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip
This extends the userspace code to write the generated session keys to
sysfs in hexadecimal encoding after establishing the connection.
The kernel code is modified to parse the session keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_dev.c
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging
This adds code performing the actual encryption and authentication
operations in the usbip kernel code. The whole data stream may now be
encrypted and authenticated with AES-GCM and symmetric 128 bit keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip
e dead link was
removed from the checklist section.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
drivers/staging/usbip/userspace/README | 72 +++-
drivers/staging/usbip/userspace/doc/usbipd.8 | 4 +-
2 files changed, 31 insertions(+), 45 deletions
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c
This adds two simple wrappers around kernel_sendmsg() and
kernel_recvmsg() that can be extended to perform additional
cryptographic operations on the data before sending it.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_rx.c | 2 +-
drivers
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
Hi,
sorry for the messed-up error checking. We fixed some of the style nitpicks and
hopefully all of the mistakes you pointed out (thank you for that!).
Regards,
Dominik and Tobias
___
devel mailing list
de...@linuxdriverproject.org
http://driv
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files
used to perform a secure handshake and dropped before the socket is
passed to the kernel. The code may be extended to exchange a session key
over TLS and pass it to the kernel to perform IPsec.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by
This adds two simple wrappers around kernel_sendmsg() and
kernel_recvmsg() that can be extended to perform additional
cryptographic operations on the data before sending it.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_rx.c | 2 +-
drivers
This extends the userspace code to write the generated session keys to
sysfs in hexadecimal encoding after establishing the connection.
The kernel code is modified to parse the session keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_dev.c
context as well as the fd.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 24 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 24 +-
.../staging/usbip/userspace/src/usbip_network.c| 279
Also increment the kernel module version number to match the
userspace version, as compatibility with old userspace utilities
is now at least partially broken.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/usbip_common.h | 2 +-
drivers/staging
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c
(usbip, probably has more entropy available than the
server) and transferred over the already established TLS connection.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 21 ++
.../usbip/userspace/libsrc/usbip_host_driver.c
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip
e dead link was
removed from the checklist section.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
drivers/staging/usbip/userspace/README | 72 +++-
drivers/staging/usbip/userspace/doc/usbipd.8 | 4 +-
2 files changed, 31 insertions(+), 45 deletions
This adds code performing the actual encryption and authentication
operations in the usbip kernel code. The whole data stream may now be
encrypted and authenticated with AES-GCM and symmetric 128 bit keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip
f-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub.h | 5 +++
drivers/staging/usbip/stub_dev.c | 68 +++-
2 files changed, 72 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbi
used to perform a secure handshake and dropped before the socket is
passed to the kernel. The code may be extended to exchange a session key
over TLS and pass it to the kernel to perform IPsec.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
On Wed, Sep 25, 2013 at 04:36:38PM -0700, Greg Kroah-Hartman wrote:
> Only the first patch could be applied. Can you refresh this series, and
> your other one (fixing the issues pointed out there), and resend them
> please?
We've incorporated all of Dan's fixes and suggestions and rebased the
whol
rect
size.
> > + total = ret;
> > + goto err;
> > + } else if (ret != sizeof(packetsize)) {
> > + total = -EBADMSG;
> > + goto err;
> > + }
On Mon, Sep 2
Also increment the kernel module version number to match the
userspace version, as compatibility with old userspace utilities
is now at least partially broken.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/usbip_common.h | 2 +-
drivers/staging
e dead link was
removed from the checklist section.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
drivers/staging/usbip/userspace/README | 72 +++-
drivers/staging/usbip/userspace/doc/usbipd.8 | 4 +-
2 files changed, 31 insertions(+), 45 deletions
This adds code performing the actual encryption and authentication
operations in the usbip kernel code. The whole data stream may now be
encrypted and authenticated with AES-GCM and symmetric 128 bit keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip
This adds two simple wrappers around kernel_sendmsg() and
kernel_recvmsg() that can be extended to perform additional
cryptographic operations on the data before sending it.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_rx.c | 2 +-
drivers
context as well as the fd.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 24 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 24 +-
.../staging/usbip/userspace/src/usbip_network.c| 279
(usbip, probably has more entropy available than the
server) and transferred over the already established TLS connection.
As this breaks compatibility with older clients supporting userspace
encryption, the protocol version is increased.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
This extends the userspace code to write the generated session keys to
sysfs in hexadecimal encoding after establishing the connection.
The kernel code is modified to parse the session keys.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub_dev.c
merged as one, the protocol version increment can be
omitted - both patch series are compatible with unauthenticated transport, but
are incompatible with each other.
Regards,
Tobias Polzer and Dominik Paulus
[1] <1379066161-8278-1-git-send-email-dominik.pau...@fau.de>,
https://lk
With --with-tcp-wrappers=no specified, the build system reset LIBS to
the empty string and thus fails to link against libsysfs.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
device (vhci) not being
created, so usbip cannot work.
It works after removing the codeblock mentioned above.
We did some research and discovered that dma_mask is only set on PowerPC
at the moment (in arch/powerpc/kernel/setup-common.c,
arch_setup_pdev_archda
From: Tobias Polzer
One missing include was added.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_network.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/usbip/userspace/src/usbip_network.c
b/drivers/staging
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
with EADDRINUSE.
This patch uses seperate sockets for IPv4 and IPv6 and sets IPV6_V6ONLY
on all IPv6 sockets. Two command line arguments, -4 and -6 were added to
manually select the socket family.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
.../staging/usbip/userspace/src
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 099d24b..0b0e035
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip
don't increment the protocol version.
We've already sent this patch series, but forgot to specify a subject line.
linux-usb apparently received it[2], the LKML didn't. Sorry if you received it
twice now.
Regards,
Tobias Polzer and Dominik Paulus
[1] See <6aeb926e1c4572
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files
f-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub.h | 5 +++
drivers/staging/usbip/stub_dev.c | 68 +++-
2 files changed, 72 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbi
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by
used to perform a secure handshake and dropped before the socket is
passed to the kernel. The code may be extended to exchange a session key
over TLS and pass it to the kernel to perform IPsec.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
don't increment the protocol version.
Regards,
Tobias Polzer and Dominik Paulus
[1] See <6aeb926e1c4572e79488a91a827333c9.squir...@faumail.uni-erlangen.de>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver
f-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/stub.h | 5 +++
drivers/staging/usbip/stub_dev.c | 68 +++-
2 files changed, 72 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbi
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging
with EADDRINUSE.
This patch uses seperate sockets for IPv4 and IPv6 and sets IPV6_V6ONLY
on all IPv6 sockets. Two command line arguments, -4 and -6 were added to
manually select the socket family.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
.../staging/usbip/userspace/src
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 099d24b..0b0e035
used to perform a secure handshake and dropped before the socket is
passed to the kernel. The code may be extended to exchange a session key
over TLS and pass it to the kernel to perform IPsec.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace
with EADDRINUSE.
This patch uses seperate sockets for IPv4 and IPv6 and sets IPV6_V6ONLY
on all IPv6 sockets. Two command line arguments, -4 and -6 were added to
manually select the socket family.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
.../staging/usbip/userspace/src
71 matches
Mail list logo
