Hi Nicolas,
On Mon, Nov 23, 2020 at 07:38:29PM +0100, Nicolas Saenz Julienne wrote:
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> interface when unbinding the device.
I do not believe this comment is correct any longer. Otherwise:
Acked-by: Dmit
On Thu, Nov 12, 2020 at 07:52:14PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 12, 2020 at 6:40 PM Nicolas Saenz Julienne
> wrote:
> >
> > When unbinding the firmware device we need to make sure it has no
> > consumers left. Otherwise we'd leave them with a firmware handle
> > pointing at freed me
Hi Nicolas,
On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote:
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> interface when unbinding the device.
Unless I am mistaken this driver does not really need the firmware
structure past rpi_ts_probe(), a
On Thu, Jul 16, 2020 at 12:14 PM Kees Cook wrote:
>
> On Thu, Jul 16, 2020 at 09:57:18AM +0200, Peter Zijlstra wrote:
> > On Wed, Jul 15, 2020 at 08:08:44PM -0700, Kees Cook wrote:
> > > Hi,
> > >
> > > This is the infrastructure changes to prepare the tasklet API for
> > > conversion to passing t
On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor wrote:
>
> From: Todd Poynor
>
> Hold a reference on the struct pci_dev while a pointer to it is held in
> the gasket data structures.
>
> Signed-off-by: Todd Poynor
> ---
> drivers/staging/gasket/gasket_core.c | 4 ++--
> 1 file changed, 2 insertion
Hi Todd,
On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor wrote:
> @@ -1064,7 +1067,8 @@ static int gasket_open(struct inode *inode, struct file
> *filp)
> char task_name[TASK_COMM_LEN];
> struct gasket_cdev_info *dev_info =
> container_of(inode->i_cdev, struct gasket_cde
On Sun, Jul 15, 2018 at 12:32 PM Greg Kroah-Hartman
wrote:
>
> On Sun, Jul 15, 2018 at 12:11:47PM +0300, Dmitry Torokhov wrote:
> > On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poy
On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman
wrote:
>
> On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote:
> > From: Todd Poynor
> >
> > Always allow root to open device for writing.
> >
> > Drop special-casing of ioctl permissions for root vs
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote:
>
> From: Todd Poynor
>
> Always allow root to open device for writing.
>
> Drop special-casing of ioctl permissions for root vs. owner.
>
> Reported-by: Dmitry Torokhov
> Signed-off-by: Zhongze Hu
> Signed-off-
On Sat, Jul 14, 2018 at 8:59 AM Todd Poynor wrote:
>
> From: Todd Poynor
>
> class_create() never returns NULL, and this driver should never return
> PTR_ERR(NULL) anyway.
>
> Reported-by: Dmitry Torokhov
> Signed-off-by: Zhongze Hu
> Signed-off-by: Todd Poynor
R
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote:
>
> From: Todd Poynor
>
> g_mutex held across pci_unregister_driver() call, also held in
> gasket_pci_remove(), which deadlocks.
>
> Reported-by: Dmitry Torokhov
> Signed-off-by: Zhongze Hu
> Signed-off-by: To
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor wrote:
>
> From: Todd Poynor
>
> Use container_of(), drop unnecessary NULL check.
>
> Reported-by: Dmitry Torokhov
> Signed-off-by: Zhongze Hu
> Signed-off-by: Todd Poynor
> ---
> drivers/staging/gasket/gasket_core.c
hyperv.c| 4 ++--
> arch/x86/kernel/cpu/vmware.c | 4 ++--
> arch/x86/kernel/kvm.c | 4 ++--
> arch/x86/xen/enlighten_hvm.c | 4 ++--
> arch/x86/xen/enlighten_pv.c | 4 ++--
> drivers/hv/vmbus_drv.c| 2 +-
> drivers/input/mouse/vmmouse.c |
If binder_get_thread() fails to give us a thread data, we should avoid
dereferencing a NULL pointer and return POLLERR instead.
Signed-off-by: Dmitry Torokhov
---
drivers/android/binder.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b
: Dmitry Torokhov
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 37bd439ee08b..1fba377f816b 100644
--- a/drivers/staging/media
[ resending as plain text ]
On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov wrote:
>
>
> On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall wrote:
>>
>> PTR_ERR should access the value just tested by IS_ERR
>>
>> Generated by: scripts/coccinelle/tests/odd_ptr_er
On Tue, Dec 15, 2015 at 11:00 AM, Gustavo Padovan wrote:
> 2015-12-15 Daniel Vetter :
>
>> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote:
>> > Userspace can close the sync device while there are still active fence
>> > points, in which case kernel
On Tue, Dec 15, 2015 at 1:26 AM, Daniel Vetter wrote:
> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote:
>> Userspace can close the sync device while there are still active fence
>> points, in which case kernel produces the following warning:
>>
>> [ 4
On Tue, Dec 15, 2015 at 5:30 AM, Gustavo Padovan wrote:
> 2015-12-14 Dmitry Torokhov :
>
>> Userspace can close the sync device while there are still active fence
>> points, in which case kernel produces the following warning:
>>
>> [ 43.
On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst
wrote:
> Op 15-12-15 om 02:29 schreef Dmitry Torokhov:
>> Userspace can close the sync device while there are still active fence
>> points, in which case kernel produces the following warning:
>>
>> [ 43.853
On Tue, Dec 15, 2015 at 5:50 AM, Frank Binns wrote:
> Is this not the issue fixed by 8e43c9c75?
No because if we start teardown without waiting for the fence to be
signaled it will still be on the active_list.
Thanks.
--
Dmitry
___
devel mailing list
_fence, we guarantee that each callback has either
completed (since fence_remove_callback() grabs the fence lock) or been
removed.
Signed-off-by: Andrew Bresticker
Signed-off-by: Dmitry Torokhov
---
drivers/staging/android/sync.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
lback (disable_signaling)
to fence operations so that drivers can do proper clean ups when we
remove last callback for given fence.
Reviewed-by: Andrew Bresticker
Signed-off-by: Dmitry Torokhov
---
drivers/dma-buf/fence.c| 6 +-
drivers/staging/android/sync.c | 8
include/
On Mon, Aug 18, 2014 at 03:54:51AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Dmitry Torokhov
> > Sent: Saturday, August 16, 2014 0:58 AM
> > To: Dexuan Cui
> > > For each char in the string, the host sends 2 events (key down/up with the
&
Hi Dexuan,
On Fri, Aug 15, 2014 at 02:41:59AM -0700, Dexuan Cui wrote:
> In the menu of the Hyper-V's Virtual Machine Connection, there is a feature
> called "Clipboard | Type clipboard text", which can be used to copy a string
> in the host's clipboard into the guest's current input focus(text co
On Wed, Aug 13, 2014 at 05:24:35AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Dmitry Torokhov
> > Sent: Wednesday, August 13, 2014 1:55 AM
> > > > > To decouple the dependency between the hyperv-keyboard and i8042
> > > > > mod
On Tue, Aug 12, 2014 at 07:15:25AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> > ow...@vger.kernel.org] On Behalf Of Greg KH
> > > > What exactly needs to be done to fix this "correctly" that is going to
> > > > take t
On Wed, Aug 6, 2014 at 5:19 PM, Dexuan Cui wrote:
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> > Sent: Thursday, August 7, 2014 4:34 AM
> > To: Dexuan Cui
> > On Fri, Aug 01, 2014 at 07:28:24AM -0700, Dexuan Cui
On Fri, Aug 01, 2014 at 07:28:24AM -0700, Dexuan Cui wrote:
> With this patch, we can press a key to wake up the VM after the VM executes
> "echo freeze > /sys/power/state".
>
> This addresses part of https://bugzilla.redhat.com/show_bug.cgi?id=1086100
I am sorry but this bug is not open to the p
On Sat, Jul 5, 2014 at 8:39 PM, Greg KH wrote:
> On Sat, Jul 05, 2014 at 04:37:37PM +0100, Alan Cox wrote:
>> On Fri, 2014-07-04 at 21:48 +0300, Kristina Martšenko wrote:
>> > Hi,
>> >
>> > I'm going over some "older" drivers in the staging tree and wanted to
>> > ask about cptm1217 and ste_rmi4.
On Sat, Jan 11, 2014 at 07:41:50PM -0800, K. Y. Srinivasan wrote:
> Handle the 0xE1 prefix.
>
> Signed-off-by: K. Y. Srinivasan
Applied, thank you.
> ---
> drivers/input/serio/hyperv-keyboard.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/seri
On Monday, September 23, 2013 11:08:12 PM Olaf Hering wrote:
> On Wed, Sep 18, Dmitry Torokhov wrote:
> > This looks much better. Could you tell me if the patch below (on top of
> > yours) still works?
>
> The help text is slightly incorrect, its a dash not underscore:
On Wed, Sep 18, 2013 at 11:27:51PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> > Sent: Wednesday, September 18, 2013 2:01 PM
> > To: KY Srinivasan
> > Cc: gre...@linuxfoundati
ech Pavlik for helping me with the
> details of the AT keyboard driver. I would also like to thank
> Dan Carpenter and
> Dmitry Torokhov for their detailed review of this
> driver.
>
> I have addressed all the comments of Dan and Dmitry in this version of
> the patch
This
On Mon, Sep 16, 2013 at 06:29:45PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> > Sent: Monday, September 16, 2013 10:10 AM
> > To: KY Srinivasan
> > Cc: Dan Carpenter; o...@a
On Mon, Sep 16, 2013 at 03:52:18PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> > Sent: Monday, September 16, 2013 8:20 AM
> > To: KY Srinivasan
> > Cc: gre...@linuxfoundati
On Mon, Sep 16, 2013 at 04:56:03PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, September 16, 2013 8:06 AM
> > To: KY Srinivasan
> > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com;
>
On Sun, Sep 15, 2013 at 11:56:25AM +0100, Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > For battery driven systems it is a very bad idea to collect the touchscreen
> > data within a kernel busy loop.
> >
> > This change uses the features of the hardware to delay and accum
Hi K. Y.
On Sun, Sep 15, 2013 at 10:28:54PM -0700, K. Y. Srinivasan wrote:
> Add a new driver to support synthetic keyboard. On the next generation
> Hyper-V guest firmware, many legacy devices will not be emulated and this
> driver will be required.
>
> I would like to thank Vojtech Pavlik for
39 matches
Mail list logo
