[RFC PATCH 2/5] unisys: use simpler kthread_ API

2015-01-21 Thread Devendra Naga
should_stop and a call to KILL can be replaced with kthread_stop function. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib/uisthread.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/unisys

[RFC PATCH 1/5] unisys: replace kthread_create and wake_up_process with kthread_run

2015-01-21 Thread Devendra Naga
kthread_run calls kthread_create and if the thread is created it then calls wake_up_process on the corresponding returned task struct. So the code can be simplified by calling just kthread_run. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib

[RFC PATCH 4/5] unisys: use kthread_should_stop API in the lib thread

2015-01-21 Thread Devendra Naga
convert the users of should_stop into using kthread_should_stop API. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib/uislib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers

[RFC PATCH 0/5] unisys: kthread cleanup

2015-01-21 Thread Devendra Naga
should_stop variable. The 5th patch removes the variables should_stop and KILL as they are no longer required. All patches applies on next-20150120 cleanly. All the patches are compile tested on X86_64 allmodconfig. Cc: Ken Cox Cc: Benjamin Romer Devendra Naga (5): unisys: replace kthread_create

[RFC PATCH 3/5] unisys: use kthread_should_stop in the thread

2015-01-21 Thread Devendra Naga
convert the users of should_stop variable into kthread_should_stop() API. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/virthba/virthba.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[RFC PATCH 5/5] unisys: remove the thread variable and API

2015-01-21 Thread Devendra Naga
remove the should_stop variable and KILL API as they are no longer required Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/include/uisthread.h | 1 - drivers/staging/unisys/uislib/uisthread.c | 2 -- 2 files changed, 3 deletions(-) diff --git a

[PATCH 5/5] unisys: remove the thread variable and API

2015-01-21 Thread Devendra Naga
remove the should_stop variable and KILL API as they are no longer required Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/include/uisthread.h | 1 - drivers/staging/unisys/uislib/uisthread.c | 2 -- 2 files changed, 3 deletions(-) diff --git a

[PATCH 4/5] unisys: use kthread_should_stop API in the lib thread

2015-01-21 Thread Devendra Naga
convert the users of should_stop into using kthread_should_stop API. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib/uislib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers

[RFC PATCH 0/5] unisys: kthread cleanup

2015-01-21 Thread Devendra Naga
should_stop variable. The 5th patch removes the variables should_stop and KILL as they are no longer required. All patches applies on next-20150120 cleanly. All the patches are compile tested on X86_64 allmodconfig. Devendra Naga (5): unisys: replace kthread_create and wake_up_process with

[PATCH 2/5] unisys: use simpler kthread_ API

2015-01-21 Thread Devendra Naga
should_stop and a call to KILL can be replaced with kthread_stop function. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib/uisthread.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 1/5] unisys: replace kthread_create and wake_up_process with kthread_run

2015-01-21 Thread Devendra Naga
kthread_run calls kthread_create and if the thread is created it then calls wake_up_process on the corresponding returned task struct. So the code can be simplified by calling just kthread_run. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/uislib

[PATCH 3/5] unisys: use kthread_should_stop in the thread

2015-01-21 Thread Devendra Naga
convert the users of should_stop variable into kthread_should_stop() API. Cc: Ken Cox Cc: Benjamin Romer Signed-off-by: Devendra Naga --- drivers/staging/unisys/virthba/virthba.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH] cptm1217: check if interrupts are masked at probe

2015-01-02 Thread Devendra Naga
the function cp_tm1217_mask_interrupt can return failure. added the check and the failure path. Cc: Ramesh Agarwal Signed-off-by: Devendra Naga --- build tested only on x86_64. config is allmodconfig. drivers/staging/cptm1217/clearpad_tm1217.c | 6 ++ 1 file changed, 6 insertions

[PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-01-02 Thread Devendra Naga
/staging/iio/meter/ade7754.c:368:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Devendra Naga --- Hello, Please see if this is the error message you wanted. Build tested on next-20141231 with randconfig sent to iio ml, and with

[PATCH V2 2/2] iio: meter: ade7759: add error handling in _reset and _stop_device

2015-01-02 Thread Devendra Naga
/staging/iio/meter/ade7759.c:309:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Devendra Naga --- Hello, Please see if this is the error message you wanted. Build tested on next-20141231 with randconfig sent to iio ml, and with

[PATCH] staging: mt29f_spinand: check for the return value of spinand_read_status

2014-12-05 Thread Devendra Naga
The spinan_read_status can fail, check for the return value and fail if the spinand_read_status fails. Cc: Kamlakant Patel Signed-off-by: Devendra Naga --- compile tested only with make allmodconfig (platform X86_64 ) drivers/staging/mt29f_spinand/mt29f_spinand.c | 17 - 1

[PATCH] staging: clocking-wizard: check for a valid clk_name pointer

2014-11-29 Thread Devendra Naga
The clk_name gets the return value from kasprintf (part of which does the allocation of the returned buffer). So check the return pointer before using it for clk_register_fixed_factor. Cc: Soren Brinkmann Signed-off-by: Devendra Naga --- I have only compile tested this with the following

[PATCH] staging: rtl8192e: add missing tasklet_kill on remove path

2014-11-23 Thread Devendra Naga
The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger Signed-off-by: Devendra Naga --- Compile tested only on top the linux-next for : 20141121 drivers/staging/rtl8192e/rtllib_softmac.c | 1 + 1 file changed, 1 insertion

[PATCH 3/3] staging: gs_fpgaboot: fix a compiler warning with make W=2

2014-10-24 Thread Devendra Naga
declaration is here [-Wshadow] by renaming file function argument of gs_load_image with fw_file. Signed-off-by: Devendra Naga --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers

[PATCH 1/3] staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function

2014-10-24 Thread Devendra Naga
the error path is cleanup to return the correct (function call return value) error code. Signed-off-by: Devendra Naga --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b

[PATCH 2/3] staging: gs_fpgpaboot: fix compiler warning with make W=1

2014-10-24 Thread Devendra Naga
drivers/staging/gs_fpgaboot/gs_fpga.o LD drivers/staging/gs_fpgaboot/built-in.o by removing the size variable. Signed-off-by: Devendra Naga --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Devendra Naga
On Fri, Oct 24, 2014 at 5:01 AM, Gioh Kim wrote: > > > 2014-10-24 오전 8:16, Gioh Kim 쓴 글: > >> >> >> 2014-10-24 오전 5:36, Devendra Naga 쓴 글: >>> >>> Hello, >>> >>> On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: >&g

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

2014-10-23 Thread Devendra Naga
Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: > This patch shrink page-pool by page unit. > > Signed-off-by: Gioh Kim > --- > drivers/staging/android/ion/ion_page_pool.c |5 +++-- > drivers/staging/android/ion/ion_system_heap.c |7 +-- > 2 files changed, 8 insertions(+),

[PATCH v2] Fix error handling in dgnc_start()

2014-10-18 Thread Devendra Naga
register_chrdev. Signed-off-by: Devendra Naga --- Changes since v2: (added solutions for Dan's comments) 1. removed error message print 2. added error handling in device_create 3. added goto err_device_destroy when dgnc_tty_preinit fails drivers/staging/dgnc/dgnc_driver.c |

Re: [PATCH] staging: dgnc: Fix a possible crash when the class_create fails

2014-10-17 Thread Devendra Naga
Hello Dan, On Wed, Oct 15, 2014 at 2:47 PM, Dan Carpenter wrote: > On Mon, Oct 13, 2014 at 10:26:54PM +0530, devendrana...@gmail.com wrote: >> From: Devendra Naga >> > > Just fix your email client, so the from header is correct. These From > headers should be for when y