The current code attempts assignment of -1 to an unsigned type. Note that
in a downstream function ion_page_pool_shrink this mask is only ever
evaluated against __GFP_HIGHMEM
(drivers/staging/android/ion/ion_page_pool.c, line 125).
Signed-off-by: Derek Yerger
Reviewed-by: Laura Abbott
-off-by: Derek Yerger
Reviewed-by: Laura Abbott
---
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index c97e82b..a9c8861 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1524,7 +1524,7 @@ static int debug_shrink_set
-off-by: Derek Yerger
Reviewed-by: Laura Abbott
---
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index c97e82b..a9c8861 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1524,7 +1524,7 @@ static int debug_shrink_set
).
Signed-off-by: Derek Yerger
---
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index c97e82b..a9c8861 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1524,7 +1524,7 @@ static int debug_shrink_set(void *data, u64 val
rue;
124 else
125 high = !!(gfp_mask & __GFP_HIGHMEM);
Kind Regards,
Derek Yerger
On 02/22/2016 02:18 PM, Laura Abbott wrote:
On 02/20/2016 07:15 PM, Derek Yerger wrote:
From drivers/staging/android TODO file - sparse errors.
The current code attempts assignment of -1 to
used __GFP_HIGHMEM as the mask, but was removed in a subsequent revert.
This patch removes the sparse errors, and fixes the assignment as noted
above.
Signed-off-by: Derek Yerger
---
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index c97e82b..a9ca46f 100644
