Re: [PATCH 1/6] staging: wilc1000: modify build error

On 2015년 06월 30일 17:50, Dan Carpenter wrote: On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote: this function needs more arguments. Sudip sent a patch for this but he passed false instead of true. We are disconnecting because we got CONN_DISCONN_EVENT_DISCONN_NOTIF as a response

[PATCH 5/6] staging: wilc1000: fix initialize warning issue.

modify it Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 ++- drivers/staging/wilc1000/linux_wlan.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 3/6] staging: wilc1000: rework driver handler

argument type change for support 64 bit system. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 218 +++--- drivers/staging

[PATCH 2/6] staging: wilc1000: delete 'WILC_WFIDrvHandle' structure

delete odd structure and rework it. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 149 +++--- drivers/staging/wilc1000/host_interface.h | 123 +- drivers/staging/wilc1000/linux_wlan.c | 14 +- drivers/staging

[PATCH 4/6] staging: wilc1000: rework address value.

change type to pointer. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 22 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers

[PATCH 6/6] staging: wilc1000: delete unused value.

Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 52 --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 2 files changed, 1 insertion(+), 53 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 1/6] staging: wilc1000: modify build error

this function needs more arguments. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index

Re: [PATCH] staging: wilc1000: modify type casting warning

On 2015년 06월 16일 16:09, Sudip Mukherjee wrote: On Tue, Jun 16, 2015 at 03:46:04PM +0900, Dean Lee wrote: modify message "warning: cast from pointer to integer of different size". add type cast 'uintptr_t'. --- [] @@ -620,7 +621,7 @@ static s32 Handle_SetChan

[PATCH 1/2] staging: wilc1000: modify type casting warning

modify message "warning: cast from pointer to integer of different size". add type cast 'uintptr_t'. Signed-off-by: Dean Lee --- Change Log: add Signed-off-by line drivers/staging/wilc1000/host_interface.c | 129 +++--- drivers/staging/w

[PATCH 2/2] staging: wilc1000: modify uninitialized warning

initialize it. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 358283f..03e6bc5 100644 --- a/drivers/staging

Re: [PATCH] staging: wilc1000: modify type casting warning

On 2015년 06월 16일 15:46, Dean Lee wrote: modify message "warning: cast from pointer to integer of different size". add type cast 'uintptr_t'. --- drivers/staging/wilc1000/host_interface.c | 129 +++--- drivers/staging/wilc1000/linux_wlan

[PATCH] staging: wilc1000: modify type casting warning

modify message "warning: cast from pointer to integer of different size". add type cast 'uintptr_t'. --- drivers/staging/wilc1000/host_interface.c | 129 +++--- drivers/staging/wilc1000/linux_wlan.c | 8 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |

[PATCH] staging: wilc1000: rework include wilc_oswrapper.h

rework line '#include "wilc_oswrapper.h"' it does not used anywhere after change own data type to common data type. Signed-off-by: Dean Lee --- Change Log: add rework file 'host_interface.c' --- drivers/staging/wilc1000/coreconfigurator.h | 1 - drivers/staging/w

Re: [PATCH 1/3] staging: wilc1000: rework include wilc_oswrapper.h

On 2015년 06월 16일 15:06, Dean.lee wrote: On 2015년 06월 16일 15:03, Greg KH wrote: On Tue, Jun 16, 2015 at 02:38:20PM +0900, Dean Lee wrote: rework line '#include "wilc_oswrapper.h"' it does not require after change own data type to common data type. Signed-off-by: Dean

Re: [PATCH 1/3] staging: wilc1000: rework include wilc_oswrapper.h

On 2015년 06월 16일 15:03, Greg KH wrote: On Tue, Jun 16, 2015 at 02:38:20PM +0900, Dean Lee wrote: rework line '#include "wilc_oswrapper.h"' it does not require after change own data type to common data type. Signed-off-by: Dean Lee These are nice, but why isn't any

[PATCH 1/3] staging: wilc1000: rework include wilc_oswrapper.h

rework line '#include "wilc_oswrapper.h"' it does not require after change own data type to common data type. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.h | 1 - drivers/staging/wilc1000/fifo_buffer.c | 1 - drivers/staging/wilc1000/fi

[PATCH 3/3] staging: wilc1000: delete unused files (wilc_oswrapper.h wilc_type.h)

delete unsued files Signed-off-by: Dean Lee --- drivers/staging/wilc1000/wilc_oswrapper.h | 41 --- drivers/staging/wilc1000/wilc_type.h | 34 - 2 files changed, 75 deletions(-) delete mode 100644 drivers/staging/wilc1000

[PATCH 2/3] staging: wilc1000: rework include wilc_type.h

rework line '#include "wilc_type.h"' it does not require after rework include wilc_oswrapper.h Signed-off-by: Dean Lee --- drivers/staging/wilc1000/wilc_wlan.h| 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 10 +- 2 files changed, 10 insertions(+), 2 deleti

[PATCH v2] staging: wilc1000: change WILC_Char to char

change own data type(WILC_Char) to common data type(char) Signed-off-by: Dean Lee --- Change v2: replace data type s8 -> char --- drivers/staging/wilc1000/coreconfigurator.c | 24 +++ drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wilc1000/host_interfac

Re: [PATCH] staging: wilc1000: change WILC_Char to s8

On 2015년 06월 13일 00:28, Greg KH wrote: On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote: change own data type(WILC_Char) to common data type(s8) Why not just 'char'? And you are using these in "strings", so why not u8? thanks, greg k-h i research some doc

Re: [PATCH v3] staging: wilc1000: remove oswrapper & type file

On 2015년 06월 13일 00:26, Greg KH wrote: On Fri, Jun 12, 2015 at 07:21:11PM +0900, Dean Lee wrote: remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #in

Re: [PATCH] staging: wilc1000: remove warnings reported by checkpatch.pl.

On 2015년 06월 12일 23:34, Greg KH wrote: On Fri, Jun 12, 2015 at 06:51:56PM +0900, Dean Lee wrote: Remove the following warnings in the wilc_log.h: - unnecessary whitespace before a quoted newline - line over 80 characters - single statement macros should not use a do {} while (0) loop. Those

Re: [PATCH] staging: wilc1000: update TODO list

On 2015년 06월 12일 20:07, Sudip Mukherjee wrote: On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote: remove complete OS wrapper functions. just a minor thing. It will be easy if you send your patches in series instead of separate patches. your patch "remove oswrapper & type

[PATCH v2] staging: wilc1000: remove oswrapper & type file

remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i try removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dean Lee --- Change modify commit message. --- dr

[PATCH] staging: wilc1000: update TODO list

remove complete OS wrapper functions. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO index 95199d8..e876008 100644 --- a/drivers/staging/wilc1000/TODO +++ b/drivers

[PATCH v3] staging: wilc1000: remove oswrapper & type file

remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.h

[PATCH] staging: wilc1000: remove warnings reported by checkpatch.pl.

Remove the following warnings in the wilc_log.h: - unnecessary whitespace before a quoted newline - line over 80 characters - single statement macros should not use a do {} while (0) loop. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/wilc_log.h | 53

Re: [PATCH] staging: wilc1000: remove oswrapper & type file

On 2015년 06월 12일 18:17, Konrad Zapalowicz wrote: On 06/12, Dean Lee wrote: remove OS Wrapper & Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. I do not understand the commit message and it does not parse

Re: [PATCH v2] staging: wilc1000: remove oswrapper & type file

On 2015년 06월 12일 19:03, Dean Lee wrote: remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i try removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dea

[PATCH] staging: wilc1000: remove oswrapper & type file

remove OS Wrapper & Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.h | 1 - drivers/staging/wilc1000/fifo_buffer.c | 1 - dri

[PATCH] staging: wilc1000: change WILC_Char to s8

change own data type(WILC_Char) to common data type(s8) Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.c | 24 +++ drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wilc1000/host_interface.c | 88 +++ drivers

[PATCH v2] staging: wilc1000: change WILC_BOOL to bool

change own data type(WILC_BOOL) to common data type(bool) but that's contain true/false value. so change with them. Signed-off-by: Dean Lee --- Change remove WILC_BOOL structure. --- drivers/staging/wilc1000/coreconfigurator.c | 26 ++-- drivers/staging/wilc1000/coreconfigura

Re: [PATCH] staging: wilc1000: change WILC_BOOL to bool

On 2015년 06월 12일 13:56, Dean Lee wrote: change own data type(WILC_BOOL) to common data type(bool) but that's contain true/false value. so change with them. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.c | 16 +-- drivers/staging/wilc1000/coreconfigura

[PATCH] staging: wilc1000: change WILC_BOOL to bool

change own data type(WILC_BOOL) to common data type(bool) but that's contain true/false value. so change with them. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.c | 16 +-- drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wil

Re: [PATCH] staging: wilc1000: modify odd print message

On 2015년 06월 11일 12:50, Greg KH wrote: On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion

[PATCH] staging: wilc1000: modify odd print message

This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

Re: [PATCH 3/4] staging: wilc1000: modify printk format

On 2015년 06월 11일 09:42, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:46PM +0900, Johnny Kim wrote: This remove compile warnings about printk format. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/linux_wlan.c