Re: [PATCH 2/2] staging: silicom: function return fixes

2014-07-11 Thread Davide Gianforte
On Wed, Jul 09, 2014 at 11:59:14, Greg Kroah-Hartman wrote: > On Tue, Jul 01, 2014 at 02:33:43PM +0200, Davide Gianforte wrote: > > + uint32_t ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT); > > > > - ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT); > > How ab

[PATCH 2/2] staging: silicom: function return fixes

2014-07-01 Thread Davide Gianforte
Function return fixes Some functions don't need a temporary variable to store return value. Where functions always return 0, changed into void functions. Signed-off-by: Davide Gianforte -- drivers/staging/silicom/bpctl_mod.c | 62 ++--- 1 file change

[PATCH 1/2] staging: silicom: checkpatch fixes

2014-07-01 Thread Davide Gianforte
Chechpatch.pl cleanup There are still some warnings, most of them are lines over 80 chars (mainly a semicolon or closing parenthesis). Where not specified, I defaulted printk with no log level into pr_debug Signed-off-by: Davide Gianforte --- drivers/staging/silicom/bpctl_mod.c | 712