The driver no longer needs to include drivers/staging/unisys/include, so we
can get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorinput/Makefile
b
Checkpatch was giving errors about an open parenthesis being the last thing
on a line. This patch cleans up some names and removes the checkpatch
warnings.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 19 +--
1 file
Miscellaneous patches to the visorinput driver.
David Kershner (5):
staging: unisys: visorinput: Clean up Makefile includes
staging: unisys: visorinput: remove duplicate comments
staging: unisys: visorinput: combine ultrainputreport.h with visorinput.c
staging: unisys: visorinput: Fix
-by: David Kershner
---
drivers/staging/unisys/visorinput/Kconfig | 2 +-
drivers/staging/unisys/visorinput/visorinput.c | 43 +--
2 files changed, 32 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/Kconfig
b/drivers/staging/unisys/visorinput
Comments were based on individual entries, if we group the entries, we can
get rid of duplicate comments.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 16 +
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Several of the comments in the code were not using the full 80 characters
of the screen. This patch combines the lines to make full use of the
screen.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 64 ---
1 file changed
The file ultrainputreport.h was just being used by visorinput.c. Move the
definitions into visorinput.c and get rid of the file.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 55 +-
drivers/staging/unisys/visorinput
-by: David Kershner
Reviewed-by: Tim Sell
---
The files are based off the latest revision in the staging-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Changes from v1:
-- Simplified to one single patch
-- Combined include files into a single file
Combine the include files visorchannel.h and visorbus.h so that only one
include file is needed for the .c files.
Reported-by: Christoph Hellwig
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 2 +-
drivers/staging/unisys/include
Remove the dependency that the drivers are not built during UML.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/Kconfig b/drivers
The Kconfig file for UNISYSSPAR uses select ACPI and select PCI instead of
depends on ACPI. This patch fixes the problem.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions
This patch series combines the global include files into a single include
and cleans up dependencies that were in the wrong location. We had code
dependencies on the UNISYSSPAR Kconfig flag instead of the VISORBUS config
flag. UNISYSSPAR is just there for organizational purposes.
David Kershner
The Kconfig flag UNISYSSPAR depended on ACPI and X86, these dependencies
really belong to visorbus, so move them there.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 2 --
drivers/staging/unisys/visorbus/Kconfig | 1 +
2 files changed, 1
over to drives/visorbus/Kconfig to make sure dependencies were met.
Visorbus will now just live in the /drivers directory.
Signed-off-by: David Kershner
Reviewed-by: David Binder
Reviewed-by: Tim Sell
---
MAINTAINERS | 2 ++
drivers
this state.
David Kershner (1):
drivers: visorbus: move driver out of staging
Tim Sell (1):
staging: unisys: visorbus: address theoretical int overflows
MAINTAINERS | 2 ++
drivers/Kconfig
ned long)i+1;
printf("adding 1 WITHcast = %lun", il);
}
[selltc@mac tmp]$ gcc x.c -o x.out
[selltc@mac tmp]$ ./x.out
sizeof(int) =4
sizeof(long)=8
i = 4294967295
adding 1 withOUT cast = 0
adding 1 WITHcast = 4294967296
Signed-off-by: Tim Sell
Reported-
Clean up unneeded () that are being reported by checkpatch.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Clean up unneeded parenthesis reported by checkpatch.pl.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers
From: Sameer Wadgaonkar
Validate that the channel contents match the channel type that we are
matching.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 11 ++-
drivers/staging/unisys/visorhba
From: Sameer Wadgaonkar
This patch fixes some comments and spacings in the file visorbus.h
to make it more uniform.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 12 +---
1 file changed, 5
From: Sameer Wadgaonkar
This patch fixes some comments in the file vbuschannel.h to make
it more uniform.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vbuschannel.h | 9 -
1 file changed, 4 insertions(+), 5
Clean up unneeded parenthesis reported by checkpatch.pl.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorhba/visorhba_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b
From: Sameer Wadgaonkar
This patch fixes two checkpatch issues of line over 80 characters
in visorchipset.c.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 --
1 file changed, 4 insertions(+), 2
Cleans up parameter formatting in visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
drivers/staging/unisys/visorbus/visorchipset.c | 17 -
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a
Shrinks the name of POLLJIFFIES_CONTORLVMCHANNEL_FAST and
POLLJIFFIES_CONTROLVMCHANNEL_SLOW to just POLLJIFFIES_CONTROLVM_.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 20
1 file changed, 8 insertions(+), 12
Found several more useless initializations in visorchipset.c get rid of
them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys
From: David Binder
Removes unused enum that pertains to s-Par diagnostics capabilities.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 20
1 file changed, 20 deletions(-)
diff --git a
From: Sameer Wadgaonkar
Removing the two wrapper functions dealing with visorchannel_create() and
instead just always use a new version of visorchannel_create() with an
additional parameter.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers
From: David Binder
Removes unnecessary SIGNATURE_16 macro used to generate a simple 32-bit
signature.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorchannel.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions
From: David Binder
In order to avoid a potential conflict with other drivers that define a
channel.h file, the s-Par channel.h file is renamed in accordance with the
surrounding driver-set namespace.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers
The variable visorbus_type could be contained to the visorbus_main.c
file by moving the two functions that referenced it visorchipset.c. This
allowed us to remove the incorrect extern from the include file visorbus.h.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
The include file visorbus.h has a forward declaration of visor_device.
A simple reorder of the file removed the need for the forward
declaration.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 125 +++---
1 file
The header file visorbus.h included several linux headers that were
used by the source files that include it. Move the includes to the
files that actually use them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
drivers/staging
If you can't find the dev, it is an error. Indent for the error, instead
of the success.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/u
Remove signature_32 since it was only being referenced in one location.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers
Use all 80 characters of the line to consolidate a comment.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/include/iochannel.h
b/drivers
Channel.h was including io.h and not using it. Remove the #include.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers/staging/unisys/include
Remove extraneous blank lines and get consistency of blank lines.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 98 +-
1 file changed, 3 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/unisys
Don't include ctypes in vbuschannel.h, it isn't used by ctypes, but it is
used by visorbus_main.c so include it there.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 1 +
drivers/staging/unisys/visorbus/vbuschannel.
Simplify debugfs statement so it is clearer and more compact.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers
The field debugfs_client_bus_info can be reduced to debugfs_bus_info.
The word client is extraneous in this context.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys/visorbus/visorbus_main.c | 20
Don't compute value of offset during initialization. Assigning a value to
offset should happen after we have verified all of its components.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 14 +++---
1 file changed, 7 inser
The function publish_vbus_dev_info was doing a memcmp of guids. It should
be using the kernel provided guid_equal function instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions
Removes several extraneous blank lines in visorbus_main.c.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 44 ++---
1 file changed, 3 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
The macros to_visor_device and to_visor_driver are fairly small; move them
up to the declaration block to save some space.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 14 --
1 file changed, 4 insertions(+), 10 deletions
Remove extraneous blank lines and add some lines that are needed. General
philosophy -- declaration, space, pre-conditions (if needed), space, then
rest of function.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 28
A NULL pending_msg_hdr is not an error, it just means that the firmware
does not want an error response for that message.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 3 ++-
drivers/staging/unisys/visorbus/visorchipset.c | 13
The function parser_string_get was writing its own strnlen function, use
the kernel version instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff
Remvoe several unneeded blank lines.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h
b/drivers/staging/unisys/visorbus
Here are some more updates to clean up the code.
David Binder (3):
staging: unisys: include: Rename channel.h to visorchannel.h
staging: unisys: include: Remove unnecessary macro to generate
signature
staging: unisys: include: Remove unused enum
David Kershner (37):
staging: unisys
Correct indenting of parameters when calling the functions in the file
visorchipset.c.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys
Simplify the code by not putting the assignment in the declaration. Define
it and then assign it, so the function doesn't get bunched up on the
right.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 14 ++
1 file chang
visor_device is not referenced after the unregister.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging
Consolidate function parameters onto the same line if they can fit.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 27 +
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/unisys
Use all 80 characters when calling functions.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 31 ++
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
During the process of udpating the features bits, put a block comment for
all updates instead of a separate comment for each one.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions
The code was indenting for the successful path and then combining the
error and success path for the rest of the function. Correct it so the
success path is not indented.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 16
Use all 80 characters when calling functions.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers
In the file visorhcannel.c use all 80 characters for comments instead of
shortening them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 35 +-
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a
No need to set drv to NULL.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus
The local variable cmd was just being used to dereference a field inside
of it. Get rid of the variable and just derefernce the parameter being
passed in.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file changed, 1 insertion
Use all 80 characters of the line for comments to help reduce the number
of extra lines in the code.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 44 +++--
1 file changed, 19 insertions(+), 25 deletions(-)
diff
Every channel_type must have a valid GUID, checking for the name was just
redundant.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
The size of the channel should be pulled from the channel header, not
from the message. All channels must be at least the size of the
channel_header.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 10 +--
drivers/staging/unisys
Shorten the name of the function parser_init_byte_stream to just
parser_init_stream.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: Sameer Wadgaonkar
Changing pr_err to dev_err in visor_check_channel. Added device
as an argument to visor_check_channel to pass into dev_err.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 7
The variable ctx was allocated with kzalloc, so all the data inside is
zero, no need to reset it to 0.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: David Binder
Removes unnecessary return value in send_rcv_posts_if_needed(), since
NAPI polling functions do not return errors.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 13 +++--
1
Currently setting it in the right location, so no longer not sure.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging
The parser functions were defined at the top of the file even though they
were not referenced until later in the file. This patch moves them closer
to where they are defined so they can be easily referenced.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys
From: Sameer Wadgaonkar
Removing EXPORT_SYMBOL_GPU from visor_check_channel since it is
used only in visorbus.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
1 file changed, 1 deletion(-)
diff
Fix up the GUID definition to remove some checkpatch warnings as well as
using the whole width of the screen.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers
Fixed the following checkpatch warning:
visorchannel.c:443: CHECK: Alignment should match open parenthesis
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 3 +--
drivers/staging/unisys/visorbus/visorbus_main.c | 8
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging
From: David Binder
Fixes miscellaneous formatting issues with several block comments
throughout visornic_main.c.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 14 ++
1 file changed, 6
The file visorchipset had a bunch of comments that were not using the full
screen before they wrapped, update the comments to wrap at 80 characters
instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 35 ---
1 file
Several variables were initialized when not needed. Remove the extraneous
initializations.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys
The dev_err was using the hardcoded function name, as reported by
checkpatch, it should be using __func__.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Checkpatch reports an error that no comment was next to the mutex lock.
Add an appropriate message for the lock.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
The functions to create the controlvm channel were disjointed and ignoring
information that was available. This patch consolidates it so it clearer
what is happening.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 47
The function visorutil_spar_detect had an if clause that returns from the
function, no need to do the rest of the code in an else clause.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 23 +++
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus
Visorbus_configure had a block of "else if" clauses at the beginning of the
function. Simplify this to just being "if" clauses since each code block
ended with a goto.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.
The variable parm_addr will never be null, so no need to check for it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
From: David Binder
Refactors existing static function comments to increase code readability.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 417 +++--
1 file changed, 190 insertions(+), 227
Several macros in visorchannel.c were doing complex arithmetic, converted
them to functions so that valid type checking could be done.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 25 +++
1 file changed, 15 insertions
Checkpatch cleanups and other misc cleanups.
David Binder (3):
staging: unisys: visornic: Fix up existing function comments.
staging: unisys: visornic: Fix miscellaneous block comment format issues.
staging: unisys: visornic: Remove unnecessary return values
David Kershner (21):
staging
, it helped
clean up the formatting of the function.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
From: Sameer Wadgaonkar
The error return values for the drv->probe, drv->remove, drv->pause
and drv->resume checks should be -EINVAL instead of -ENODEV.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
dri
off-by: Sameer Wadgaonkar
Reported-by: Dan Carpenter
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/uni
The kernel already provides a min function, we should be using that
instead of creating our own MINNUM.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 3 ---
drivers/staging/unisys/visornic
Don't store it in a local variable but reference it from the
visor_device.
Reviewed-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/dr
From: Sameer Wadgaonkar
The function visorchipset_device_create just called create_visor_device,
we can just combine it with create_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 18
From: Sameer Wadgaonkar
The function visorchipset_bus_destroy just called viosrbus_remove_instance,
we can just combine it with visorbus_remove_instance.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c
From: David Binder
Adds the proper Unisys copyright statement to the top of iochannel.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 18 --
1 file changed, 16 insertions(+), 2 deletions
Greg noticed that we were creating our own attribute groups, instead of
using the ATTRIBUTE_GROUPS macro, this patch fixes our mistake.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 33
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
From: Sameer Wadgaonkar
The function visorchipset_device_destroy just called remove_visor_device,
we can just combine it with remove_visor_device.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c| 9
From: David Binder
Removes unnecessary filename in the top file comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include
From: David Binder
The first line of the top file comment should begin on the line following
the block comment opening, thereby following the convention used elsewhere
in the driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging
1 - 100 of 943 matches
Mail list logo
