Re: [PATCH] staging/vc04_services/bcm2835-camera: distinct numeration and names for devices

2020-01-10 Thread Dave Stevenson
Hi Hans On Fri, 10 Jan 2020 at 13:25, Hans Verkuil wrote: > > Hi Michael, Kay, > > On 12/6/19 9:54 AM, Michael Kupfer wrote: > > Create a static atomic counter for numerating cameras. > > Use the Media Subsystem Kernel Internal API to create distinct > > device-names, so that the camera-number (g

Re: [PATCH 00/31] staging: bcm2835-camera: Improvements

2019-06-28 Thread Dave Stevenson
Hi Stefan On Fri, 28 Jun 2019 at 17:57, Stefan Wahren wrote: > > Hi Hans, > > Am 28.06.19 um 10:06 schrieb Hans Verkuil: > > Hi Stefan, > > > > On 6/27/19 8:55 PM, Stefan Wahren wrote: > >> This is an attempt to help Dave Stevenson to get all the fixes and

Re: [PATCH 00/31] staging: bcm2835-camera: Improvements

2019-06-28 Thread Dave Stevenson
Hi Stefan Firstly a huge thank you for picking this up - it's been on my to-do list for ages, and just hasn't made it to the top. On Fri, 28 Jun 2019 at 09:06, Hans Verkuil wrote: > > Hi Stefan, > > On 6/27/19 8:55 PM, Stefan Wahren wrote: > > This is an attempt t

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Dave Stevenson
Hi Nicolas On Thu, 27 Jun 2019 at 20:55, Nicolas Dufresne wrote: > > Hi Dave, > > Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > > From: Dave Stevenson > > > > H264 header come from VC with 0 timestamps, which means they get a > > strange tim

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-26 Thread Dave Stevenson
Hi Stefan. On Tue, 25 Jun 2019 at 17:30, Stefan Wahren wrote: > > Hi Dan, > hi Dave, > > Am 25.06.19 um 09:55 schrieb Dan Carpenter: > > On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote: > >> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in > >> ctrl_set_bitrate()") chang

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-11 Thread Dave Stevenson
Hi Peter On Fri, 11 Jan 2019 at 06:10, Peter Robinson wrote: > > Hi Stefan, > > > > > > I get difference results with 5.0-rc1 but neither of the above apps > > > > > work either, will follow up based on the rest of the thread there. > > > > > > > > > > > > > My first step with Raspbian is to enab

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Dave Stevenson
Hi Peter On Tue, 8 Jan 2019 at 07:21, Peter Robinson wrote: > > Hi Stefan, > > > This patch series improves the load/unload of bcm2835 camera and audio > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > This series based on current linux-next and Phil Elwell's s

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-29 Thread Dave Stevenson
Hi Stefan On Sun, 28 Oct 2018 at 08:31, Stefan Wahren wrote: > > Hi Dave, > > > Dave Stevenson hat am 26. Oktober 2018 um > > 19:15 geschrieben: > > > > > > Thanks Stefan. > > I've picked up your latest patches which mean I can get the driver

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-26 Thread Dave Stevenson
On Thu, 18 Oct 2018 at 10:38, Stefan Wahren wrote: > > Am 18.10.2018 um 11:22 schrieb Dave Stevenson: > > On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote: > >>>>>> Drop various pieces of dead code from here and there to get rid of > >>>>>>

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-18 Thread Dave Stevenson
On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote: > > > >> > Drop various pieces of dead code from here and there to get rid of > > >> > the remaining users of VCHI_CONNECTION_T. After that we get to drop > > >> > entire header files worth of unused code. > > >> > > > >> > I've tested on a Raspb

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-17 Thread Dave Stevenson
On Mon, 15 Oct 2018 at 17:27, Eric Anholt wrote: > > Stefan Wahren writes: > > > Hi Tuomas, > > > >> Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 > >> geschrieben: > >> > >> > >> Drop various pieces of dead code from here and there to get rid of > >> the remaining users of VCHI_CONNECTION_T

Re: [PATCH] staging: bcm2835-camera: remove extraneous setting of dev->colourfx.enable

2018-10-08 Thread Dave Stevenson
Hi Stefan. Thanks for forwarding as the linux-rpi-kernel list hasn't sent it to me as yet. On Mon, 8 Oct 2018 at 16:48, Stefan Wahren wrote: > > Hi Colin, > > Am 08.10.2018 um 16:50 schrieb Colin King: > > From: Colin Ian King > > > > Currently dev->colourfx.enable is being set twice, hence th

Re: [PATCH] staging: bcm2835-camera: remove extraneous setting of dev->colourfx.enable

2018-10-08 Thread Dave Stevenson
On Mon, 8 Oct 2018 at 18:09, Stefan Wahren wrote: > > Hi Dave, > > > Dave Stevenson hat am 8. Oktober 2018 um > > 18:51 geschrieben: > > > > > > Hi Stefan. > > > > Thanks for forwarding as the linux-rpi-kernel list hasn't sent it

Re: [PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-28 Thread Dave Stevenson
Hi Nate Thanks for the patch. On Fri, 28 Sep 2018 at 01:53, Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: > variable 'mains_freq_qmenu' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const

Re: [PATCH 1/2] staging: bcm2835-camera: Remove sleep at streaming start

2018-05-24 Thread Dave Stevenson
Hi Stefan. On 23 May 2018 at 21:30, Stefan Schake wrote: > This checks the preview component for overlay functionality, but that has > little to do with streaming (you don't need to enable the overlay to do > streaming). We shouldn't withhold frames from userspace because of an > estimate for AGC

Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

2018-05-11 Thread Dave Stevenson
On 11 May 2018 at 00:12, Stefan Schake wrote: > The overlay code is non-functional since it relies on firmware control > of the HVS. > > Signed-off-by: Stefan Schake > --- > Dave, does this match your understanding? Yes, the overlay only works if you are not running the vc4 driver, therefore dro

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-16 Thread Dave Stevenson
On 16 March 2017 at 05:11, Eric Anholt wrote: > Greg KH writes: > >> On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote: >>> You've got a reason. It's GPLv2 licenced code so I have no control >>> over what happens to it. >>> Everyw

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-15 Thread Dave Stevenson
On 15 March 2017 at 10:36, Dan Carpenter wrote: > On Wed, Mar 15, 2017 at 10:06:11AM +0000, Dave Stevenson wrote: >> On 15 March 2017 at 05:08, Greg KH wrote: >> > On Tue, Mar 14, 2017 at 03:32:43PM +0000, Dave Stevenson wrote: >> >> NACK. >> >> Ph

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-15 Thread Dave Stevenson
On 15 March 2017 at 05:08, Greg KH wrote: > On Tue, Mar 14, 2017 at 03:32:43PM +0000, Dave Stevenson wrote: >> NACK. >> Phil asked for a couple of changes, although functionally identical. >> I'll send a patch when I get a chance. > > What do you mean, "whe

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-14 Thread Dave Stevenson
15:10, Michael Zoran wrote: > From: Dave Stevenson > > https://github.com/raspberrypi/linux/issues/1447 > port_parameter_get() failed to account for the header > (u32 id and u32 size) in the size before memcpying > the response into the response buffer, so overrunning > the

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

2017-03-10 Thread Dave Stevenson
On 10 March 2017 at 11:16, Michael Zoran wrote: > On Fri, 2017-03-10 at 11:11 +0000, Dave Stevenson wrote: >> On 10 March 2017 at 05:08, Michael Zoran wrote: >> > The code that queries properties on the camera has a check >> > for buffer overruns if the firmware

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

2017-03-10 Thread Dave Stevenson
On 10 March 2017 at 05:08, Michael Zoran wrote: > The code that queries properties on the camera has a check > for buffer overruns if the firmware sends too much data. This > check is incorrect, and during testing I was seeing stack corruption. > > I believe this error can actually happen in norm

Re: [PATCH] staging: bcm2835-camera: Remove explicit cache flush operations

2017-03-08 Thread Dave Stevenson
On 8 March 2017 at 13:46, Michael Zoran wrote: > On Wed, 2017-03-08 at 13:19 +0000, Dave Stevenson wrote: > > Hi Michael. > > The original issue was on Pi1 with H264 or MJPEG streams. Buffer sizes were > small enough to fit in the L1 cache and the relevant sections weren'

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 12:58, Hans Verkuil wrote: On 02/06/2017 12:37 PM, Dave Stevenson wrote: Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Mauro. Can I just say that I'm not attempting to upstream this, others are. I've just answered questions raised. On 06/02/17 12:37, Mauro Carvalho Chehab wrote: Em Sun, 5 Feb 2017 22:15:21 + Dave Stevenson escreveu: If the goal was to protect some IP related to the sensor

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. On 01/27/2017 10:54 PM, Eric Anholt wrote: - Supports raw YUV capture, preview, JPEG and H264. - Uses videobu

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-05 Thread Dave Stevenson
of this archive + * for more details. + * + * Authors: Vincent Sanders + * Dave Stevenson + * Simon Mellor + * Luke Diamand All of these are now dead email addresses. Mine could be updated to dave.steven...@raspberrypi.org, but the others should probably be deleted. +