Re: [PATCH] Check if skb_alloc returns Null in function fw_download_code

2014-06-16 Thread Dave Jones
On Mon, Jun 16, 2014 at 09:07:45PM -0700, Greg KH wrote: > On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote: > > Signed-off-by: Nicholas Krause > > --- > > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/d

Re: [patch 1/2] staging/bcm: two information leaks in ioctl

2014-02-17 Thread Dave Jones
On Mon, Feb 17, 2014 at 11:13:16PM +0300, Dan Carpenter wrote: > On Mon, Feb 17, 2014 at 02:59:19PM -0500, Dave Jones wrote: > > On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote: > > > There are a couple paths where we don't check how much data we copy b

Re: [patch 1/2] staging/bcm: two information leaks in ioctl

2014-02-17 Thread Dave Jones
On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote: > There are a couple paths where we don't check how much data we copy back > to the user. I'm curious, is this something smatch is only picking up now that I chopped up that mega function into lots of little functions ? Dave

Re: staging: comedi: Fix boolean/logical and mix-up.

2013-11-27 Thread Dave Jones
On Wed, Nov 27, 2013 at 04:59:17PM +, Hartley Sweeten wrote: > > Added Greg KH and the staging devel list to the CCs. > > I just noticed that Dan Carpenter already submitted a patch that fixed this. > It was merged as commit 9382c06e2d192adec090fb09ff0b699e951f88e1. Ah, I didn't look at