Re: [PATCH] staging: iio/meter: add name to function definition arguments

2018-02-16 Thread Daniel Baluta
Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an identi

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-12 Thread Daniel Baluta
Hi Himanshi, On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote: > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a > string instead of implicit conversion to string using > preprocessors. Added double quotes around names in > existing usage of IIO_DEVICE_ATTR_NAMED. Always use imperative moo

Re: [PATCH v2 3/3] iio: hmc5843: Move hmc5843 out of staging

2016-02-22 Thread Daniel Baluta
x27;Industrial I/O support -> >> Magnetometer sensors' menu. >> >> Signed-off-by: Cristina Moraru >> Cc: Daniel Baluta > For some reason I couldn't immediately identify this patch wouldn't > apply to my tree. I hand applied it and all seemed fine, but pl

Re: [RFC PATCH 1/2] iio: hmc5843 Add channel attribute for bias configuration

2016-02-05 Thread Daniel Baluta
On Thu, Feb 4, 2016 at 7:45 PM, Lars-Peter Clausen wrote: > On 02/04/2016 03:50 PM, Cristina Moraru wrote: >> Replace non standard meas_conf attribute with the standard IIO >> calibbias attribute. >> >> API for setting bias measurement configuration: >> >> 0 - Normal measurement configuration (def

Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

2015-10-19 Thread Daniel Baluta
;: > (.text+0x208a04): undefined reference to `irq_work_queue' > > This changes the Kconfig file to match what other drivers do. > > Signed-off-by: Arnd Bergmann > Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to > irq_work") Acked-by: Daniel

Re: [PATCH] staging: iio_simple_dummy: Fix indentation errors

2015-08-05 Thread Daniel Baluta
On Wed, Aug 5, 2015 at 3:15 PM, Lars Svensson wrote: > Fixing indentation errors in > drivers/staging/iio/iio_simple_dummy_events.c. > > Signed-off-by: Lars Svensson Good catch. Acked-by: Daniel Baluta > --- > drivers/staging/iio/iio_simple_dummy_events.c | 4 ++-- &g

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-27 Thread Daniel Baluta
On Wed, May 27, 2015 at 8:29 PM, Dan Carpenter wrote: > On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote: >> On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: >> > Hi, >> > >> > On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambr

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

2015-05-26 Thread Daniel Baluta
Hi, On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs wrote: > This patch fixes the init function for the iio_simple_dummy driver. > The main issues were absence of kfree for the allocated array, and no > devices being removed in case the probe function fails, running in a loop. > > The iio_du

Re: randconfig build warnings in staging/iio/meter/

2014-12-15 Thread Daniel Baluta
On Mon, Dec 15, 2014 at 10:48 AM, devendra.aaru wrote: >> Hi, >> >> Thanks for reporting! We are working on IIO cleanup project [1] >> and we can take care of fixing this. >> > > Thanks for a very quick response. I did fix those warnings. Let me > know if i need to send patches to iio ml. All rig

Re: randconfig build warnings in staging/iio/meter/

2014-12-15 Thread Daniel Baluta
On Mon, Dec 15, 2014 at 10:25 AM, devendra.aaru wrote: > Hello, > > With next-20141215, i have got the following build warnings: > > > drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > drivers/staging/iio/meter/ade7754.

[PATCH] staging: iio: remove duplicate case labels

2014-07-07 Thread Daniel Baluta
staging: add recently added modifiers to iio_event_monitor) Signed-off-by: Daniel Baluta --- drivers/staging/iio/Documentation/iio_event_monitor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/iio/Documentation/iio_event_monitor.c b/drivers/staging/iio/Documentation

Re: [firefly] [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

2014-03-18 Thread Daniel Baluta
>> Signed-off-by: Matei Oprea >> Cc: ROSEdu Kernel Community > > Why the cc: for a non-maintainer / person? We try to keep track of student's contributions in this way. Also, patches are internally reviewed on this mailing list before sending them to maintainers. thanks, Daniel. ___