Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-28 Thread Dan Scally
On 17/09/2020 11:33, Sakari Ailus wrote: >> +sensor_props[3] = PROPERTY_ENTRY_U32_ARRAY_LEN("data-lanes", >> + data_lanes, >> + >> (int)ssdb->lanes); >> +sens

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-23 Thread Dan Scally
Hi Sakari On 17/09/2020 11:33, Sakari Ailus wrote: >> +ret = software_node_register_nodes(nodes); >> +if (ret) { >> +dev_err(dev, >> +"Failed to register software nodes for %s\n", >> +supported_devi

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-21 Thread Dan Scally
On 18/09/2020 14:07, Andy Shevchenko wrote: > On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote: >> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote: >>> On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: >>>> On 17/09/2020 11:3

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Scally
Hi Dan -  thanks for all your comments. Sorry it took a while to get to yours. On 17/09/2020 10:34, Dan Carpenter wrote: > On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: >> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c >> b/drivers/media/pci/intel/ipu3/ipu3-cio2.c >> index

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-18 Thread Dan Scally
Ah, shoot - good spot, thanks On 18/09/2020 09:03, Dan Carpenter wrote: > I ran Smatch over the code and it spotted an off by one. > > On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: >> +#define MAX_CONNECTED_DEVICES 4 >> +#define SWNODE_SENSOR_HID

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-17 Thread Dan Scally
Hi Andy, thanks for input (as always) On 17/09/2020 13:45, Andy Shevchenko wrote: > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: >> On 17/09/2020 11:33, Sakari Ailus wrote: > I will do better review for next version, assuming you will Cc reviewers and > TWIMC people

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-17 Thread Dan Scally
Hey Sakari - thanks for the reply On 17/09/2020 11:33, Sakari Ailus wrote: > Hi Daniel, > > Thank you for the patch. > > Is this all that it takes to add support for some machines shipped with > Windows? Almost > The ones I know require PMIC control done in software (not even > sensors are accessi

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-17 Thread Dan Scally
On 17/09/2020 11:15, Dan Carpenter wrote: > On Thu, Sep 17, 2020 at 10:47:50AM +0100, Dan Scally wrote: >> Hi Greg - thanks for the comments, appreciate it (sorry there's so many, >> I'm new to both C and kernel work) > It's pretty impressive work if you're

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-17 Thread Dan Scally
Hi Greg - thanks for the comments, appreciate it (sorry there's so many, I'm new to both C and kernel work) On 17/09/2020 08:53, Greg KH wrote: > On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote: >> MAINTAINERS | 6 + >> drivers/media/pci/intel/ipu3/ipu

Re: [PATCH] media: ipu3: add a module to probe sensors via ACPI

2020-09-08 Thread Dan Scally
Hi Heikki On 26/05/2020 15:31, Heikki Krogerus wrote: On Fri, May 22, 2020 at 11:57:36AM +0200, Mauro Carvalho Chehab wrote: Em Thu, 21 May 2020 11:00:19 +0300 Andy Shevchenko escreveu: +Cc: Heikki (swnode expert) On Wed, May 20, 2020 at 2:19 PM Mauro Carvalho Chehab wrote: Em Wed, 20 May

Re: [PATCH] media: ipu3: add a module to probe sensors via ACPI

2020-09-07 Thread Dan Scally
On 01/07/2020 02:16, Jordan Hand wrote: > On 5/26/20 7:31 AM, Heikki Krogerus wrote: >> On Fri, May 22, 2020 at 11:57:36AM +0200, Mauro Carvalho Chehab wrote: >>> Em Thu, 21 May 2020 11:00:19 +0300 >>> Andy Shevchenko escreveu: >>> +Cc: Heikki (swnode expert) On Wed, May 20, 2020 at