Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

2017-07-17 Thread Craig Inches
On Mon, Jul 17, 2017 at 05:44:59PM +, Dilger, Andreas wrote: > On Jul 12, 2017, at 03:03, Craig Inches wrote: > > > > This fixes a block statement which didnt end with */ > > > > Signed-off-by: Craig Inches > > --- > > drivers/staging/lustre/include/

[PATCH v2 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

2017-07-12 Thread Craig Inches
This fixes multiple block statements found not to match style as per checkpatch Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 + 1 file changed, 81 insertions(+), 48 deletions(-) diff --git a/drivers/staging/lustre/include/linux

[PATCH v2 4/4] Staging: Lustre Fix block statement style issue

2017-07-12 Thread Craig Inches
This fixes a block statement which didnt end with */ Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include

[PATCH v2 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h

2017-07-12 Thread Craig Inches
This patch fixes some multiline comment blocks which didnt conform to the style guide, found by checkpatch. Signed-off-by: Craig Inches --- .../staging/lustre/include/linux/lnet/lib-types.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v2 1/4] Staging: Lustre Clean up line over 80Char in lib-lnet.h

2017-07-12 Thread Craig Inches
This patch fixes a warning generated by checkpatch for a line over 80 characters. Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b

[PATCH v2 0/4] Staging: Lustre Style Fixes

2017-07-12 Thread Craig Inches
This series fixes a few style issues in lustre. All where picked up by checkpatch. v2 Changes: - Fixed typo in patch subject s/luster/lustre/ Craig

[PATCH 4/4] Staging: Lustre Fix block statement style issue

2017-07-06 Thread Craig Inches
This fixes a block statement which didnt end with */ Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include

[PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

2017-07-06 Thread Craig Inches
This fixes multiple block statements found not to match style as per checkpatch Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 + 1 file changed, 81 insertions(+), 48 deletions(-) diff --git a/drivers/staging/lustre/include/linux

[PATCH 1/4] Staging: Luster: Clean up line over 80Char in lib-lnet.h

2017-07-06 Thread Craig Inches
This patch fixes a warning generated by checkpatch for a line over 80 characters. Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b

[PATCH 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h

2017-07-06 Thread Craig Inches
This patch fixes some multiline comment blocks which didnt conform to the style guide, found by checkpatch. Signed-off-by: Craig Inches --- .../staging/lustre/include/linux/lnet/lib-types.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH 0/4] Staging: Lustre Style Fixes

2017-07-06 Thread Craig Inches
This series fixes a few style issues in lustre. All where picked up by checkpatch. Craig Inches (4): Staging: Luster: Clean up line over 80Char in lib-lnet.h Staging: Lustre Fix up multiple Block Comments in lib-types.h Staging: Lustre Fixing multiline block comments in lnetst.h Staging

[PATCH RESEND v2] Staging: lustre cleanup macros in libcfs_private.h

2017-04-13 Thread Craig Inches
This resolves a checkpatch warning that "Single statement macros should not use a do {} while (0) loop" by removing the loop and adjusting line length accordingly. Signed-off-by: Craig Inches --- Changes in v2: - Kept statements together - Kept operator on previous line

[PATCH v2] Staging: lustre cleanup macros in libcfs_private.h

2017-04-05 Thread Craig Inches
This resolves a checkpatch warning that "Single statement macros should not use a do {} while (0) loop" by removing the loop and adjusting line length accordingly. Signed-off-by: Craig Inches --- Changes in v2: - Kept statements together - Kept operator on previous line

[PATCH] Staging: lustre cleanup macros in libcfs_private.h

2017-04-03 Thread Craig Inches
This resolves a checkpatch warning that "Single statement macros should not use a do {} while (0) loop" by removing the loop and adjusting line length accordingly. Signed-off-by: Craig Inches --- .../lustre/include/linux/libcfs/libcfs_private.h | 51 +++--- 1 file c

Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h

2017-03-13 Thread Craig Inches
On Mon, Mar 13, 2017 at 03:11:10PM +0300, Dan Carpenter wrote: > On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote: > > On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote: > > > This patch resolves the "Comparisons should place the constant on > >

[PATCH] staging: lustre shorten multiple lines over 80 char in lu_object.h

2017-03-12 Thread Craig Inches
This patch adjusts lines so that they are less than 80 char. Checkpatch.pl idenitified the issue. Signed-off-by: Craig Inches --- drivers/staging/lustre/lustre/include/lu_object.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre

[PATCH] staging: lustre fix constant comparision style issue in lu_object.h

2017-03-11 Thread Craig Inches
This patch resolves the "Comparisons should place the constant on the right side of the test" found with checkpatch tool. Signed-off-by: Craig Inches --- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

2016-06-19 Thread Craig Inches
I did build the kernel 1 for each change, then a final with all changes applied. Apologies if I missed something, Craig On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote: > On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > > Macros with complex values

[PATCH 1/3] staging: luster: cl_object.h Checkpatch Cleanup

2016-06-18 Thread Craig Inches
Line length greater than 80 char. Signed-off-by: Craig Inches --- drivers/staging/lustre/lustre/include/cl_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h index

[PATCH 2/3] staging: luster: Checkpatch Cleanup

2016-06-18 Thread Craig Inches
Macros with complex values should be enclosed in parenthesis Signed-off-by: Craig Inches --- drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre

[PATCH 3/3] staging: luster: Checkpatch Cleanup

2016-06-18 Thread Craig Inches
WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Craig Inches --- drivers/staging/lustre/lustre/include/cl_object.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.

[PATCH 0/3] staging: luster: cl_object.h Checkpatch Cleanup

2016-06-18 Thread Craig Inches
Fix three different issues from checkpatch: Line over 80 Chars Unsigned int prefered over unsigned Macros with complex values should be enclosed in parenthesis Craig Inches (3): checkpatch style issue: Line over 80 char Checkpatch style issue: Checkpatch error cleanup drivers/staging

[PATCH] Staging: Android: Fix bracket alignment style issue in sync.c

2016-05-21 Thread Craig Inches
This patch changes 3 bracket alignment errors found by checkpatch. Signed-off-by: Craig Inches --- drivers/staging/android/sync.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 3a8f210..4a64bdd

Re: [PATCH v2] Drivers: Staging: dgnc: Fix Style Issues

2015-07-17 Thread Craig Inches
On Thu, Jul 16, 2015 at 11:13:43PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 03:03:24AM +0000, Craig Inches wrote: > > Fixed multiple instances of: > > > > CHECK: Alignment should match open parenthesis > > CHECK: Blank lines aren't necessary before a c

[PATCH v2] Drivers: Staging: dgnc: Fix Style Issues

2015-07-16 Thread Craig Inches
Fixed multiple instances of: CHECK: Alignment should match open parenthesis CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary after an open brace '{' WARNING: line over

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
Hi Joe, On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote: > > Fixed up some checkpatch.pl style issues. > > Line greater than 80 Chars in multiple locations. > > I think most all of these are not improvem

[PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
Fixed up some checkpatch.pl style issues. Line greater than 80 Chars in multiple locations. Signed-off-by: Craig Inches --- drivers/staging/dgnc/dgnc_tty.c | 168 ++-- 1 file changed, 110 insertions(+), 58 deletions(-) diff --git a/drivers/staging/dgnc

Re: [PATCH] Staging: drivers: dgnc

2015-07-16 Thread Craig Inches
On Fri, Jul 17, 2015 at 12:20:42AM +, Craig Inches wrote: > Hi Joe, > > On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote: > > > Fixed up some checkpatch.pl style issues. > > > Line

Re: [PATCH] Staging: android: ion: Fix Style Issue

2015-07-13 Thread Craig Inches
On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote: > On Mon, 2015-07-13 at 17:29 +, Craig wrote: > > Modified style issue in ion.c. Missing empty line after a definition > > > > Signed-off-by: Craig > > --- > > drivers/staging/android/ion/ion.c | 1 + > > 1 file changed, 1 insertio