[PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32

2017-02-09 Thread Carlos Palminha
Fixed missing conversion to le32, detected by sparse (invalid assignment from int to __le32) Signed-off-by: Carlos Palminha --- v1->v2: missed sob line (too late in the night...) drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH] staging: rtl8712: rtl8712: fixed missing conversion to le32

2017-02-08 Thread Carlos Palminha
Fixed missing conversion to le32, detected by sparse (invalid assignment from int to __le32) --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c index 041508

[PATCH v2] staging: rtl8712: rtl8712: fix sparse warnings

2017-02-07 Thread Carlos Palminha
Fixed sparse warnings * No need to convert from le32, pointers for structure with same endianness (cast from restricted __le32) * Need to convert bitwise operation for le32 structure (invalid assignment from int to __le32) Signed-off-by: Carlos Palminha --- Changes v1->v2: * Clarify pa

Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings

2017-02-07 Thread Carlos Palminha
On 08-02-2017 00:58, Dan Carpenter wrote: On Wed, Feb 08, 2017 at 12:47:22AM +, Carlos Palminha wrote: Fixed the following sparse warnings: * cast from restricted __le32 * invalid assignment from int to __le32 The changelog doesn't give me any confidence that you understan

[PATCH] staging: rtl8712: rtl8712: fix sparse warnings

2017-02-07 Thread Carlos Palminha
Fixed the following sparse warnings: * cast from restricted __le32 * invalid assignment from int to __le32 Signed-off-by: Carlos Palminha --- drivers/staging/rtl8712/rtl8712_xmit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c

[PATCH] staging: fbtft: fix NULL comparison checkpatch warning

2016-09-29 Thread Carlos Palminha
Fixed the following checkpatch warnings (task #10 of eudyptula challenge): - NULL comparison rewritten to use '!' operator Signed-off-by: Carlos Palminha --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH v3] staging: fbtft: Fix checkpatch warning

2016-09-29 Thread Carlos Palminha
Fixed the following checkpatch warnings (task #10 of eudyptula challenge): - removed unnecessary blank line after open brace - NULL comparison rewritten to use '!' operator Signed-off-by: Carlos Palminha --- Changes v2->v3: - Improved explanation text. Changes v1->v2: - Added s

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
Improve code readability. Signed-off-by: Carlos Palminha --- Changes v1->v2: - Added signed-off-by and comment. drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fb

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
--- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e9f25dd..0883715 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft