Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

2018-07-30 Thread Carlos Maiolino
On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren wrote: > Am 30.07.2018 um 11:43 schrieb Carlos Maiolino: >> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren >> wrote: >>> i think easiest the way would be to get a recent Raspbian Lite ( >>> https://www.r

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

2018-07-30 Thread Carlos Maiolino
On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren wrote: > Hi Carlos, > > Am 30.07.2018 um 11:25 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren >> wrote: >>> >>> Hi Carlos, >>> >>> >>> Am 30.07.

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

2018-07-30 Thread Carlos Maiolino
On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren wrote: > Hi Carlos, > > > Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: >>> >>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wr

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

2018-07-30 Thread Carlos Maiolino
On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: >> Fix several sparse warnings regarding different address space >> assignments, like example below, by properly annotating pointers >> expected to carry

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

2018-07-24 Thread Carlos Maiolino
Fix several sparse warnings regarding different address space assignments, like example below, by properly annotating pointers expected to carry user space addresses. warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Carlos Maiolino --- I'm not subscribed t

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

2016-10-17 Thread Carlos Maiolino
Yes, thanks for the heads up. I'll try to avoid such mistakes in the next patches On Mon, Oct 17, 2016 at 6:29 PM, Greg KH wrote: > On Mon, Oct 17, 2016 at 06:17:21PM +0200, Carlos Maiolino wrote: >> >> --- >> >> drivers/staging/rt

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

2016-10-17 Thread Carlos Maiolino
>> --- >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 28 >> +-- >> 1 file changed, 14 insertions(+), 14 deletions(-) > > Any reason you didn't use scripts/get_maintainer.pl to cc: the relevant > maintainers and developers of this code? > > thanks, > > greg k-h Not at

[PATCH] staging: rtl8188eu: Fix coding style errors

2016-10-17 Thread Carlos Maiolino
Fix coding style errors reported by checkpatch.pl, specifically: ERROR: space prohibited before that ',' (ctx:WxW) This patch get rid of all "ERROR" messages from checkpatch.pl for this file Signed-off-by: Carlos Maiolino --- drivers/staging/rtl8188eu/core

Re: [PATCH 0/3] staging: ks7010: Coding style fixes

2016-10-17 Thread Carlos Maiolino
Hi Greg, I've based these patches on top of linux-next. Thanks anyway. Which tree are you applying these patches on? I'll make sure to submit next patches based on your tree. Cheers On Mon, Oct 17, 2016 at 10:27 AM, Greg KH wrote: > On Sun, Oct 16, 2016 at 10:16:00PM +0200, Ca

[PATCH 3/3] staging: ks7010: add missing blank lines

2016-10-16 Thread Carlos Maiolino
Use blank lines to separate variable declarations from statements, fixing the following checkpatch.pl issue: WARNING: Missing a blank line after declarations Signed-off-by: Carlos Maiolino --- drivers/staging/ks7010/ks_hostif.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers

[PATCH 2/3] staging: ks7010: Fix coding style spacing issues

2016-10-16 Thread Carlos Maiolino
that close parenthesis ')' ERROR: exactly one space required after that #ifdef ERROR: space prohibited after that '&' (ctx:WxW) Signed-off-by: Carlos Maiolino --- drivers/staging/ks7010/ks_hostif.c | 202 ++--- 1 file changed, 101 insertions(

[PATCH 1/3] staging: ks7010: Fix conditional statements coding style

2016-10-16 Thread Carlos Maiolino
Fix coding style issues in if statements braces, specifically: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Carlos Maiolino

[PATCH 0/3] staging: ks7010: Coding style fixes

2016-10-16 Thread Carlos Maiolino
A small patchset fixing some coding style errors identified by checkpatch.pl Greg. I splitted the single patch into 3 different patches now, hope I set it right now :) Also added a blank line before the signed-off. Cheers Carlos Maiolino (3): staging: ks7010: Fix conditional statements

[PATCH] staging: ks7010: Fix coding style errors

2016-10-16 Thread Carlos Maiolino
OR: exactly one space required after that #ifdef WARNING: Missing a blank line after declarations ERROR: space prohibited after that '&' (ctx:WxW) WARNING: braces {} are not necessary for single statement blocks CHECK: No space is necessary after a cast Signed-off-by: Carlos Maiolino