Re: [PATCH v4 00/52] mtd: rework ECC layout definition

2016-03-10 Thread Brian Norris
On Mon, Mar 07, 2016 at 10:46:50AM +0100, Boris Brezillon wrote: > Hello, > > This patchset aims at getting rid of the nand_ecclayout limitations. > struct nand_ecclayout is defining fixed eccpos and oobfree arrays which > can only be increased by modifying the MTD_MAX_ECCPOS_ENTRIES_LARGE and > M

Re: [PATCH v3 16/52] mtd: nand: use mtd_set_ecclayout() where appropriate

2016-03-04 Thread Brian Norris
On Fri, Feb 26, 2016 at 01:57:24AM +0100, Boris Brezillon wrote: > Use the mtd_set_ecclayout() helper instead of directly assigning the > mtd->ecclayout field. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [PATCH 00/23] mtd: rework ECC layout definition

2016-01-26 Thread Brian Norris
Hi Boris, On Mon, Dec 07, 2015 at 11:25:55PM +0100, Boris Brezillon wrote: > Hello, > > This patchset aims at getting rid of the nand_ecclayout limitations. > struct nand_ecclayout is defining fixed eccpos and oobfree arrays which > can only be increased by modifying the MTD_MAX_ECCPOS_ENTRIES_LA

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2015-12-18 Thread Brian Norris
Hi Boris, On Thu, Dec 10, 2015 at 09:00:39AM +0100, Boris Brezillon wrote: > Add two helpers to access the field reserved for private controller data. > This makes it clearer what this field is reserved for and ease future > refactoring. I agree with the refactoring part, but I'm not sure about t

Re: [PATCH v4 00/58] mtd: nand: refactor the NAND subsystem (part 1)

2015-12-18 Thread Brian Norris
Hi, On Thu, Dec 10, 2015 at 08:59:44AM +0100, Boris Brezillon wrote: > Hello, > > This huge series aims at clarifying the relationship between the mtd and > nand_chip structures and hiding NAND framework internals to NAND > controller drivers. > > The first part of the series (patch 1 to 4) is a

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Brian Norris
Hi Boris, On Fri, Dec 11, 2015 at 11:03:05PM +0100, Boris Brezillon wrote: > On Thu, 10 Dec 2015 16:40:08 -0800 > Brian Norris wrote: > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > > Unregister the NAND device from the NAND subsystem when removin

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-10 Thread Brian Norris
On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > Unregister the NAND device from the NAND subsystem when removing a denali > NAND controller, otherwise the MTD attached to the NAND device is still > exposed by the MTD layer, and accesses to this device will likely crash > the syst

Re: [PATCH v2 00/25] mtd: nand: refactor the NAND subsystem (part 1)

2015-12-08 Thread Brian Norris
Hi, On Tue, Dec 01, 2015 at 12:02:57PM +0100, Boris Brezillon wrote: > Hello, > > This huge series aims at clarifying the relationship between the mtd and > nand_chip structures and hiding NAND framework internals to NAND > controller drivers. > > The first part of the series provide an mtd_to_n

Re: [PATCH v3 bis 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-12-08 Thread Brian Norris
Hi Boris, On Wed, Dec 02, 2015 at 09:50:01AM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillo

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-12-01 Thread Brian Norris
On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillon > Cc: Ju

Re: [PATCH v2 17/25] mtd: nand: remove useless mtd->priv = chip assignments

2015-12-01 Thread Brian Norris
On Tue, Dec 01, 2015 at 12:03:14PM +0100, Boris Brezillon wrote: > mtd_to_nand() now uses the container_of() approach to transform an > mtd_info pointer into a nand_chip one. Drop useless mtd->priv > assignments from NAND controller drivers. > > Signed-off-by: Boris Brezillon > --- > Patch genera

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-12-01 Thread Brian Norris
Hi Boris, On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillo

Re: [PATCH 03/27] mtd: nand: update examples in the documentation to use mtd_to_nand()

2015-11-19 Thread Brian Norris
On Mon, Nov 16, 2015 at 02:37:36PM +0100, Boris Brezillon wrote: > mtd_to_nand() has been introduced to hide accesses to mtd->priv. > All NAND controller drivers should use it instead of directly accessing > the ->priv field. > > Signed-off-by: Boris Brezillon Pushed to l2-mtd.git __

Re: [PATCH 02/27] mtd: nand: add an mtd_to_nand() helper

2015-11-19 Thread Brian Norris
On Mon, Nov 16, 2015 at 02:37:35PM +0100, Boris Brezillon wrote: > Some drivers are retrieving the nand_chip pointer using the container_of > macro on a struct wrapping both the nand_chip and the mtd_info struct while > the standard way of retrieving this pointer is through mtd->priv. > Provide an

Re: [PATCH 01/27] mtd: nand: fix drivers abusing mtd->priv

2015-11-19 Thread Brian Norris
On Mon, Nov 16, 2015 at 02:37:34PM +0100, Boris Brezillon wrote: > The ->priv field of the mtd_info object attached to a nand_chip device > should point to the nand_chip device. The pxa and cafe drivers are > assigning this field their own private structure, which works fine as long > as the nand_c

Re: [PATCH 18/27] mtd: nand: update mtd_to_nand()

2015-11-16 Thread Brian Norris
On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > Now that all drivers are using the mtd instance embedded in the nand_chip Do you have a script that verifies this? I thought you did at some point, and it'd be nice to note it, so I can also use it to verify things once it gets app

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-11-16 Thread Brian Norris
Hi Boris, On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillo

Re: [PATCH v4] mtd: nand: pass page number to ecc->write_xxx() methods

2015-10-13 Thread Brian Norris
On Tue, Oct 13, 2015 at 11:22:18AM +0200, Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomizati

Re: [PATCH v3] mtd: nand: pass page number to ecc->write_xxx() methods

2015-10-12 Thread Brian Norris
On Fri, Oct 02, 2015 at 07:53:25AM +0200, Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomizati

Re: [RESEND PATCH v2] mtd: nand: pass page number to ecc->write_xxx() methods

2015-10-01 Thread Brian Norris
On Thu, Oct 01, 2015 at 09:34:51PM +0200, Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomizati

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

2015-10-01 Thread Brian Norris
On Mon, Aug 24, 2015 at 07:10:19PM +0200, Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomizati

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

2015-10-01 Thread Brian Norris
On Thu, Oct 01, 2015 at 05:07:43PM +0200, Boris Brezillon wrote: > On Mon, 24 Aug 2015 19:10:19 +0200 > Boris Brezillon wrote: > > > The ->read_xxx() methods are all passed the page number the NAND controller > > is supposed to read, but ->write_xxx() do not have such a parameter. > > > > This i

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: > Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches ^^^ I'm dying to know how this sentence ends :) > Patch #18 changes the logic of spi_uevent() to report an OF modalias if > the device was registered usi

Re: [PATCH] staging: mt29f_spinand: Fix typo in Kconfig

2015-01-20 Thread Brian Norris
On Thu, Jan 15, 2015 at 07:47:24PM +0900, Masanari Iida wrote: > This patch fix a spelling typo in Kconfig. > > Signed-off-by: Masanari Iida Acked-by: Brian Norris Greg, do you take these patches, or should they go through me? FWIW, we have high hopes to kill and replace this driver

Re: [PATCH] Staging: MTD: Micron SPINAND Driver support

2013-10-02 Thread Brian Norris
On Tue, Oct 01, 2013 at 03:03:58PM +0530, Kamlakant Patel wrote: > This patch adds support for Micron SPINAND via MTD. > > Signed-off-by: Mona Anonuevo > Signed-off-by: Kamlakant Patel > --- > This patch has to be merged via staging tree. > > This is a driver from Micron for MT29F1G01ZACH4 SP